From: Nhat Pham <nphamcs@gmail.com>
To: Kairui Song <kasong@tencent.com>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Chris Li <chrisl@kernel.org>, Baoquan He <bhe@redhat.com>,
Barry Song <baohua@kernel.org>,
"Huang, Ying" <ying.huang@linux.alibaba.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] mm, swap: remove fragment clusters counter
Date: Wed, 6 Aug 2025 09:40:57 -0700 [thread overview]
Message-ID: <CAKEwX=N8sUdAfgGdHs+S3Sr62AJ94+6nbP62Smv_z0xxzz_t4g@mail.gmail.com> (raw)
In-Reply-To: <20250806161748.76651-3-ryncsn@gmail.com>
On Wed, Aug 6, 2025 at 9:18 AM Kairui Song <ryncsn@gmail.com> wrote:
>
> From: Kairui Song <kasong@tencent.com>
>
> It was used for calculating the iteration number when the swap allocator
> wants to scan the whole fragment list. Now the allocator only scans one
> fragment cluster at a time, so no one uses this counter anymore.
>
> Remove it as a cleanup; the performance change is marginal:
>
> Build linux kernel using 10G ZRAM, make -j96, defconfig with 2G cgroup
> memory limit, on top of tmpfs, 64kB mTHP enabled:
>
> Before: sys time: 6278.45s
> After: sys time: 6176.34s
>
> Change to 8G ZRAM:
>
> Before: sys time: 5572.85s
> After: sys time: 5531.49s
>
> Signed-off-by: Kairui Song <kasong@tencent.com>
Reviewed-by: Nhat Pham <nphamcs@gmail.com>
next prev parent reply other threads:[~2025-08-06 16:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 16:17 [PATCH v2 0/3] mm, swap: improve cluster scan strategy Kairui Song
2025-08-06 16:17 ` [PATCH v2 1/3] mm, swap: only scan one cluster in fragment list Kairui Song
2025-08-07 5:32 ` Chris Li
2025-08-07 18:26 ` Kairui Song
2025-08-06 16:17 ` [PATCH v2 2/3] mm, swap: remove fragment clusters counter Kairui Song
2025-08-06 16:40 ` Nhat Pham [this message]
2025-08-07 5:34 ` Chris Li
2025-09-02 12:17 ` Chris Li
2025-08-06 16:17 ` [PATCH v2 3/3] mm, swap: prefer nonfull over free clusters Kairui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKEwX=N8sUdAfgGdHs+S3Sr62AJ94+6nbP62Smv_z0xxzz_t4g@mail.gmail.com' \
--to=nphamcs@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=bhe@redhat.com \
--cc=chrisl@kernel.org \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shikemeng@huaweicloud.com \
--cc=ying.huang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox