From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28095C83F11 for ; Mon, 28 Aug 2023 14:04:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA3468E001C; Mon, 28 Aug 2023 10:04:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B52098E000E; Mon, 28 Aug 2023 10:04:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1A8D8E001C; Mon, 28 Aug 2023 10:04:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9146A8E000E for ; Mon, 28 Aug 2023 10:04:14 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 63E3216048C for ; Mon, 28 Aug 2023 14:04:14 +0000 (UTC) X-FDA: 81173682828.14.B4D1FB8 Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by imf23.hostedemail.com (Postfix) with ESMTP id 85A9E14002B for ; Mon, 28 Aug 2023 14:04:12 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VtgrswRm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.170 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693231452; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QO/0yzinyXD/hSG0Q5f8uk+7u0UqykPSt0Y98zMTs2E=; b=2xQNIBj2BWTOCKktklq5iHJVAJCY++owSCK+AQqBEI6gSqaHULkBeMnMu8cFkE2oO1EkHR NL3Bnw4TlozWLS/IQOECff3OegcU+A5TpbTHrOxW8aGeMFBXhaBlPEq4W0pUj4WwqTOD/a yGOFIYSaWm7TSp1GFOZWCVk4kImNZ1g= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=VtgrswRm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.170 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693231452; a=rsa-sha256; cv=none; b=A3o3HJuLCQ1vlZOoFcy7wylmx9AM04zKVoFW89R1JHDHRWL/OjNscYLbLFr0nzagYdEY1B u4KwZDMLvas6dizEaeRB5/4PaAIU7M+B8p6yUh/H/sTRS+ql++tolJkYvF5VV753JEoySN rizeosxYFwfPdmNWJkND/YRFtQ7MJQA= Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-34cafafa50eso11792925ab.3 for ; Mon, 28 Aug 2023 07:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693231451; x=1693836251; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QO/0yzinyXD/hSG0Q5f8uk+7u0UqykPSt0Y98zMTs2E=; b=VtgrswRmSpieizDNd3sDh4uK2sYz+YMy76+l+go2+LU+FbOdPOJAeoEWrvrGStBK2x xZUSCk7LLD8Y0GheITvIVHnSZmOrCEUa8YbK2fROUIpHREdKIc8LzfHHBTndYiNdZDFj incMH/0FSsapifMrsqVmxmIGDoIOH8496eWmw2v6KmgPmFxP1QMn7cBL1159aIv85tWy wTVRIIeZ6l7ZPZII4HJ0Xgjtblel8/H8A1I/abNDT8JNLxRVEUgsG87pug4Qx0JB7SKd 8LIFaSK68h1tSgJ9obolIMzU7wshC6GgbVxvLhVS9p/ai73KpI/I/I4jg8YLSiZ4s7pq iPSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693231451; x=1693836251; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QO/0yzinyXD/hSG0Q5f8uk+7u0UqykPSt0Y98zMTs2E=; b=jPNXY25PqwnIcCG/nwMhnfQlPxnshjhG8i0eTIoTW1kf5mqkewIEyKUWQE2xRY5yXL /sePvwwzs1sFDjl5/HU9mgGNjAACFsoaOtjIBRRpt3Vvi6sXzLggih+Qm5Yxi+rljwKL ie6BBvJXDszxuFMao8V2y5GdAmLzOKZ1Bd7p8rRrcMr5XvbJJKUK564zIvLg//7KHQ9b 6/Y1qYugTqHMSSnZqVRQpvF77WvS4ofotAuGGZRxvLUXHEPmL8Lw2Nzuj71ijyca2Vky JEes3b8fsSmL2zLZeZ3pOoOMpzY/Ics9OxeeH0FqeeIV7KR0UDjvQxwFk6Os3b5UiC+C 0bPw== X-Gm-Message-State: AOJu0Yy3TxYSVsB8LaoRhe0KELDaWGW9EYeCAdPURqz7yk5hUThwA43Y KampUTaGo3cQLB3HSzPNAEmvfJRuegCSpSa9VLs= X-Google-Smtp-Source: AGHT+IHD6r4K9VOXiW0zzZKA3tw281hWmYbuHL0gBRqgtlMGVnobIrVdBBxtk1LpfuNpCDVJ5n+7QuH8kvFme18WdFY= X-Received: by 2002:a05:6e02:12ac:b0:348:987a:fd8c with SMTP id f12-20020a056e0212ac00b00348987afd8cmr14265345ilr.31.1693231451670; Mon, 28 Aug 2023 07:04:11 -0700 (PDT) MIME-Version: 1.0 References: <8417dcd7ebdc464d12850873d6c48f95293e673c.1693216959.git.maciej.wieczor-retman@intel.com> In-Reply-To: From: Nhat Pham Date: Mon, 28 Aug 2023 10:04:00 -0400 Message-ID: Subject: Re: [PATCH 2/6] selftests/cachestat: Fix print_cachestat format To: "Wieczor-Retman, Maciej" Cc: Johannes Weiner , Shuah Khan , ilpo.jarvinen@linux.intel.com, reinette.chatre@intel.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 85A9E14002B X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: skotwoosz1z8ectm4wyhqhufz49juptz X-HE-Tag: 1693231452-962633 X-HE-Meta: U2FsdGVkX1+FNd9vSUpFJQII7KAOaVJT0IQP6YlCfJ63Z9fgLs+7AAHgqdH2Dndw7Dmzm8y/UR7vfLyX372v+Wtzx+TpbLBVZUcMoCiu7pR9VYGxh80dx/YT3VLk1kgiMt5yafAryDQLYLD+0kRrSwjU5LsHfBlrPg3v50g2lDfFVwiPlfz8tnwjAhzMdSO48m31Vh1cSc/PdEUjT/KKbHwyxT3Nnz/BLli9L9QL+Sv9NFFtBhqItxa6UnnNUug8idWKkpooK7smBQFIIHuZdYz5tQtLj4v+3IYGL99Sen2j0obokHHEJxKqcNPIJZA+Be65b4ZrgjcHaHSbaMng3IAa43fKmZddI01GALK6zPmNQnzQIiAfQ0exVgB4EYKw6nJzlQ6HZb4cx2TBUMlLPNT5w0qNHpEnUnNKQ+sRAKQrXye2AkXZFI6kxljh6zlcqUJU1fYRa5D2B3GQxbQXkxr6SfRz2IB6vTNn2/cL++S835iO82apLlJr74o1nC3MvRrOz2M/fCpuJ/7CuF1HNOKPBzVbiOPh1IvPwERReAIj5r3ZtkiQVGPyNO2RxnAK3GXcLlgc+4axMrYzscWGjCHLd9U2Y/lSBN8ami5FNRNJnNPlQyzyXKm2FGj/krcGla+e9BLC0hUyRN3EbeatGdtjftaeZFHi03KJ4U25Xr01GF4q4j3hJM4vkN4JAxkJ2pZsJT13OAmR90wt1VO0j/A4eSmRg7BfWi7BeSCuUDrppPBW6QYYp2nqgRVlhk8L8IRcnGo02Rru3Zezfy1fitdwFsLGTm82g0krRngUyE9J8+r4xz/ITxDxjGITxkbnNT5zR7PNU9q1Iv2Ayrb/s/K0Yyr0S0R/UJL/gpfSLZOBcDa5xLOeGFbAKc+2E37wgPnigkv55bJdeHTzclRlTPDQ2NTOf0sfY7qBAEpr2ZhX/Twy1pOKM51ouIKFDmlk10DJQmO5gOMedN+IbzD 0WeP3pwf Lut0H7DsF28Wj4lmOGiXLcIZ76PNH2AffgZTCe6A0MwO8tqsLcZ1wAIj804NCYuZbvIuHG1/hGUwis9qUMx0B6GVi/HA7trsdyhyZBeNWQT9fSQG1eqJYLyUtNX3MPyd1tSGmv8wZDGqVARG1RXdaeWsDmyW7Eenbcsm64TOVq1R5Qp412qCBRkyH8EW/oP9gm1/OFrbf72PFsXA9r3MUJjyZoCIjlxC+PYrYdKbpyiONW+pWQuIJzAvTA4BLiSZ1bgsPiLtBCvNxSyDjWMDsl9zVYUgPhFeLuSnk8VDtzSrVE/GftqXRii5jvzx+btXcQN97li5diB09gvWESu3KxmJTo35WHpr3ZdDQxRNxpPPEap/w/TaBrB7hIW3l/VbGVuFhUseu1STmnNQhSZZBhgrl8q7gr8APu3YeaqpDkMAzAsLfAuBQMImseewGypQ51rsQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 28, 2023 at 10:00=E2=80=AFAM Nhat Pham wrot= e: > > On Mon, Aug 28, 2023 at 6:50=E2=80=AFAM Wieczor-Retman, Maciej > wrote: > > > > The format specifier in printf() call expects long int variables and > > received long long int. > > > > Change format specifiers to long long int so they match passed > > variables. > > > > Signed-off-by: Wieczor-Retman, Maciej > > --- > > tools/testing/selftests/cachestat/test_cachestat.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools= /testing/selftests/cachestat/test_cachestat.c > > index 77620e7ecf56..a7adf42afb20 100644 > > --- a/tools/testing/selftests/cachestat/test_cachestat.c > > +++ b/tools/testing/selftests/cachestat/test_cachestat.c > > @@ -25,7 +25,7 @@ static const char * const dev_files[] =3D { > > void print_cachestat(struct cachestat *cs) > > { > > ksft_print_msg( > > - "Using cachestat: Cached: %lu, Dirty: %lu, Writeback: %lu, Evic= ted: %lu, Recently Evicted: %lu\n", > > + "Using cachestat: Cached: %llu, Dirty: %llu, Writeback: %llu, E= victed: %llu, Recently Evicted: %llu\n", > The fields of struct cachestat should all be unsigned longs, > Is there a compiler warning that prompt this change? Ah nvm, it's _u64. %llu is probably the better format specifier indeed. Acked-by: Nhat Pham > > cs->nr_cache, cs->nr_dirty, cs->nr_writeback, > > cs->nr_evicted, cs->nr_recently_evicted); > > } > > -- > > 2.42.0 > >