From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AF5CD591B1 for ; Mon, 18 Nov 2024 20:01:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 938946B0083; Mon, 18 Nov 2024 15:01:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E8786B0085; Mon, 18 Nov 2024 15:01:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 789546B0088; Mon, 18 Nov 2024 15:01:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 56DB86B0083 for ; Mon, 18 Nov 2024 15:01:05 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0FA2BC051D for ; Mon, 18 Nov 2024 20:01:05 +0000 (UTC) X-FDA: 82800281970.03.BB7D839 Received: from relay.hostedemail.com (unirelay08 [10.200.18.71]) by imf28.hostedemail.com (Postfix) with ESMTP id D32FAC0017 for ; Mon, 18 Nov 2024 20:00:11 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; arc=pass ("hostedemail.com:s=arc-20220608:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1731959996; a=rsa-sha256; cv=pass; b=Sw3H/Us7/678KbbyFbiU4mrx/nViSP3QAHhwoe4cMQEL9lAYf+sDPI1l9ak6Xsd5Q7gG80 tT7771FpYMRNTHs51T9sNZltbvy8jVWjJ8nVknU2I/bBt6XRtEOLcp8a4czaiNBxNOgqX7 IFY857/q7SbJW/7F8C6VUZwvuQ7XQgU= ARC-Authentication-Results: i=2; imf28.hostedemail.com; arc=pass ("hostedemail.com:s=arc-20220608:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731959996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ds/YaksKodiez8Zs+hfwM7ZBk1XcwUwsUC/7ldUhHZA=; b=DtZmqyjibyUkzMZUjCCLhr7oim+hdVwZGifIdjl3CX+a6GD69sGK56Pk5WeHDAWVFNEiDR VjT+8w+lebeEmPOnhgvrolrA4706Qu0gUt8Sq7ybxZGPYtAV+hvz3Y88CG3dmM6hTd+6Xv 6T8wAKcCY7d0COvcojsrXOasAZvUYnY= Received: from relay.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 562E3140524 for ; Mon, 18 Nov 2024 20:01:02 +0000 (UTC) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 265CE80508 for ; Mon, 18 Nov 2024 20:01:02 +0000 (UTC) X-FDA: 82800282852.23.13D9271 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by imf18.hostedemail.com (Postfix) with ESMTP id 342341C0004 for ; Mon, 18 Nov 2024 20:00:38 +0000 (UTC) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731960000; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ds/YaksKodiez8Zs+hfwM7ZBk1XcwUwsUC/7ldUhHZA=; b=8Ur9l5bfy51ojGciyr/QxtGGPT9+AzUaYOKgafNqm3Chppm3jjby/5ND2as2bNTB7B0lS2 adMk3imOL9WYDL/V9/wY9jE3tRbeeM0lh7f+s2wZ4OpJZUbxaQTpL6fnDALUFTI8K65IY9 j/66Rm1Fpa8d2S7/mR1LLvyoGCcDzUo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731960000; a=rsa-sha256; cv=none; b=fF4eGkarm5Jg6LDDTtz+FEyElTbNsCWIZ6hgDiyVc+yl/esmrYuxd2gLKjf2bl4EVJj8UZ BqWRX4rrOY6QwjlSfiZWJ8AZPGJyYIa9LuANWT4SxPtmIaD//B2tQATjORlb0R6uxAz8i3 GoDPL/VAycAFqUazsxDRF3f0LdVoLW4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="G5vEts/d"; spf=pass (imf18.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.52 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6d4241457b7so1110666d6.2 for ; Mon, 18 Nov 2024 12:01:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731960059; x=1732564859; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ds/YaksKodiez8Zs+hfwM7ZBk1XcwUwsUC/7ldUhHZA=; b=G5vEts/dXliAzlRiRBkN+d4pONNjtQqB1murJZoYFm5iD3JXosC1V+iyXVjMtyDz1I aSuDgKpq1EZ+9HRUnORjCFZi95qNQ8Q91n0lkrt1luFiFXpB/Q4j7sDXooeke/UrXZcl nV/ZCFp9wy/K0EmLfZuzykbZDfV1D0idLrTF7kHWKYrKyTebWuNCrQqTAhqt74ZlyWuV n+08DFTWBpZaXiJHdp/U60+SPDbcdO/pCy93v1sYnQ2ccL77zwbH59DrNkbDgw3MwjBf opWm73aaDXsSd6a0/L0uqqMZzMs8r9fBkVXtENWULdlkFizP1qdihqVhbuYCnsvdyjAL ZMZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731960059; x=1732564859; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ds/YaksKodiez8Zs+hfwM7ZBk1XcwUwsUC/7ldUhHZA=; b=O1erZrFVejdfW2dfsd60iJfr4Hs8NwfWW2r08nbWlmVrPMpY+tCnz5N69jz5XDEP7Q Q8c1vxkJKzLFPk1EQ3tiPUkbvDktFdnnQXmxQoHowB6pP3/7RC1folliAU77ajk5NNw4 UTOP3zbxRbUNZw/UnHgu5+E4x5/FZ8rZnunAt5YCtXZnz/CZW1EgXoEi51nhWQDI1dZY iGasf/ushODwUGE5NacO8FHObqo/a0NZ/4wpGLHLjeyhQmDlgbyVAcz/ywUrVwlHemBi bCYBrvKki0dkrQ51Kc7FNvufQkMh6biAoUMf8QYTq6hlBYp8XL9rdLNVgGHi16m5IlxC EtUw== X-Forwarded-Encrypted: i=1; AJvYcCVvXFcKAhyMcFaroZdNpObJS+HBFOi6p2fRsgDm7UJtU61zp9Dp3NtRVipmYezhOwOr5VoWpoAzzg==@kvack.org X-Gm-Message-State: AOJu0YwWl5l3+C/quPePEl6VBLTkjo+xm45Qrdfbv47aj2MNmXelQRRE OWQ0jiH0Ltn+UzPzaIFsPguuaVSau5feYpgVU/H4WgbNPwh24Sn7lA2bq/IrjeMvlWzkSTgXZsW v/y5emsQJo6POxoqsHWka5blEsXo= X-Google-Smtp-Source: AGHT+IHExeWlIeaJYluBXMfYDlgn6qQR1BihZybz7fjFDDXNeCLjGh2+lf0VyzNMDIzsYGkruM9G3D4Aph2AFd54Vho= X-Received: by 2002:a05:6214:5299:b0:6d4:f14:eb99 with SMTP id 6a1803df08f44-6d40f14ee06mr168124226d6.45.1731960059238; Mon, 18 Nov 2024 12:00:59 -0800 (PST) MIME-Version: 1.0 References: <20241107101005.69121-1-21cnbao@gmail.com> In-Reply-To: From: Nhat Pham Date: Mon, 18 Nov 2024 12:00:48 -0800 Message-ID: Subject: Re: [PATCH RFC v2 0/2] mTHP-friendly compression in zsmalloc and zram based on multi-pages To: Barry Song <21cnbao@gmail.com> Cc: usamaarif642@gmail.com, ying.huang@intel.com, linux-mm@kvack.org, akpm@linux-foundation.org, axboe@kernel.dk, bala.seshasayee@linux.intel.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, kanchana.p.sridhar@intel.com, kasong@tencent.com, linux-block@vger.kernel.org, minchan@kernel.org, senozhatsky@chromium.org, surenb@google.com, terrelln@fb.com, v-songbaohua@oppo.com, wajdi.k.feghali@intel.com, willy@infradead.org, yosryahmed@google.com, yuzhao@google.com, zhengtangquan@oppo.com, zhouchengming@bytedance.com, ryan.roberts@arm.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-HE-Meta: U2FsdGVkX1/PetwtK4gWlkvseOEtCfA31MUHNnBG2OUFF8kOKikDFN1GkT0wprFtmlcR8jSmF3aPSXXPjrjuSzCnvYYxL+dKnL3yewjskjYlWrNd/gMMxYTAsMJZ7tU6iGFG94OTW+C0nTfo8eqUQ+RnaGPnMxANnFFTo2OnCIJ57UzBI2eYZ6i8qYtZJqkG3ltXXFEySe/3dFmNJX4zXLe9tVjklw8rO/tXchKOP/Ly/tgDitLxP+7YtaPxh8Z83pUfP7RuaqYHWV4DSmUoXvr6WiQiKs5xqVqffGPgN+i39LbWXGDD2+e0YfQv4IFK2QVxDQu5HjzBobxAbEXJm+faw8md3/LycenWmXQc5Wi+lZMwq1pWAwxyUIqYj9pkKgPGXcgsIC0phLryhs3/QBwdTS6rMqtrnzv13bK7ZEKPWyHBctAbX/wNCX1mdbDLJbCxOu4qiHTPt0qAT7oYZtcxJph6PKuQ+z/VflhfnIr9dISwJRICnzPIMeRWZWhV8EOHibPGQpa7gwYXld8Nqm4Z8WQLoW20K3K/wrkwuGSUozNnzgvfi4l/Ct9ZYa1UvXMRlI5Ebt/YX6iI5q6jHlfJuNdG2DOHyRfFf2NTjus4D+xf5XVEAxGkH+y/T7SmlHKkidxjYsLQ/68BYL/xoqqNN25CoeHlBNU3MZueGwtoiGGfAbYuCXm1TPT0a5Q+3aLVMm7w4kdn4EfvQH3NdNRAr0BDt9gtvri8h/koUiP5SBO09TS0lsHTyVLl86yjIrMoQ00QOM0yT7ubJslT7kapFZ7yv5Muu/mjZ0oPVn+Urp6LZ9ced2swMOhpDfmyuT5NtCDEDmz4TPFXem1x/g8ow62Nno9qmTiCpxAP9qsNXKEuCXB3YrDkKNCKJyOlUIp4lAXEKzwE35nO83nj572P0SFdPMD2/x3P4I0XmSY9WUXEjUFrD0C7TdB6B9ASpcmnVgeH3x0kR9E7i2A pOsfHMFy P6JpyvLPvS+nvopvFaysdizPjoH3frNdgaSe9D4qjvDPW8DQLIcXLrMEF8yeBneoyNck3S0DYDapaUesXibt7JoaX4KeP6ynE7YjjW5EWuFj7+P9pkqRHyeJ38HvveCFShTGsvHGrk4TzVpxMDbysOn0bdoD4T2JojUjMbqTp3Te3lSnNg1nW7cn29tyUAxsFvSI/eKeOROoqMv4KLKfErnyK7iJt5yHtxKFSKBDqj33rvAC5/rHp72cSqueIQ1wsi8lH911guT94Ovb06IXUlmcc/dZT628fMk+vEKkOVnsmiik1Sff9/HRysyKOnPjlalL28bAohZ0UN8jPXeW/JHh8Bw== X-HE-Tag-Orig: 1731960038-344237 X-Rspam-User: X-Rspamd-Queue-Id: D32FAC0017 X-Rspamd-Server: rspam11 X-Stat-Signature: waoyob5amn66d6m716u9qkcz3fyu31ai X-HE-Tag: 1731960011-702585 X-HE-Meta: U2FsdGVkX18VSO9dlMJDvCYXsrgTpQxzzkpDzdA2gNiyt0SKsxVPqNgCShikwId9mWHsIWHbrWIve7vRzlHzeDLsN4R4FCzaNj4RRqoHNQlqPz0oik1whoBmeuDtr3nxkhLY0bEzwZt8nar2d3SZDIoGPNHBgsNPC4XjIE1MYli78iVwZfxE5HCiMQQziJJeJ6b33yyZDapyPKSxPdYhofG3El1ZgS20vzp+mTiIMwu0rYJimCAfOzAfTwDZBOC15PULBB16n5hz8OHrRZAd+VAzybSFlWePwT7bAF9Kf5iRNAmBiRtVD5txWBkGxo2wa68ztNLBjn8RsqxT+TGXK+Gzm8NJqsO0Lrf+U1LYZ0zbQSBTXyWLh9YcSDFVSqAJIYEHXe0FtOoCVuOsDUTCPuW62JYmJZCQaYI8nPOFD5PusN7zIhIuuOqXVw/Io/xiR22MSnzQu9tHDf4VhS4K2hgbD9itGMPKOSLIehq2ogz3wyZwH7fW+jkjmaZSL9v58GXbRzMI0q719XnQ+yB4uOMSI1efvoP3ij9kI2m8/rQuLbxKytCYD65eGVDN5O6sNxYVrUm4iCipPhkbmUMIDX2PsKsKlUrq0l+YF2w3olRUj7oqKV/C1gSvP0WPgO+QNRI1s0MfD++sAA/V8qibILGl5mAdq4ZfnZHoOO0mE/+l7dGjCerv4jpBhmTYSazKi0ud6gFKgI44XBvdW7+BolLQfw/aMUGtEqssfO4lkOQmaikgAl4ZhQ+WrJwWqLVD6PlOYB7qjKwfDCMyt3ZQoR4vS10PrWTDjWvxC58J6+4432ZmF6JVwy9cp+iX3YsU7RG38+R4EXD2iF6mvDXJxpd8iEeZNgOjsDhn7P87lA3Lj2TSjP1hFeY7GUTaO/5+Eq56pr50ppfq1AXCA+MrX4mLuwA+8COhaEcr+hgszMIiHrRakTKLIr3n3j5jl9rOW3vSQaf4LhuUElxg2pz 64sXzVv0 iuTlCrao8Sc8rwzqgZehvd+99x34xHlW4jpsMmypoj4QUX3Nz1Sbp2YCf0e1yj7f02pv6gTh8ZC+K0vmApAD/AY4B41cSHr7jGaWkQ9pNOTPbJXtWcspyFzkRGoMV8t06kGLy0RydQnA3WF9vL/LrvK5M4VUOJ3NFfWm7QUaOJgZSzdQVT1133ro/yS0R8n6nNtxfManeHa3tlxU/uqfBpmK9jEFig1iGUz1F X-Bogosity: Ham, tests=bogofilter, spamicity=0.000037, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 18, 2024 at 2:27=E2=80=AFAM Barry Song <21cnbao@gmail.com> wrot= e: > Thanks for the data, Barry and Tangquan! > On Tue, Nov 12, 2024 at 10:37=E2=80=AFAM Barry Song <21cnbao@gmail.com> w= rote: > > Thus, "swap-in(ms) 68660," where mTHP allocation always fails, is signifi= cantly > slower than "swap-in(ms) 21763," where mTHP allocation succeeds. As well as the first scenario (the status quo) :( I guess it depends on how often we are seeing this degenerate case (i.e how often do we see (m)THP allocation failure?) > > If there are no objections, I could send a v3 patch to fall back to 4 > small folios > instead of one. However, this would significantly increase the complexity= of > do_swap_page(). My gut feeling is that the added complexity might not be > well-received :-) Yeah I'm curious too. I'll wait for your numbers - the dynamics are completely unpredictable to me. OTOH, we'll be less wasteful in terms of CPU work (no longer have to decompress the same chunk multiple times). OTOH, we're creating more memory pressure (having to load the whole chunk in), without the THP benefits. I think this is an OK workaround for now. Increasing (m)THP allocation success rate would be the true fix, but that is a hard problem :) > > Thanks > Barry