From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BC25C3DA4A for ; Sat, 3 Aug 2024 21:36:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 573D36B0082; Sat, 3 Aug 2024 17:36:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 524F26B0085; Sat, 3 Aug 2024 17:36:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4126E6B0088; Sat, 3 Aug 2024 17:36:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2A1706B0082 for ; Sat, 3 Aug 2024 17:36:09 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A831AC174C for ; Sat, 3 Aug 2024 21:36:08 +0000 (UTC) X-FDA: 82412242416.22.0EA87F6 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by imf17.hostedemail.com (Postfix) with ESMTP id ED82B40013 for ; Sat, 3 Aug 2024 21:36:06 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lCAaGlVK; spf=pass (imf17.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.54 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722720960; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GGA4x0cRfdtZr8rM4e8YaQaSSi/rroQkTyA63QWZunA=; b=HdSgYmCQ4tCoRTXZy/llXcVL596lPFV+h9YuZ/4Tnk0e43Eo8SdwSZDhpz2T4G0io1AZDW fAIIwXGQRMNfaDyck92RQpG1ft+ZlDA6OOi9r4EJijMgm+BKWubGMhUlqEMJbKk5iwga6J SUOfQKSmG1wcoF0pxzJuLHzqCXSz124= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lCAaGlVK; spf=pass (imf17.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.54 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722720960; a=rsa-sha256; cv=none; b=m62TYAYhEqjIAc+BWnbFA42wM7AapyjvdshdKV/uhiHw0mIajbvXC1Uiu4CiXmgMkMJbbE /LdSdE5JfvsCtAhW6fq0UPHE2w//S85ztJZ8+GSkGtHgZuTE7biiOpEbjAVN4eyrqg+Qj2 00b7QWqzXMxfKcLYxrX0d8AiXHzVIKs= Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-6b797fb1c4aso66834326d6.2 for ; Sat, 03 Aug 2024 14:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722720966; x=1723325766; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GGA4x0cRfdtZr8rM4e8YaQaSSi/rroQkTyA63QWZunA=; b=lCAaGlVKExdhqYxsyOvLBtBjVZP9Jf5GqWCj/WMrdlgn2AOT3ZR1L83rew+JcwPA5r wIk5edRud6c5KqCRsYpd3MxHXDgJq9/d8oFh/fdn0xLSBrKVjcVp4Ji8+dk3M1s0Ke2R dHW7ct5rmpaPpxuVf7Gn5Rgfspsq/99xnvjD4QwjWkThckjmPR/lLKVkP7POISspBtP0 tg3RSn9vqt0GNyxjXAztCc/6yUBAQkg6jCin6feM88FhoTWjoJI30JehB/6g+VFDOx1T cen6MaDpB+pmyzxTZdQM3apVfDk3dY6IjLxdwhRma8VQ5IkH5FXokSssWpryD2hxujy2 JElA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722720966; x=1723325766; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GGA4x0cRfdtZr8rM4e8YaQaSSi/rroQkTyA63QWZunA=; b=h+CvtUJDfFCCFaQOSpmjOg69tMNAcriOzlPamJGrv7Vfa5YGb9ei9TdaY0yCa06PN1 2tQ12BcZvIWSlxhPJgbewsig+WnqEYQfkuYccJnDL4gNiYdii1yth9rJBn0sLK4D3dMn Ty1ULVMzHFK+FWMn0HZYtvuSfMjhx7OXr3RinmzvjFpLX1TOgt51knRvfvaHkxCynL01 BxPz30sSQEHUD+nREa33G/q3W0SJKMp+Dm8RL/pD8/7NSaQ54IbSiX/hykaFcHK/0Jhv XjrxJnGLN7c60oQFAeJKdMcrgI1gmAyiWBcS8eIAdzRhgwK+RwFUiu61kAgffBhXi0ad DLYA== X-Forwarded-Encrypted: i=1; AJvYcCWjbatc85CkHgUHY3VI0r9Mj7S6XjnsJFFQddHFZBN5aOMIsLkrZDakb6/+wirSQBNnclYYV8qgUEDvtNA6WYZE+64= X-Gm-Message-State: AOJu0Yw5Z5K2curjSLNeDXGwJ4lyRYXlOYVkgdgTgYgOpaKmDol1Vt4s xVEqeCuzRHL1ixvQ/bKj823gOce2n7GlH7Asavh/HZPB4cwRjrijSp419HBPTlG0NElV2L3GxtQ Jyh7Z+QklDpqeqJvS3N/e3We1GeE= X-Google-Smtp-Source: AGHT+IGszZGZLYotIbtw6Fioo5KC/jrwn+A1TjHwocUeTx2+7j0c+FPLoJQjNwwuAAGJRz2PEorN5HY09hHG4R00qhE= X-Received: by 2002:a05:6214:4906:b0:6b7:a2c2:610c with SMTP id 6a1803df08f44-6bb9836ece4mr99660916d6.17.1722720965938; Sat, 03 Aug 2024 14:36:05 -0700 (PDT) MIME-Version: 1.0 References: <20240803053306.2685541-1-yosryahmed@google.com> In-Reply-To: <20240803053306.2685541-1-yosryahmed@google.com> From: Nhat Pham Date: Sat, 3 Aug 2024 14:35:55 -0700 Message-ID: Subject: Re: [PATCH] mm: zswap: make the lock critical section obvious in shrink_worker() To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Chengming Zhou , Takero Funaki , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: ufrn7yz6ajdu5yzq8wu49fg3ducw3qqq X-Rspamd-Queue-Id: ED82B40013 X-Rspamd-Server: rspam11 X-HE-Tag: 1722720966-414283 X-HE-Meta: U2FsdGVkX18LJBWThjUeM9AeYmNhDBGKDPdGh+VrRgY32MMmE7cIvl189qnQCmPLOWCLyGYC3OuKLhhDpTr5Ov0QMftYkm2Mt9NQpIJ2/7cIA/ggVc3UGsNouZvhNt4xfXpbMRS21J6AYr891DiH1Ds1rTTYBHzvxcfHb/fRoCZQk6SaIqRyrpOfk/MHC1qrKJT+hquF/WkpyRliLWChBrFqErTsyQZOgPb3Hhg9xWTYGsZt1rLfJiViqb6PqFz++W7vOSBXDaJx0N+m2onv4F6vX+iS+NWDZ877nyiXbCQK+HkfTGzqaewZxwgQK9ZwDTOk40KwTblIiGgCk5kd2Mr8u4BIAgDXKaHnvK+z/qrEKdu22aTBaOgTdsRBY+6Uv7kSRg7X2Tz29ggjblItdqIfAWkQasLxJml8TZp1TbegbCPQL/MICZcat7/9GnqQWkzQlSeqon6DJ909UOKY0B1Wq4JqRS2aUsbYPj43HGa+icoBfoNWtEpHWCFisBMuGgd/ibXAttLj+myD5RqWtP6YkVc1YGWmdJtEX14Ls9aNVWBEAn/rvYWv3IusvhoqJgKCBunUIa3D5SQDULVcPSamC6K3x+ECWadX95SIThT07qPrwflWYwOyWl0ZmsVh2NMutj+EBCrjVjZJrrq946rfa9rptTMyKEJwzny4ZKnGGl/nUp56tYLgJ8uVO8D2SuSk/EDQ5T9jBQ1i8JdDn9wq7Nhr9evRBjB5fhqgh4xjjxo2hpNB7jCcQFee9pRx/HNkUsk65KalcMoZR57HlY7UBNpdiCnGm0nMQdX3I5ndd1G1tE4I070jeom6IgxjPGXmm2V8YUiSZom/9UOMVH4W2kdHHFLvrcpVvLYSqVyitHyfjDvzEysc+vieeKJbdU5Z4NPmVMh8O4GyvDET5JSsU4RKMg6DdJ4FnfFwW1g2An2rNCe+HE/NzM7BCLS+BLcr8mZRezI7pC9DxjX yS9of9hx Dn2+6VGU33TlI/qIVeN/kv8Yr+D7zHd9H6MAZNBlr9VoQ+5ftydhPnCcyozDX314Mp966239cAadZnAOiIHWdTrqy2WMDqFMaoCZtu6LVRjkoAyZp0Be7Ei3H/mllPvRlihJPdMOloTZMJbZ5wBeqxZEU7up+mRSnIndLYegS3CS4ape5UGDpoIKFddJ6mi3atNSXHDiZL5yqKjVk5drrWaw1VDRceI377iW5+UcTyzu/7Lhgc/5ss3oIvlaFzsPqOcMhA1Hc4rNZx5BOl3n2w/G3XUi48pmbHrIa177GYQLcfSu8rVB4WGHqeCIltn9eg/g09S5GYoOzy7YW4aWrF9SvD6hGHddPPvWEee9m1gEdoBj6XHLyBD0M83wAyscdufVa X-Bogosity: Ham, tests=bogofilter, spamicity=0.195036, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 2, 2024 at 10:33=E2=80=AFPM Yosry Ahmed = wrote: > > Move the comments and spin_{lock/unlock}() calls around in > shrink_worker() to make it obvious the lock is protecting the loop > updating zswap_next_shrink. > > Signed-off-by: Yosry Ahmed Thanks, it looks cleaner to me too. Reviewed-by: Nhat Pham