From: Nhat Pham <nphamcs@gmail.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Chengming Zhou <chengming.zhou@linux.dev>,
Takero Funaki <flintglass@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: zswap: make the lock critical section obvious in shrink_worker()
Date: Sat, 3 Aug 2024 14:35:55 -0700 [thread overview]
Message-ID: <CAKEwX=N1GZEGnuXo_iW1N9Sx+Jon8=rqe7vznKwL4RQ7t349fA@mail.gmail.com> (raw)
In-Reply-To: <20240803053306.2685541-1-yosryahmed@google.com>
On Fri, Aug 2, 2024 at 10:33 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> Move the comments and spin_{lock/unlock}() calls around in
> shrink_worker() to make it obvious the lock is protecting the loop
> updating zswap_next_shrink.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Thanks, it looks cleaner to me too.
Reviewed-by: Nhat Pham <nphamcs@gmail.com>
next prev parent reply other threads:[~2024-08-03 21:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-03 5:33 Yosry Ahmed
2024-08-03 21:35 ` Nhat Pham [this message]
2024-08-05 2:06 ` Chengming Zhou
2024-08-05 17:06 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKEwX=N1GZEGnuXo_iW1N9Sx+Jon8=rqe7vznKwL4RQ7t349fA@mail.gmail.com' \
--to=nphamcs@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=flintglass@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox