From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FC5C46CD2 for ; Tue, 30 Jan 2024 16:33:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F35AE6B009C; Tue, 30 Jan 2024 11:33:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE54F6B009D; Tue, 30 Jan 2024 11:33:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DAE1E6B009E; Tue, 30 Jan 2024 11:33:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CCF406B009C for ; Tue, 30 Jan 2024 11:33:32 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7BA9040B41 for ; Tue, 30 Jan 2024 16:33:32 +0000 (UTC) X-FDA: 81736523064.18.BEC58F9 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by imf26.hostedemail.com (Postfix) with ESMTP id 8AA6814001E for ; Tue, 30 Jan 2024 16:33:30 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="FdJXOBL/"; spf=pass (imf26.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706632410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5df6v4Y1CvGshA4Xd8afgPQAEeOHdkVXvY3a18V0GUw=; b=R+Xjd/Un+doLL91TiYLzEKr5p0Zbi3D6DfyV/IEP5/kK9q6fJrllgEwhaBhkaCUnF9SYZC +sVESUxJXt7rg4+HZSlTIYf2mWHOs8TNwepxPGvkuFvF48vIqL6TkxUWHZx7L9d8pJuAEj IiItlpqWejnLxLnKXT1OCfilE2/4lNI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706632410; a=rsa-sha256; cv=none; b=PDaIIIglzfbsJ9ETP1LrBy44KFQsFoVvX5eP+PBUiwHmtktd+TL4xPhyg+V+k5V4lNz4hL mcLzn06lrgXavks+vC0xzvz34wA058xUCl2qfMbCEHtsf9SuB3UogW1MbXxwX6EA971RL1 Her5UlDxY9Y0nEHGOBhRsFCTdcVpjnc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="FdJXOBL/"; spf=pass (imf26.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.169 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-363890fe589so4760245ab.0 for ; Tue, 30 Jan 2024 08:33:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706632409; x=1707237209; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5df6v4Y1CvGshA4Xd8afgPQAEeOHdkVXvY3a18V0GUw=; b=FdJXOBL/Br9qMTaCyhqgk2pDcgLHnvklAUBhHEfGXaOVav3kaLxiDtMSpbMQwJCijE /LOiisd6FIbu6CUISmlmhhWkOUmcPBrj/w04m6qu6lelydsWm70bgBrk1pmxzla5Ab/D /IVMFnnk/EOZSJ/tSkGzRIliVw2g0xebm2hzdMcVHH9WTYRhuBDdmA9RgHDTq7glXjY3 rQid7bIohbIThasHj1t7FavJnHXuD+aoPGgCJku6WvU3JYvyqgm0fVwiq6qc6pgkq+hV 5gtluvZfvcCcN8HXRfAbmnCvX8U1yTljgooVan9lMZjMqmM4pB+jzU2yqXZDNS/etL9L sKJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706632409; x=1707237209; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5df6v4Y1CvGshA4Xd8afgPQAEeOHdkVXvY3a18V0GUw=; b=uEhU7DViYNJCxAn3R71A5/XI0KSXEx1uFikdrCsF05FtdxIhSbTkLDqyUXsFW2K/fB BbmOHyscnZOvELPVxv3sMRAeGP6KFHrSA32nNXNoFB/OsYQ2qxmp/qt2JuMS7qVLrGbY XiDUhP3yQgGlCiSTVFPog/p10u28LuYdwgiAY4mg65QM7+3WRYFQNW4PD1kp2e2qHlZa vf2cbkPw1/wUxL2tk5hWUG/Ku0FjJqMthD/UIJKjsuMgmLB39/ZsfZ1fsnGJl4+0NIG+ +lBMYGX5R++K9p05Fy4DA32mg7MyIRqSIlfn1LDaMq+OqoQxurysrg4IVlqJTdZhq2lF Sr2A== X-Gm-Message-State: AOJu0Ywnx7MPM1MwKquAJKg0AOPcte5GzXBEjAaOvFgj3fYbn6OHkdhK PB39ZLrOwS41xg5A4SThiWW46+3ROIY9/9O2Osd/46TQj5d8ihMGJ4kpQUMoBjvBuB/Us70iqKh LJTUmnGiGYtTlUJUfy3xdee7lxOio9lZkGqQ= X-Google-Smtp-Source: AGHT+IFYBCqr3IbpgXE0K/7lY9bLI60Nr5zvvxtevwznlcLY7z4FEn/C5oupH38AA9X1XbwYzu+MF24uE+zZ1+RzGBQ= X-Received: by 2002:a92:c0c3:0:b0:363:75fc:6c4f with SMTP id t3-20020a92c0c3000000b0036375fc6c4fmr7620916ilf.3.1706632409693; Tue, 30 Jan 2024 08:33:29 -0800 (PST) MIME-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-7-hannes@cmpxchg.org> In-Reply-To: <20240130014208.565554-7-hannes@cmpxchg.org> From: Nhat Pham Date: Tue, 30 Jan 2024 08:33:18 -0800 Message-ID: Subject: Re: [PATCH 06/20] mm: zswap: rename __zswap_load() to zswap_decompress() To: Johannes Weiner Cc: Andrew Morton , Yosry Ahmed , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: j8k8fbc9qw7fhqsiqkexq5pfe71ut9wr X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8AA6814001E X-Rspam-User: X-HE-Tag: 1706632410-686499 X-HE-Meta: U2FsdGVkX1/bnuhcF/F7UQwdD1h70xCO9SNfwtYiNeg2fp3oNYyU1Z10k7QJsDNhifUj7HWAnD9LmYE9es4zxJDzx8i7yngDbZdZ3wxXeH8HvUUydgNuf9IDldMtNXeWH2Gc0zNFJkJ0DFADQ2hwThJeUAfkQG2NTRQVJ2IafjVxzJFCb9PE+ZQXC/OHWY0eqWP+6StGyeo+1TInaeIy/gaPUjJqM8bqTGT+9CrhkAONGAct2IKMsx8Gkb5Cb3PITa5mM+Bj6rn1m6FvvniKHDhJE5qWwNtURLtMbvzzdDBzedKbCty22Pa/ImdpDWakX7+ovnPIIfK0uFVCX/+JZKD+MD+D91ySqbuEL2ePT/DOPhxw4LJJZFKoiBac4s9gaFCZ/TcWefLFi4ELkvF0+0JDvhIfeicbdrRnbk5t5bcUTQCPLHmJ6PnGqT58YC4abxp56BcaJv3J4PMdXnH8jKHQEx6Z31Cn+lNcmVcODLzjP854JkqFFmBvXt10j3/Gga9TyakpHWEW4Y7zfcRhFtgA18BFRwDYpybuEtTxYUBNVqNhS9XW1UDpcm4MQnjnOWVVhElXv7J2oMkD/S0Ybvo/pURyUvGqRrzCZk7ZVu5AsRQBGOdNWVdM9FHHWa2tXo26NQJXlQLe5C7tgNOWPTcxe7wKAZT+DNba1tMYiGEaw5tv3kCE8GUHBAmAv4TxfO8H5t0sUwaAHpcOw1s8tXoy+LoXfKssd7OM/yqn7OCZHf6LMO2la6l4WGqJXRtbaKqfiL9R+KovFkyrdZn8AJxMYoBMEpmBr2/wCaALf6Hfn3Ka7BtrIwscPRiZaTedjgkBUg7sRDsERo5Ud/sIFSrxkSb17rhWeiSU19JrY5Nf9fPzb0lZmbyPsn5YUopYK49E2B1PkPDCC/K2cza4HDqo60XHFmYXkTFPbfINthDQHU83UyJVjyZ9MzwH/qrBdzT+fXBvI7qIr6RQ0Dn EHu5TwSK 4zwgwld18h3GYFKn2VL54XeQeqSeGAW0E6v0prbeuklCJmPTXW+FC3MC+BKaNrc4EjHw/j4oybMvyJ+OxKYb6Ptd5ADC07ZusPzsqklxG66bk8x66Z++hqbNjBnVTNP50mMBDsIwcEFIm7GUuB/W5BVhdlilT4Xa+G1ZVJU3yRsVvWWQHS0FjLTRHOLXbc3YKOQHIY4KpB7s2+TDcbc3cm7FksNZtOpp1vAAjYYQ/4tvoi4qtnXUb1EeDgROPs9V2avKW+rNWLiHtv9uQittcsdUfMc0BI5RBodPXLSePmpqN2f5B0q1uCfxJ2FtMvT99UXmO2KXHsE2uiDXdfx49HOeguHkGPq0HYmTtheWr7zrFiU+RBziARomWgvwMnbsxYds3pyPtrrldiqIXkMqUElA7xmcDOgzif+RU15jjqUiaEIpwZB8NsSqqKvSPnHHkyVRlH77Yv+rMrg/dt5gRKMKPKyNAXPvKDcGE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000750, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 5:42=E2=80=AFPM Johannes Weiner wrote: > > Signed-off-by: Johannes Weiner > --- > mm/zswap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 7a7e8da2b4f8..bdc9f82fe4b9 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -1316,7 +1316,7 @@ static int zswap_enabled_param_set(const char *val, > return ret; > } > > -static void __zswap_load(struct zswap_entry *entry, struct page *page) > +static void zswap_decompress(struct zswap_entry *entry, struct page *pag= e) This is a much better name. Was gonna point this out in the original series - it's clearly just decompression :) Reviewed-by: Nhat Pham > { > struct zpool *zpool =3D zswap_find_zpool(entry); > struct scatterlist input, output; > @@ -1411,7 +1411,7 @@ static int zswap_writeback_entry(struct zswap_entry= *entry, > zswap_entry_get(entry); > spin_unlock(&tree->lock); > > - __zswap_load(entry, &folio->page); > + zswap_decompress(entry, &folio->page); > > count_vm_event(ZSWPWB); > if (entry->objcg) > @@ -1702,7 +1702,7 @@ bool zswap_load(struct folio *folio) > spin_unlock(&tree->lock); > > if (entry->length) > - __zswap_load(entry, page); > + zswap_decompress(entry, page); > else { > dst =3D kmap_local_page(page); > zswap_fill_page(dst, entry->value); > -- > 2.43.0 >