From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2366FC4167B for ; Mon, 11 Dec 2023 14:16:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6552D6B00ED; Mon, 11 Dec 2023 09:16:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DE426B00EE; Mon, 11 Dec 2023 09:16:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 457D46B00EF; Mon, 11 Dec 2023 09:16:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2DE016B00ED for ; Mon, 11 Dec 2023 09:16:04 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id F1B6814070F for ; Mon, 11 Dec 2023 14:16:03 +0000 (UTC) X-FDA: 81554736606.09.F95565C Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by imf04.hostedemail.com (Postfix) with ESMTP id 2C1F040004 for ; Mon, 11 Dec 2023 14:16:01 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DE1orNkb; spf=pass (imf04.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.178 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702304162; a=rsa-sha256; cv=none; b=uPhPsn1ZUKfnTNRF6QkM9jEMRuUgy96h5rx4Kjr9sZ1hIVEw7HLNOfhQh/7u3ZNLwwf7kc Ipy2aoXHe1EEq60Uqt5280QRXVe9M853lVHl/4vrJnVzViEUVM1Uw3uGvX3f+fbYBq8XoO d5gIRxWpWa19b0zjhb/OdKDqMGaI3Sk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DE1orNkb; spf=pass (imf04.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.178 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702304162; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8t6Kg8pIpLZHaK6XOkgWPBGzWw2hTG8f77u5RaPHsCM=; b=3vS1NrJSr9mCd+y2BayixzlBaMewNqi/z0EV7KbOLNEBkaAYhfOpFp0RNLxFstePgHqMBh Ubht0aot1q0rRz4acXffej3yfN/egnJA1oJ61BqobdaucW3IiemkAoPAEqZvlCGWKOqiv2 FT6ssn5E6Df8pXdpZUyydhl+9jnRgkI= Received: by mail-il1-f178.google.com with SMTP id e9e14a558f8ab-35f49b80192so2887865ab.1 for ; Mon, 11 Dec 2023 06:16:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702304161; x=1702908961; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8t6Kg8pIpLZHaK6XOkgWPBGzWw2hTG8f77u5RaPHsCM=; b=DE1orNkbD3zo4tgIbxqIwKHv1rH6YswNhbZQbZtBcfDRli1Dg4P9cnwxmCnwm8Y7KM s54knMq7Pp14N+Bv0bPapoLplPOeYQXnNkEDNQXWPdZsKjbG9ZEa5Eq0uA+xCqjCDwET /p9g0P5HEAMKMcgNeLtkEY8rjNYp+U+CfY1yxLGvGxOsiQTdYJQCWSSF8Vps6oeYDo6X xepvjh6SLJxpdplgGbwh7jA//+6MQ+eI5D0hKFVKyPgU1CB2AxjHZZ2dCwz3RmLlEl1o iOt60Pinxs2v4SLujvvIWGQUNz40Jppfv2tZOOhEyTwl2OaFNxgkfoDdCaJRCXsjOABy rXpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702304161; x=1702908961; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8t6Kg8pIpLZHaK6XOkgWPBGzWw2hTG8f77u5RaPHsCM=; b=YMxAtlcImtw3n5lnm1CQrLqqfjN/cjO4ytprFioLgdXGMgktev5/dtXnRTAAKiaQFf Z3O7QfqRbHT4l7dPPXksOuFSZIFOh0jYk6N1EyjKWddHgI1+nViaRfp05O9oIBW7oOIF 39iDamPOK5KorXL1xpI+Oydr5M20YW4G1hZsvs5PkQFb/q0jATdaLZUXYi+lyus+no3a nu8vpJ23zYWT/hMU11Ll8LrQwCCFAe0dvneb9/qfWOlRzjr23kVS9w4Q4eUiEDMsVlvv 9/3KxxiTSbbSm7qvV9urrDOpI+rWI19+muGJga77XUY5dUURX61Kewk7yza/S9Dx56LL AyBg== X-Gm-Message-State: AOJu0Yxsc1GQk3v/JdQ6/YPqqx/1DjxzwTJy0EN+cDIlrZq9gOCLGhP3 Mshl2z5NiC3e4MRMP1ZW5thrN90wb9fRtIaHSTs= X-Google-Smtp-Source: AGHT+IGAViM39vfI6E45frCKq5/PpojjvyeQJir0lgGGVehAxWi7iTYdNZFN/dv4wSv/vv8VPOH315eHAokw1/UFMdw= X-Received: by 2002:a05:6e02:148a:b0:35d:3d59:b3f7 with SMTP id n10-20020a056e02148a00b0035d3d59b3f7mr4443201ilk.8.1702304161113; Mon, 11 Dec 2023 06:16:01 -0800 (PST) MIME-Version: 1.0 References: <20231211052850.3513230-1-debug.penguin32@gmail.com> In-Reply-To: <20231211052850.3513230-1-debug.penguin32@gmail.com> From: Nhat Pham Date: Mon, 11 Dec 2023 09:15:50 -0500 Message-ID: Subject: Re: [PATCH] mm/zswap: Improve with alloc_workqueue() call To: Ronald Monthero Cc: sjenning@redhat.com, akpm@linux-foundation.org, Dan Streetman , Vitaly Wool , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 2C1F040004 X-Stat-Signature: wsnt8knkegqfzapznspubp83fbxnx5hs X-Rspam-User: X-HE-Tag: 1702304161-730049 X-HE-Meta: U2FsdGVkX1+RAYm4CF6tWdnlB+1cNSEC1AEIPhxCS3xqw3Vb+KnqQUQdpynMtBIju08BrNYPM4pj86fo2v1aUzC7I8wvBHeydL3770G+lwIGgbx+BHVN021RQeWGuGMJ2PbwKovKgy/gYBioa4oDmDArczjvrZQQ65ghmQ02Cxr7k/Ev2CI22qmonm+l0se4p98H9KGAwGfvVNYDVY3COaB9GH0QpMv9kvebeU/XixRNrjeYXixyZ999pUmyi7fG98Y9VXl0H0d5D6WGSausjP/4CbABI73VPuyxVrGahCyUdyasuCdGPPC0qYBZssj9qiShZLBqhg0OpHiLw/24Fsql6hFXdkUCkpvMp3+x4d+hZJ4OUokw1KatDI+qHtBTzWDMBcuBtsIEjfWns2VhQFBHMSA1o+1zOK4OBp0dlcZZFFLp47O6bDADjKn2gy9BfMjZ31fgU77S1jAh8Us/wFmnPyqrLxPuFkKLBB1nI+lB2Uir9Aym9oOvLB2DF0ieFf5IvFUuNS7oZHnDQhbMwrMkawrjOARVIY8zyE8yGBBDl2Ihn6jF9V/Pyl+xS51DOjqA36yZuWjLGPxD+ElkybxNSr+xDall+rjbzQ554Exo2BuhrMmTJpZWebZdvkT9L8VmR1K/t+NVMH9xovRJYR+eQQw+SsqUl7x2Tvb8FYzgPhgavw8rEKp/WXeGsNbKLFqKWc975qVd5sugMN8J/sWQa0UVdEiyYTgc6GS9fbcOWuabm/lcQL+WNN5KNqlvoQev0zGHBGlsHszEEV0YmVrTwAMhGbNo8PXjXi+F1RMsTFhqiRjV8B//lryenfoSsjcgRFHRArWMnMA2cug/Qf3LhiHSMcRdnFKKbbsn7vHPeDZMLGQfgCujM5WUmPsy/5Y2o+r5GKfi9LZVXEydwFUK3h9oVn9R+/zUfZEm1s4dLJH2Rah7bUd9UXy4AVX1a0z76E5HYdlHpVhh6zS zYy/Idp/ ePjeBuCKAaRLIHde+zLTjzEbwiQcVtdM+Rb1PCoMLjqq3Dh9RLM7gnqXr89nzEx3D4D5xNOjxvWEZerSzKi3A/lAz3eDqdHlisaBytwYo/vQ8FdvpJAT7nYtibx5oxYW1ajHiWI/lkR/Uj7/3vGWL3hld579dEoN9itoHAKjzZthKQMETkxRODIGr+LxFOHNTAweQmB4g4RI2Hz8JXSygXZz0iC32fM3CvaXVmGTH5kA3w2GJ2JGK7Oq4ZhHN1kiaSZ6/dSyMO8jdGx6zCj+BdFPMrc7pc4lU/0cZS8r1NGKzm9gW1Q4lkgSCi7CXb6F7LMIJXyRaA3om6C7nCmhIdY9LaV4FZ7x3V1yU3N3EZK/tyQl0HRomCtBPLjadovumx53ygMf7dccsQ7iYDMTKbAuOAZGeDclvYE6FfCEVb4/hREQg9RT6jLHnbriefy+13hSq6GTn8P60HRG4vnoODSpHJ6ZGlzrjOmwU5ZFVAAN9R0w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.109066, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Dec 10, 2023 at 9:31=E2=80=AFPM Ronald Monthero wrote: > > Use alloc_workqueue() to create and set finer > work item attributes instead of create_workqueue() > which is to be deprecated. > > Signed-off-by: Ronald Monthero > --- > mm/zswap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 74411dfdad92..64dbe3e944a2 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -1620,7 +1620,8 @@ static int zswap_setup(void) > zswap_enabled =3D false; > } > > - shrink_wq =3D create_workqueue("zswap-shrink"); > + shrink_wq =3D alloc_workqueue("zswap-shrink", > + WQ_UNBOUND|WQ_MEM_RECLAIM, 0); Hmmm this changes the current behavior a bit right? create_workqueue() is currently defined as: alloc_workqueue("%s", __WQ_LEGACY | WQ_MEM_RECLAIM, 1, (name)) I think this should be noted in the changelog, at the very least, even if it is fine. We should be as explicit as possible about behavior changes. > if (!shrink_wq) > goto fallback_fail; > > -- > 2.34.1 > >