From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E62C47DB3 for ; Tue, 30 Jan 2024 00:13:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 883016B007E; Mon, 29 Jan 2024 19:13:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 80C606B0080; Mon, 29 Jan 2024 19:13:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AC586B0081; Mon, 29 Jan 2024 19:13:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 547366B007E for ; Mon, 29 Jan 2024 19:13:08 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 26D581A0B88 for ; Tue, 30 Jan 2024 00:13:08 +0000 (UTC) X-FDA: 81734052456.03.9E8808E Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by imf01.hostedemail.com (Postfix) with ESMTP id 628BD40007 for ; Tue, 30 Jan 2024 00:13:06 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RxRZsnPz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.171 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706573586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OXTzc+kkuw+ShG+eg9t0/SuZakj6DjerRaMHogUdVuM=; b=VuHpeMgXF2wYuGzE8EIxoMnLrZzEcQ2lI3t3qUtaurA0I1Tl0uJF0h8TEyj+hg3EjHAdBf IbPYOAHqDn7nW6Kva6DBfwCL0jS/D1KQbERZB9tKdoR0B0/H4EPX4clMMzmLKwGP0PbdEQ NNuYa7rQzAtKJxvUu4tSwQjbVsRUufQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RxRZsnPz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.171 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706573586; a=rsa-sha256; cv=none; b=rIiGarcOQH2EDpY1+i/K/cgynTrZ9POB5DGd9f+w7uzhP/MRr+Xegd5FByIhP6HnCTj5k+ syQS7wibaNbqBw9OtL6WWbMDJMhXB54CSVdEt8J9N2fNrjXvAAFNCyGNHqNvlsezpoGQwM 1/huhgmNEzOzZCLkFZQsSJi51PMVokI= Received: by mail-il1-f171.google.com with SMTP id e9e14a558f8ab-3637d43496fso4002585ab.2 for ; Mon, 29 Jan 2024 16:13:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706573585; x=1707178385; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=OXTzc+kkuw+ShG+eg9t0/SuZakj6DjerRaMHogUdVuM=; b=RxRZsnPzG/Bf2Dw9PV5Lpl2BxFDjX+YriVL/kfNOEFl7MSKRGVFseUz1zzb111KQx6 dJLyQW5SgmAFky/KmlABFTGs9Xz6RWFwzgMujX6ZJ8Mtly8TWwodcoMHaV6L0ggUScAs kYQg7ZgO7lbrH9kP3sJ9HzG7VuBd2iCMN2KbsyAcSHKhlOSyHA2cKPV1H3FGOcX2Y/+D RpKfHNEhB+3g+m2V2jsMQOSDln3IrwWBBNnJr1ralltUa/RMvPrLAUjjKeT/X3wyou6s dDHqApkl0SlvqrFKkG8Yt5BN5dUrhpEL2GpBE9oUsoqo8MSoxme1mwSrxa5dgsjZSqSp K3JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706573585; x=1707178385; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OXTzc+kkuw+ShG+eg9t0/SuZakj6DjerRaMHogUdVuM=; b=aNxt/BVo+UZamHamfgh+/rIRQcKxfx3TbY4tNovJcDDX+kSmaHAODuTIJPBADv3OXP +tRYdnAzhlEMeBOp+xLiMn3l4vHzKjFMeScVrxnQJAXWjIuTw5zH0+fxOGHhzLMsFg+T 1YNErDCoL6P+gCyuk/URb/sJH6hEusi+CmBScwAKFG2vgW3Ls5B0h7ddhG7ynyaUjzBp lfVLgENnSq4+wMqc7GrmQLHn/wFEoLCUpPOp3Vlynwk38iPn4syWrEQadF6f5Wvs11zX byIlad9yyu6YYsJN2gd91SgOlrH0QIQFljoNh7x882FliWWVJeWlmtY/ykVI+luIPiKh 8reQ== X-Gm-Message-State: AOJu0Yz6nqW7qkn8M8KZe32KlKR1s4GH3VamlqRRqbCIQej2AvZGWLmJ 3snVPEKaqdak4nO5eSGE1CDN9E49r6L7X3S6YW8WQkCrMNzb5zwFo5wsqoXisBvtlcyICSofzNd krOGmKWE6LgQAZkmR/9zOCuzQ4dc= X-Google-Smtp-Source: AGHT+IHZG5sIOtcpxW7IIs3sEwNN+GPZLM6q0s30XelhuyQ5UDhu6LphYwezreNI8SOxPwOUbGv8yBq2Tu6BRoVh30g= X-Received: by 2002:a92:7312:0:b0:363:7f6e:e868 with SMTP id o18-20020a927312000000b003637f6ee868mr3261356ilc.19.1706573585364; Mon, 29 Jan 2024 16:13:05 -0800 (PST) MIME-Version: 1.0 References: <20240126-zswap-writeback-race-v2-0-b10479847099@bytedance.com> <20240126-zswap-writeback-race-v2-1-b10479847099@bytedance.com> In-Reply-To: From: Nhat Pham Date: Mon, 29 Jan 2024 16:12:54 -0800 Message-ID: Subject: Re: [PATCH v2 1/3] mm/zswap: don't return LRU_SKIP if we have dropped lru lock To: Yosry Ahmed Cc: Chengming Zhou , Johannes Weiner , Andrew Morton , Chris Li , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 628BD40007 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: nrcmortpf4bfus6467xgenrmp46p9hhm X-HE-Tag: 1706573586-360015 X-HE-Meta: U2FsdGVkX1+i6cZ7GGV5s8jcJdmvaYh4zVtRwmG2/7I5veN4MKngzfTXuVEcDYkQt+OLI0gCbYEYuayafSS6AnQkpcDt6knF5I8WsqDNfSFRWLOUu1Gc6qMHP7M0OSek/NG5bbNR4bNZyMrLwEQSKsucb+GkVT2oNXbDI11ScQYCYiDEumWahMBWcTMGzNfWcJlI185AKo2JSjaC380y67b3kBrdZIKp/GujywxqYuHmO7R/0CfYUp2rFRIcKirbzyasHxySLdwKw3IXQvKT8f3/Kq4ma6vsPA8IKhUTi5gBNqeTyPfiM53NeW1U1zNYBJXHbqtqiSk58nBU7cLAPOwrPPg4zw0+ZtFcV4TQipbHwbVftV3y1qbFGRIfTPexpFe48yMC2x8vU4Q4eNhXhfdICSMM8RfOdINCgBomdoTGc28VCgOG6APfMUFrFkkHe9gNwr2bxSz03drNBVnjHFM2/4Y8ZB4oOU2afepVxx4xw4UXk9MJYD1iGgzKT+I6jjZEeDqJKfLlKY0oI/f8xV4MxQLlRlYkYrqvBWK7VuY3aI2i26emBLyS9ywoMdSLnNGWt4pQcHGY8lG+Pf+2pouFG9vUULs6fqmLPhLR633vVgUM1ocnTMe/i2SCt5DoD63+4ueDyacetXrabhfNJjTeVwFoWddb9cLEMdrwaTQSXKtTbjBag4fp6mApCmQOLaCK8qlI2kmj1v2lznpKbD+gLqiZY4gdk5VsYs6DsEXjWPsEA0aurwzEydz3BeDHmHftro4JLvaUpZxLqsFscnLBAmvoDUFigTDAk6koLi4B7ZfeCVKeG4c5OutQr2LYsA/6ZGmM7RKFsTZSo0bKWXYruqv99q2jc7++bDxblUmqUYD7D8r4Q+rURKK+2jIxunbRuDt+z9HjzzaeOMBorg7Gkd4amjQsUAtftWOzf7CPzvta6Cgu8OHz+aQ3V8V8nudrYTPRZoDUF6p/Nj7 Y68fsAfD IfLpURL5+6ufrQYANxhxOs1+1oBOe03BAlkLPtNQn/nOfLSMIMb9zQANCuxMcl5/Wg5/pKegkFy0ki4/W78/L4dDEKjWz8bFWKHUPfPxpO6Vw//zVGMRjNSCqPncRqEe/0JiVeEfgSit+I8dsXnd+1whq8bBmsrsIgql5nlh3kKkV5r97kF0ViDJHE0SfROEhQSN51PpO65gipywLpouJTI3GqIH3bmCETYQFaD6cp7ey8uxkptO5crvgnv0ktSud3RxmVmJSoWIa68UIKLP5wtUl6/RH6UX8PXPsMe264hGzjx8mOhQFZ+qeFrbARb/kV8PiPa9zkh/iB96wYZnl+9usGBZi+HBL52sNYJVrGVASYIrhKGgoE23k/fro2gjptX0bsgl3larUB6xf4hMJCD9nOWnhVDMQuB20PtsEs3q6B2r1bPyrWp9VjerSFLmq0dz+YVQoB38LUMXfocKZIjU1AaD4POgxM6kzbvj1shRrRDO6mtgcXeIwKtlLfHohCcz9lnWXO1iVaYArGT1HqZzFabLWx6e6Dpk/4A23q43EZ6Ca2j0xEjlmcw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000831, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 4:09=E2=80=AFPM Yosry Ahmed = wrote: > > On Sun, Jan 28, 2024 at 01:28:49PM +0000, Chengming Zhou wrote: > > LRU_SKIP can only be returned if we don't ever dropped lru lock, or > > we need to return LRU_RETRY to restart from the head of lru list. > > > > Otherwise, the iteration might continue from a cursor position that > > was freed while the locks were dropped. > > Does this warrant a stable backport? IUC, the zswap shrinker was merged in 6.8, and we're still in the RC's for 6.8, right? If this patch goes into 6.8 then no need? Otherwise, yeah it should go to 6.8 stable IMHO. > > > > > Actually we may need to introduce another LRU_STOP to really terminate > > the ongoing shrinking scan process, when we encounter a warm page > > already in the swap cache. The current list_lru implementation > > doesn't have this function to early break from __list_lru_walk_one. > > > > Fixes: b5ba474f3f51 ("zswap: shrink zswap pool based on memory pressure= ") > > Acked-by: Johannes Weiner > > Reviewed-by: Nhat Pham > > Signed-off-by: Chengming Zhou > > Acked-by: Yosry Ahmed