From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 493F2C021B2 for ; Tue, 25 Feb 2025 22:28:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9FB96B008A; Tue, 25 Feb 2025 17:28:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D50826B008C; Tue, 25 Feb 2025 17:28:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C17B6280001; Tue, 25 Feb 2025 17:28:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A2DA96B008A for ; Tue, 25 Feb 2025 17:28:35 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4C8321A042A for ; Tue, 25 Feb 2025 22:28:35 +0000 (UTC) X-FDA: 83159907390.16.8311FBF Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf26.hostedemail.com (Postfix) with ESMTP id 62C47140004 for ; Tue, 25 Feb 2025 22:28:33 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hKQpqPwj; spf=pass (imf26.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740522513; a=rsa-sha256; cv=none; b=SUrW+b3IPpQ7AAnUhbdp5sb81aWNuA+iw9CKnhbWQiOX8YXgqV88QkJGWlcwFFPkhwOkRv hFWsXupb7WNiKji12trZk3+IwIHP49Kx8ftn+8V1qmaEL6pgSyqfDgXhuZrGLT/dzvrkvw m/bfIg8e7aFdX0141PuZQm5PVcU6FMw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hKQpqPwj; spf=pass (imf26.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740522513; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d/vvYkyp7Hb/QOidIce1lg6CZDEUavwEmPlWHS0qFxI=; b=tlkSAKZ7LnBOjMZFD0MWd6/2qgrPfOsPyFKdH6ns4oP88NGsVqXzXDyH/4IJI3WYBR+DSa DN5JlWDrpZZtNMXTmY5FmA7YWDMmI4eczfDg0EBFeFgnm38/Xack/FhkGXhsVd+rH+6RcC u0pcqaf88XGEG8vnbt7RX1o+OUe5atA= Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-6e67fad4671so53178746d6.1 for ; Tue, 25 Feb 2025 14:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740522512; x=1741127312; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=d/vvYkyp7Hb/QOidIce1lg6CZDEUavwEmPlWHS0qFxI=; b=hKQpqPwjzpgJ1YNmncV3wJSrUUVqIjypT0prcIj+LHJOxuO2Gjki6qdFC+bPu4Uq0K +GNuDqMWGmVeKeMZ4EPzB05flPnzyvk0FvStEGB/gT0cAf0STtWwypqvX5yZdKk4du1k t7TXI0/A7jGtKItxpcC4OyDjLCxv8vdQTl7f+IbNeOI0806+x1SjXjA97YFGa/U5xpjr kRLZ+AuTEpPQ6Mvn9fmcyotxTq4nI3mctTdySNxsxOdocVbBLjJ/3J+9J0h0pOYImQ0t 8yyyoNPUyKjI3zkhmfC3/q7hqKEy0lW7ofNnOdxxqW4e6iT3mlCAd8Xe9biS2ckSXtfS Pw6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740522512; x=1741127312; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d/vvYkyp7Hb/QOidIce1lg6CZDEUavwEmPlWHS0qFxI=; b=ImGjHsysby+qfNtl+vUUxQfyc5WXHDkTiV63l6qCFnyiCmT+ph91PwskfqKISLR4Mp 466EKIZHrzLC6cfZnMBRRX7SkXf1IjhrlySYsGfnKD0RikAsm1RmcbxaD5BrbInnlpDm LDGjr9Xuo8IdpdGzOB4h/3msTKArhlQMs9sj++x3q4a8hINlrpZAzrZrR4igfS6XF/Ir TbYb5Qp0sb0ltAy94QsZTVwN6UDmERulv7zrEXzDeXEalwGOaT0/H183pLKyG8VagwRX i8/+lGp0df52mg0ZFarQi1n4nP762GFL1+SV4SmI2BWwERFW0anqnHkMnBgWiM86sHNq IYpg== X-Forwarded-Encrypted: i=1; AJvYcCUgWl1TiWV8/sjknFef/zq7B274OGtSVyrMzKu3ZFiTLpDGwA+FvAKqROHcQne7JqEvkSyB2Mi6qQ==@kvack.org X-Gm-Message-State: AOJu0YxbILqpGkm+c7kj/X7h0OkBpejCZLBQVe5PndjIw6EvY6mLChSS Fp6LlTVmb0JsD+PiD1D8dJv7/13ZsN4qHNVlhqP89ww7M35qe3Ysh8wmwLGtlkR0q/IJEiehHm7 EuAJ9y06/SqMJVyzG+D4eJZrDyc0= X-Gm-Gg: ASbGncvMjydEv3Evrg6aFk7YJkxRxa2IjYWLZkSmKn5yEdf53xEHepRsW82TWPBrNpN JWh0EYiNGXZOXqRpUtMm5u95mA8UWyPzwc3I1xPkOYK8h8fzfHE1BZETHLFz2tZIKXj3Mt9AGpf C+TXfT8w93mkoYxAn8pzT9pdtGjRSrnfIpldFTp50= X-Google-Smtp-Source: AGHT+IHz/Af49tTQvF2gXpTHPb6xQHIyiSN8wd7gJXeCwTVtHe0hucq8LVTvxWzrwI0Pz8Ltsf7x4kEfoV2c7SKEQ0A= X-Received: by 2002:a05:6214:484:b0:6e6:5d9a:9db4 with SMTP id 6a1803df08f44-6e886901dcamr16015806d6.41.1740522512399; Tue, 25 Feb 2025 14:28:32 -0800 (PST) MIME-Version: 1.0 References: <20250225213200.729056-1-nphamcs@gmail.com> <20250225142518.cec35a0ea77a0d86f3e860c3@linux-foundation.org> In-Reply-To: <20250225142518.cec35a0ea77a0d86f3e860c3@linux-foundation.org> From: Nhat Pham Date: Tue, 25 Feb 2025 14:28:20 -0800 X-Gm-Features: AQ5f1JoxxuL2tZkp3XCjgAMe7HNqcE0g1hHNvRdYOmpLmlRy-y9P30uIFJX2xeI Message-ID: Subject: Re: [PATCH] zswap: do not crash the kernel on decompression failure To: Andrew Morton Cc: hannes@cmpxchg.org, yosryahmed@google.com, chengming.zhou@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 62C47140004 X-Stat-Signature: hnzoui13pbbsbtxgq5uka7feup5k1bnq X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1740522513-533032 X-HE-Meta: U2FsdGVkX1+tfFgV5YJs/lAwqMXd3N7K88RYDsk4c9zWUcpKXM1R/+Elvc3FDe0XYVV1v55IZo8Q0dI11YxjMhPCNWhnTjCJCZ0LV+t8PTx/N1eStH7gPrU3aikHAi6BYoFSQVfJlY8KVn0Ow7h++KMZdU8eZOyqzXXefnEEX02mFkTYHzCD7sNh4gRmKD61emYmvTLKt5dOTpGo6sqvokbQLFD1sGI00Kwp9+/iFgmRTA7XArsNt0+KxG7/Dm9GstXYNhr5Kggn3Gobv6WcOO8/IDM2cN2+PlY285/Wr3neNtlbypdaiX1bp8+qu1b+eaLkka5HfCjcyf7MJxNhZO5XHYNaE8QchTD3nqCKhlgMqBuSsAMmcuDS7mYCUCj9Bag+57oLi3CvnyWXk96Kd9FmnWJqhOFKOn8AIQE7Q2QvPge35XdgTS2lLpMN+o+zkdTzjH45BVVWX32WUHHUFLh3A/1VXqcrjGEzG5oJkuXZwW0NOXl841bgoApxmP+GKjd/+uoNgxlURQqBg2YzuaehmWQN2vqJsmTb0kb+nPsE9T8oI+NarRZFJ8sEMnTwz423nqEHNzFhrkwhMLmh3CDrBCxNbOTE5dKGuIBt3REF8+9wEdBVszhNpMP5i9159LJ1aNnVGVkoGxVlo162aeWDbjztX0vj+tsT0/ySVoTJjojWlGFPm0OvzY3Q3ffzyMfGS0ruWFEtexUhWH5p9sWLL6FOHYDlAkfMQPO0iXUDWFkdk3bUP42mK1XTScrpzQKhnjik0I4IoVBXRGYzivVHTaPPxz1roQlMbM8fyWLH/p5JEF/pPGa/svItRj4dSLoH/jVMMYhuGTQCUaRiGAlTws/KDWMcU4cbol2KmCVsAjyKEqKKIg2xI364nid/mai0RsIyy00LrpPfqkLSm/pr5Vs/b9HryzTx8QDQT7d7jJJhk0PVyRxVIEdIVfXiKWAhDhpWmZdmGsv8CtF lHotya2q r4aB13roMr9qocTBeim4MPh8/PQyBzmU1wh0fxPQVaOoAv49rSDkLuD0fH4SIEPEACl8F/Tbna+7FBrReelyXXnYRn2dq4ZuFy9lXwNfU4b1EA/WBBLxbYnHkt7772YnPkRHzIuEgZ9rIVozbHaW9eu/QA+gwUcjuLqsXj/8Aevyeq6ba86F386c8Izs7aNaVJ//+pM15C2q5+1rcsXJcB1rs74K+Zt6OoAKzaHYRdCx6f/Mond7vX6uudg83kM+dtTukesnvtwWK6G9gK7Un5yhPK4r4K/lZroAOAxgtavfyNYiI+sW/+MIXAG9sK0E7ia8GjYUsmILdVCN6MM+v/DNuZQzoU2uEQib4+HbtC98Thb0JHKTewPXShJ2AN1ag9bz/20ujX4HyAFMPQBIG7+BeyQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001157, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 25, 2025 at 2:25=E2=80=AFPM Andrew Morton wrote: > > On Tue, 25 Feb 2025 13:32:00 -0800 Nhat Pham wrote: > > > @@ -984,12 +987,19 @@ static void zswap_decompress(struct zswap_entry *= entry, struct folio *folio) > > sg_init_table(&output, 1); > > sg_set_folio(&output, folio, PAGE_SIZE, 0); > > acomp_request_set_params(acomp_ctx->req, &input, &output, entry->= length, PAGE_SIZE); > > - BUG_ON(crypto_wait_req(crypto_acomp_decompress(acomp_ctx->req), &= acomp_ctx->wait)); > > - BUG_ON(acomp_ctx->req->dlen !=3D PAGE_SIZE); > > + if (crypto_wait_req(crypto_acomp_decompress(acomp_ctx->req), &aco= mp_ctx->wait) || > > + acomp_ctx->req->dlen !=3D PAGE_SIZE) { > > + ret =3D false; > > + zswap_reject_decompress_fail++; > > + pr_alert_ratelimited( > > + "decompression failed on zswap entry with offset = %08lx\n", > > + entry->swpentry.val); > > + } > > mutex_unlock(&acomp_ctx->mutex); > > This mutex_unlock() isn't present in current kernels. I'd normally just = fix > the reject but a change in the locking environment needs some careful > checking and retesting, please. Hah strange. I could have sworn I pulled the latest mm-unstable, but maybe the git pull failed and I didn't notice. Thanks for picking this up Andrew! Lemme re-pull and rebase.