From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38BD6C369DC for ; Thu, 1 May 2025 15:13:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DBBE6B0085; Thu, 1 May 2025 11:13:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 489E56B008A; Thu, 1 May 2025 11:13:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3789B6B008C; Thu, 1 May 2025 11:13:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 178216B0085 for ; Thu, 1 May 2025 11:13:00 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 31D19140CF4 for ; Thu, 1 May 2025 15:13:02 +0000 (UTC) X-FDA: 83394681804.27.9ED430E Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf20.hostedemail.com (Postfix) with ESMTP id 892411C0005 for ; Thu, 1 May 2025 15:13:00 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="CBDKh/14"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746112380; a=rsa-sha256; cv=none; b=TJoSy27xorBWTfaHL3VkNvrZHE54jZuOQ85GKaDHFD8ZXDFMaZDZsfg+mCQ+I8Qg+XVNTI RkAtMzZoVKV6lWdDlgE0JNJKOXJAy0OQVxssNb0ApiexGgunxs+2yYtRIzwGiqZDX4fSlY 4eQruTdkYVaiMqavXtDIVaHQIEgz9ZQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="CBDKh/14"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746112380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xQYoQ6blzMcLADqk42repQh467cCu5FADPOPWsPwKR4=; b=gxGy5emdQPa0sS93PQ9fmwGrgqAFr3D/pzazsxDWCATIgY+uxkYb19JAZ05AoUZnuqXrx3 b/Yfn7Uolphlg+KTtWa+pNLGyVtLKdGQOoU5gbi9/21u7Nix5jEoPGap310JsWUdQiyrAB pVupQSdRs1oGD8MtHPYIjTHh/fude8Q= Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-6f0c30a1cf8so17169876d6.2 for ; Thu, 01 May 2025 08:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746112380; x=1746717180; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xQYoQ6blzMcLADqk42repQh467cCu5FADPOPWsPwKR4=; b=CBDKh/149FtQXF7uoBOJIz9/ucZZYeQnbF8tmpSIvNRiP6sJrIaM+exrZ5AhzdJZ+F wNKGFw7m6KQucvdcYgr4HQzlbMsm1tyEfSx1GUAPu/LjKKTz44KKxvFAEjTrugBQtUUb DKu6nNCsx8UJol3BzGNszgqihOKdsIBaH4k2f6WiaPmMUVtBWMWXL53KcyUuHV9KP+bt rvyhfFDUkY1SpVi/7WWOfQfrK6hardIcK/yrqmb8LSJ9+IxE4yGe7Jehuf1/SMw/9Uwe Wdzq9qn5Wy6OgqUfvH+QKKDpGlh+R5MS2q57zpE7LFlq01cDKAweLSaQeXK74VjD7eqo NTkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746112380; x=1746717180; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xQYoQ6blzMcLADqk42repQh467cCu5FADPOPWsPwKR4=; b=KcWUqjdS9eWRxgnfx4EKVRtfkSdVFgVrzw6GQYvIMStDIjuwns+fLUDdjeenDo8ifq hLNjAdmsXMKlSKzbLai839hfG51xQn8ILpWB2GUy8Ze03bbFXMyDvkUhHfRgEP9G8Czy 4SyPyfrPmn2okqqj4kYXitA3tp3xBKpChx7TBL57ANegt/fKIOJGiBR+vNn2p09QIeA5 kwWBM6HmNegavrR6lpCw+poQAS6gtC8OTedJookG7V2TEjy/zCrCJKAMyXmJSrepLxUO vyOqKeLjCN8kOnIqdujaSj4CYAkwF8sQXzHf2neySuaxbgrG+8BhGj3Vwx2TN4rT7K5l rLtQ== X-Forwarded-Encrypted: i=1; AJvYcCUizOf5+nKCtSzDzMddKGFYFAqIA3b8iSM8cyppnt4o8vTEb88AHNXpWwALpqGJA99ugVDhGP6o4g==@kvack.org X-Gm-Message-State: AOJu0Yy2MwEqECWNaHTAHR1WIP56ikC3FDRlNJqdi0hTMf7nKbHUu2bg XPOs16MUCDJ2YHzaovkMZC1CPMJoVYTuGnFm5vr5m0bhrZeCC8mbacIwU2oLkVJfPljuYHVFVO7 Kqhf9RuYpxHaHsP5swV4quRJ1DZ4= X-Gm-Gg: ASbGncvPir+6/6rppNzgYMDUBuf2BO51SA6UvgJEYWhVQg2oRv7INms2JSZ89iaYpGw SqgDwhRTimuJMykIoAknfNybKIUbyIjXNBUKfLFLkagg2zbaLzPfChkwdvXU8SqYvQdCcr5zwTk Bb+Ikm4dR0/Z+fGqMQ3i8fsRk= X-Google-Smtp-Source: AGHT+IGAdTAkywowhkq9htFUL863njyM7arTMBHIbku24t5R7jVNw6BjMXmXswwZnPdgrERB600zafxI6/iVqN/kPo4= X-Received: by 2002:a05:6214:410d:b0:6e8:fbb7:6769 with SMTP id 6a1803df08f44-6f50a91ffbbmr48422286d6.14.1746112379547; Thu, 01 May 2025 08:12:59 -0700 (PDT) MIME-Version: 1.0 References: <20250430082651.3152444-1-qun-wei.lin@mediatek.com> <20250501140226.GE2020@cmpxchg.org> In-Reply-To: <20250501140226.GE2020@cmpxchg.org> From: Nhat Pham Date: Thu, 1 May 2025 08:12:48 -0700 X-Gm-Features: ATxdqUHwMXp9jU8G8_cQ9P3g5XjhCdDwSp9AbCfZOwreqQLiBgW7BVs0NuAIwgQ Message-ID: Subject: Re: [PATCH] mm: Add Kcompressd for accelerated memory compression To: Johannes Weiner Cc: Qun-Wei Lin , Andrew Morton , Mike Rapoport , Matthias Brugger , AngeloGioacchino Del Regno , Sergey Senozhatsky , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Casper Li , Chinwen Chang , Andrew Yang , James Hsu , Barry Song <21cnbao@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 892411C0005 X-Stat-Signature: w7ikemjx5asf6y8gzpsq9s3iw85u3pyg X-Rspam-User: X-HE-Tag: 1746112380-940025 X-HE-Meta: U2FsdGVkX1/0HQjLvSY23YH1vTLX8q61POUehURn2ermEoKtAxuPGCVic0v4reojmg97QlmZqdsFDiLw3FGwI0UOj+fBcb3RxGiSe+zd6bUOpystPbwUDKRB63lvqBgUN4Q9i7rps5CmC3gGwNRcgfLTviJAQ4BKh508hBsolbnLBnLPhTkU2EP2D6egqXM/IN1dffZmJxtpYew0ZbLpvenT59B/agsjkwAtYN7ne8azKC2L5M5IvNtiZ6ffhnVZm1nqmfAXbjAyB58TX6eOsBrqv29Jc+zEykg6r8LxoFC4ypTPI+gdprPkzFqo5jo5w8oGvwLftpDp3LSkEJ61baFxiQgV4x2DIO7TCa8zkptg3JMYUystBp1pELdPAIBwCprehCPOt2/n8XsEBdIXbso0UeGwElz06WMqu2ESznZ+93VklZUn+RPlJWFARF1xpHj0UMOSinZ+bGfIlwPN0D42PYphxtREkc2tymWJmTGPL5ylHOb2GCU2Rm36dBQuCszSEHlg8wQCERqrzb+30JGA0HZtKo1duppkNszJ0ZirBcPjaUsU/6hNYD6UuIPkZgeF253T1cJ7JqtMPhIsWqEEUnYgKHpqzGGgqmf4B6GrrhmR7mfNyQJnoDSWDaHXfvmwLzni7oTN21fhCpBx+EcbV6opov4EMWONObflh2hz4IrC/uKNBwYkwpeMiet66dotwVsSFHpDIJKHezbzYf/s95VDFj0xvfcuDaoSo9oUHfPcw6ce5tW16uMRVI/Htu0VeD8damC9CvYg6VQuYdEr8w7kgx2FXW8Y92RDKFMUNn/qE0E5Yix1qwTkftyTEykF/Lv1Mya916rOnO4cI7Tw70RTxuVw4zdy5LpXg6Q5WwdFkwfjDqWr3cHU+KY48tPn+PBT4tkxaV4Hgv8NCqDF4spjH6oYUoeqz+SwSC2MSju+tnLQGxTVXe+m1aRBXw4ySIWRpVQUDCzCoEm Lq/WoupW Fe8xPYiHPxYntw7YisxJU78FjI/B9DErSbFJSS0fFIyPCju3mT9UcWhIQbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 1, 2025 at 7:02=E2=80=AFAM Johannes Weiner = wrote: > > > The way you implemented this adds time-and-space overhead even on > systems that don't have any sort of swap compression enabled. > > That seems unnecessary. There is an existing method for asynchronous > writeback, and pageout() is naturally fully set up to handle this. > > IMO the better way to do this is to make zswap_store() (and > zram_bio_write()?) asynchronous. Make those functions queue the work > and wake the compression daemon, and then have the daemon call > folio_end_writeback() / bio_endio() when it's done with it. +1.