linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nhat Pham <nphamcs@gmail.com>
To: akpm@linux-foundation.org
Cc: hannes@cmpxchg.org, yosry.ahmed@linux.dev,
	chengming.zhou@linux.dev,  herbert@gondor.apana.org.au,
	linux-mm@kvack.org, kernel-team@meta.com,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/zswap: reduce the size of the compression buffer to a single page
Date: Wed, 20 Aug 2025 11:17:33 -0700	[thread overview]
Message-ID: <CAKEwX=Mq=EtxhnKhNQ7ZdK18wU9hPEarLR1NhsgB3hm6G-GRkw@mail.gmail.com> (raw)
In-Reply-To: <20250820181547.3794167-1-nphamcs@gmail.com>

On Wed, Aug 20, 2025 at 11:15 AM Nhat Pham <nphamcs@gmail.com> wrote:
>
> Reduce the compression buffer size from 2 * PAGE_SIZE to only one page,
> as the compression output (in the success case) should not exceed the
> length of the input.
>
> In the past, Chengming tried to reduce the compression buffer size, but
> ran into issues with the LZO algorithm (see [2]). Herbert Xu reported
> that the issue has been fixed (see [3]). Now we should have the
> guarantee that compressors' output should not exceed one page in the
> success case, and the algorithm will just report failure otherwise.
>
> With this patch, we save one page per cpu (per compression algorithm).
>
> [1]: https://lore.kernel.org/linux-mm/20231213-zswap-dstmem-v4-1-f228b059dd89@bytedance.com/
> [2]: https://lore.kernel.org/lkml/0000000000000b05cd060d6b5511@google.com/
> [3]: https://lore.kernel.org/linux-mm/aKUmyl5gUFCdXGn-@gondor.apana.org.au/
>
> Co-developed-by: Chengming Zhou <chengming.zhou@linux.dev>
> Signed-off-by: Chengming Zhou <chengming.zhou@linux.dev>

The syntax changes very slightly, but this is functionally the same
patch as Chengming's. So I'm keeping all of his credit - please let me
know if I miss any proper accreditations. :)


  reply	other threads:[~2025-08-20 18:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-20 18:15 Nhat Pham
2025-08-20 18:17 ` Nhat Pham [this message]
2025-08-20 22:46 ` SeongJae Park
2025-08-20 22:56   ` Nhat Pham
2025-08-21  1:36     ` Chengming Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKEwX=Mq=EtxhnKhNQ7ZdK18wU9hPEarLR1NhsgB3hm6G-GRkw@mail.gmail.com' \
    --to=nphamcs@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=chengming.zhou@linux.dev \
    --cc=hannes@cmpxchg.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=yosry.ahmed@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox