From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C44A8C352A1 for ; Wed, 7 Dec 2022 17:28:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED6A78E0003; Wed, 7 Dec 2022 12:28:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E86FB8E0001; Wed, 7 Dec 2022 12:28:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D274A8E0003; Wed, 7 Dec 2022 12:28:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BFD4B8E0001 for ; Wed, 7 Dec 2022 12:28:42 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 961D31A0B9A for ; Wed, 7 Dec 2022 17:28:42 +0000 (UTC) X-FDA: 80216194884.20.8B4AF86 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by imf24.hostedemail.com (Postfix) with ESMTP id 2B5F318000D for ; Wed, 7 Dec 2022 17:28:41 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lolI73W7; spf=pass (imf24.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1670434122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=apHINZRI82aKyVlEfjuhtBGaqHolQ8IQWN/c5e4WtmE=; b=Ntm0We4x3zZnm3fjTcmQ0dclcYw16jD8DmHnW4SF7UZ6+yUDhTxYxDFu5+7M55gF82sglY dIFKk54R1uSu6m5L1Ji73wp3JFA85EiaJM7S2RAjSoYj4WcsxZ0YMeTGKMOEtKyp/sdXma r/oJnqLPQAGqdmzVBHC2LT2PbWna8qM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=lolI73W7; spf=pass (imf24.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1670434122; a=rsa-sha256; cv=none; b=SRqxvXSQL4wEmDEnkZsQwEnwDqUjTIw/9eL9ePk+0Ofdn/PhnHL5HItnedJEcSgpmsnLkB eJ4xvqxFdOmbvPce+/A8KEW2WEGcauetjdvHdywd2HMdFxHDwwKCiZ+a2u1jL/ciM9hhhr wsfCaAFNfmVaig/qoBUspsu7kEn50RA= Received: by mail-wr1-f41.google.com with SMTP id bx10so29143617wrb.0 for ; Wed, 07 Dec 2022 09:28:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=apHINZRI82aKyVlEfjuhtBGaqHolQ8IQWN/c5e4WtmE=; b=lolI73W7ggYljDiRWvtJ0YSQSHeXmC01JTcvMR3TNuIWzNf3IgsQJu7nNxzbPUcR3w y0y8AW1ZJxP0xhssbXoK5m8SW8Do0+fbBXFlnXoY/Mk8hQPFPJEQGl2DUKnALTdctm25 PHHjK4SuvpTgtKqH4bb0dYMQPx72nV94rrXzGmgYpSHkjiPVexDSFrWNjU5R3rKZkDHT knoOfqthedpbfiLCZNct9RXqcS15Y1WGJyUrN3yYahDaaGo89FZKsGQkN4dtWGpaf7hN YzyxJyfuOPYQEQOCt99vP3TCUe9RmJzuufA1q0Tw/PLA0eMe5OUSI5sFhwkkh/yrxgCt aq3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=apHINZRI82aKyVlEfjuhtBGaqHolQ8IQWN/c5e4WtmE=; b=phc2m9IR4oE2xlNddUtc9PxMGYq9TBZ5jc3GRq1RCrXavpFbsuPpRbPBQ5gj5VqWxz sgej/RWfKP1TAsGbYT4tqp0naXcEIzI/SxvjKLv8sWF9in2HMg6zDHP1mawUP2Sqwz73 7HsNcZTOxyo0tv3z11tFsXa6lvY8/TMioiWD8uF54Csx6hzQJRDn075iEmQY0yX+Nwgx hq6g5E0lkr/6shyiVy+LwVxgkORXiovdTOlxwBmp6K2P2DnoNTnx3n8pWNN7Q8KDLT+5 6nlgkEuB/coMUd+fC0GvfCF12iPp+XKxaIntni6TpEZxdQbrBjf1k0I1tkcxTiHtB0IK NFsg== X-Gm-Message-State: ANoB5pm2CsOEv2jl22AjPKoomLBlWGwmxzWtOVHB+y+Ocim0gAaL9gAH tn6Hx6edOZNDxfCLdU+hAGdw0XZBm1NSyjOhRSI= X-Google-Smtp-Source: AA0mqf6lfG8+zRqSPFF8CVq7AlapT7nk1S8+ohBzQUkyKmyN+PzmVDG0lYhFrzwjeI6K0IyfemWgq6sEeB2haGcWqXg= X-Received: by 2002:a5d:4b45:0:b0:242:1ade:1145 with SMTP id w5-20020a5d4b45000000b002421ade1145mr26825231wrs.483.1670434120604; Wed, 07 Dec 2022 09:28:40 -0800 (PST) MIME-Version: 1.0 References: <20221205175140.1543229-1-nphamcs@gmail.com> <20221205175140.1543229-3-nphamcs@gmail.com> In-Reply-To: From: Nhat Pham Date: Wed, 7 Dec 2022 09:28:29 -0800 Message-ID: Subject: Re: [PATCH v2 2/4] workingset: refactor LRU refault to expose refault recency check To: Matthew Wilcox Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, bfoster@redhat.com, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: aed9j6prtex6o4ujczco7g5up9jnhkmg X-Rspam-User: X-Spamd-Result: default: False [3.08 / 9.00]; SORBS_IRL_BL(3.00)[209.85.221.41:from]; BAD_REP_POLICIES(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; BAYES_HAM(-0.02)[47.95%]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; DMARC_POLICY_ALLOW(0.00)[gmail.com,none]; RCPT_COUNT_SEVEN(0.00)[7]; DKIM_TRACE(0.00)[gmail.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_DKIM_ALLOW(0.00)[gmail.com:s=20210112]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_DN_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17:c]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 2B5F318000D X-Rspamd-Server: rspam06 X-HE-Tag: 1670434121-425523 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000019, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 6, 2022 at 7:22 AM Matthew Wilcox wrote: > > On Mon, Dec 05, 2022 at 09:51:38AM -0800, Nhat Pham wrote: > > +static bool lru_gen_test_recent(void *shadow, bool file, int *memcgid, > > + struct pglist_data **pgdat, unsigned long *token, bool *workingset) > > This line needs more than one tab indent. I tend to use two tabs, > others try to line up the parameters with the opening '('. But > one tab is too visually similar to the body of the function. > > > rcu_read_lock(); > > > > memcg = folio_memcg_rcu(folio); > > + > > + if (!lru_gen_test_recent(shadow, type, &memcg_id, &pgdat, &token, > > + &workingset)) > > Similarly here. &workingset looks like it's part of the body of the if, > not part of the function call. > > > + goto unlock; > > + > > if (memcg_id != mem_cgroup_id(memcg)) > > goto unlock; > > That's fair - I'll add another tab to each of these lines! Let me know if you have any other concerns.