From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6FE5E82CBC for ; Thu, 28 Sep 2023 01:00:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F0A38D0088; Wed, 27 Sep 2023 21:00:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A0B48D0002; Wed, 27 Sep 2023 21:00:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38EA78D0088; Wed, 27 Sep 2023 21:00:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2B1438D0002 for ; Wed, 27 Sep 2023 21:00:46 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F35A2B3B0B for ; Thu, 28 Sep 2023 01:00:45 +0000 (UTC) X-FDA: 81284201250.09.7CDB817 Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf18.hostedemail.com (Postfix) with ESMTP id 2295D1C0036 for ; Thu, 28 Sep 2023 01:00:43 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="XM7/nvK8"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695862844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KbmQXiIb/6ha3RbpQiPYuun60PQSJ8nGNO0HCRh4zk8=; b=8lMIgbj2FIsLJmkQu2FVUH2kd28SF7CsCQoDfjchqXJK+cva9REky8amHV6gFVi9fgE24P kaXgu4femCWdVHVW52TcOajGDQU7BPIqQBZZEslbUMxfq0dA9CJifoet/ZkcKz7L4csOtt wDRV5wABSbsgqBYuHLQkkkR9G7Q8Ffs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="XM7/nvK8"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf18.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695862844; a=rsa-sha256; cv=none; b=MEgiFKs/RmjefrutFqKjdlt5lpbua7MnI1Bve1xhntoWKoktsyNSbCtguMUQYdk3gtEk57 IW3ptK32Phcv3JmcghfPxi2I1JGEF7SopHMGts179LFwmrPT4WshaKAMpOPK6pF4JoJj3I L/9Y9yF1YlsPfMwqWn2HIzjzwSEB01g= Received: by mail-io1-f42.google.com with SMTP id ca18e2360f4ac-79fe6da0095so140358939f.0 for ; Wed, 27 Sep 2023 18:00:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695862843; x=1696467643; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KbmQXiIb/6ha3RbpQiPYuun60PQSJ8nGNO0HCRh4zk8=; b=XM7/nvK88PpKW52L0Alj7FXMzV7oOISl0rVNYplitmGhPda+yhOAMBgoomK6hcPC4q 4G46RP7G2zgqUj+iN1jX8eFMAQQXmGQkyOZ36OHbVTEINZcxuUBTXDA4/Ti9ZL6zB7QI c5pYZ9QLdtzEpMWo8lR9HRl+FyhdzOYr73E775oIcOHVUGo975M7r4BKuIGWuKrFZCyG kqZcs2ArjnEBdg2TCE3D4H9T8obSwHt2OC8rhJ92jUtjG9+q4gxpypqMKNL7CNTCUjtb 1SDORjzlTdNIZxuJKVv0kmjrSimlA3JMbCTzQUcZungqKlgFo+T8tRFa+1A/Dhawf+z3 iL/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695862843; x=1696467643; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KbmQXiIb/6ha3RbpQiPYuun60PQSJ8nGNO0HCRh4zk8=; b=P9n7rsFsIftFnsoYJIPeB0zVOXzKCo0xqWsUbQr1neu8htFXXr+Zc5QcKYDfv3gfTZ ThNgKF+/KWROqdhHUbVZPnx9ky7hgDlzmIVKkVodyFgWLDm7lQ9kdvv+pdLqgimo2v6+ cUqdXg8uD5RmroymKis6qQA8f2l7Yx7Be1rIkB0tG4H1Ej2ybyaa7ZAR6yDj9xYjea3t fRf/5snmm+7vvmIocyPJFHolB1kMNPtZ5ojlJlywS1nF/C3i5WptCJIXZV0uMAQo5r2f Qu196tPYhtGwTbPoAxLW10XrAbHjhNMiPrq7w9AkHDHD2vQiUt594J0Pg4qCS2zgTE6W MMoQ== X-Gm-Message-State: AOJu0YxRP1NJYPMcYh4otJS0qPJ8lTvnGfdXwCwSKRBVTuiC5RMVnHMm 8HypzSEIQouUPKkEMAXQduzlaFpTwyU/a08XdaE= X-Google-Smtp-Source: AGHT+IGraQVaz++c0TuIHxnjgvrQNR+F7cLgT1kxcj79/8QWJdAqqUOQh0mJXoYanAp5mx/cjWaneXaDjvBz6BRx8go= X-Received: by 2002:a5e:8706:0:b0:798:134a:44b with SMTP id y6-20020a5e8706000000b00798134a044bmr3574638ioj.21.1695862843166; Wed, 27 Sep 2023 18:00:43 -0700 (PDT) MIME-Version: 1.0 References: <20230926194949.2637078-1-nphamcs@gmail.com> In-Reply-To: <20230926194949.2637078-1-nphamcs@gmail.com> From: Nhat Pham Date: Wed, 27 Sep 2023 18:00:32 -0700 Message-ID: Subject: Re: [PATCH 0/2] hugetlb memcg accounting To: akpm@linux-foundation.org Cc: riel@surriel.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, shuah@kernel.org, mike.kravetz@oracle.com, yosryahmed@google.com, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2295D1C0036 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: w4x81rbqt3qu8oh4ibj1gj3wfteeeobj X-HE-Tag: 1695862843-984852 X-HE-Meta: U2FsdGVkX1/hUXb7PDOQCOGROOPOWhREMXIpKSwa88rY64I40mlJ3tymP6cYS2pSsQyMXb4ei+D+d6np8TLsC5Kq4bFVYEnO1Sjhb2ACCZz8HFTqRiChdUX4XNbgOJqeYpoxxWAyu4wh9TlJ6SBu/3762xTV5k9MvbMfGAtOs25jRuDZlXWbN/PJamnD0W4Z8AopPKAhpInrA6COpmsV1GwGy3706v5L8WTxTS4+agzqjIE7Jvk5cCiC3mXYXZ5VJ29Bi8fgwUmy02+18ELnx3bws0FoXCOG8lV9hKb1DYcfwGnuov6t84i1Vb/h0kv32AGP66fb7LJHthcnh5IgOxdFgHqhb9l6X4jVCFF7eOQ9edPPozoiPqW5Oz4UbGTfHVmfCStbGE3hmj/OjtGOAyLEVz6xpb/2tDB0kFb1+R6QAcNNfNx3HY2N7PLTqF+iHUM1kpvgmmz9PxaG66i4aLhlL9IWZ5WcT/UFRLQFvTsvhycbcWMH8YBUtX3nGJrE6L70CbxSmp3vUOyDksznQLormnMHPH/gGgqLR3kWciAIZCn9ryQhscgiYK0aVITwXKaevYLONwQCBgrO75Ar4wrNWmEMqbAiHjKDjUaURSrQ3mDeHDGBqHQM9up7PDTqgoW7hGiS3UFDrIIl0DB9doll/8FGH+VCvYlIiFCwwVgj8VgSv1LzYwBiy6QVRsr/ylEoOlbb8546iah2pdAQtAIT4u7ymrZzir3pI7HVNhjK0I9XdqkWOFUeZBE9BjCvcFvJcSObtCxILbbXT8CA+8rH6YrLAvVYiE634Xi9gdA9We1yYCH1x9V9KX/LYbM2bLpO8t1aoAAstSHCVDA6NV3oHQNRLDWdB6r7wZhbjxYIdgV9dnj9wZ/OHRBozYI70H2KQQNBHD1PkR1w8g9JaEScLHR+JeAuf8IRB+AmcdaG3AotpbXixhF3HoqS32U3+qAgQwA2h2AJ0o2j3gI NFlMsG98 BRRsyVZcptH6Y903NGeP0TWLxdbYDZsy7a6N7S1OGTvZ4z0i6+/Pm/+UTLN1oPcRTs+SSgq5sPDw28Ta0OwSAbDo0Qmndfw4jMDYjb4Tg9sxdgQprjWJDTVKdFGuvk4y3tKBvlMccLnrmi33VS4I6nPPhYhlR9sk9Zm+snrW4grYogveEioGY0bwr6eTUbDn9T1h7SuP55mbJv6i0pLSAq2Xwqo+rBJtopHvF0JQYUdzMDFS5huPTB105mjWkl0ZCnQbiYB0myNtXdEq/o2F/DvnsXKoNCzB7CfxBP8DZhtWzppAx7istT93v2ary0ta9/2pC4zMs6kx+rLUuZNhJhWGf+6Hmbml5fudiVsket5YZmFKjkbIwadKkfCNdRz+BrOqXv6E6Fwh1yr0C3KEe4aQ0NuI+mvIP280wEXSvAoTPGSbQldBJbbk5wj3cnrv0SQ4eDsDMVtYOCZeJtS7zmZoIg4de9ZQxqpTG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 26, 2023 at 12:49=E2=80=AFPM Nhat Pham wrot= e: > > Currently, hugetlb memory usage is not acounted for in the memory > controller, which could lead to memory overprotection for cgroups with > hugetlb-backed memory. This has been observed in our production system. > > This patch series rectifies this issue by charging the memcg when the > hugetlb folio is allocated, and uncharging when the folio is freed. In > addition, a new selftest is added to demonstrate and verify this new > behavior. > > Nhat Pham (2): > hugetlb: memcg: account hugetlb-backed memory in memory controller > selftests: add a selftest to verify hugetlb usage in memcg > > MAINTAINERS | 2 + > fs/hugetlbfs/inode.c | 2 +- > include/linux/hugetlb.h | 6 +- > include/linux/memcontrol.h | 8 + > mm/hugetlb.c | 23 +- > mm/memcontrol.c | 40 ++++ > tools/testing/selftests/cgroup/.gitignore | 1 + > tools/testing/selftests/cgroup/Makefile | 2 + > .../selftests/cgroup/test_hugetlb_memcg.c | 222 ++++++++++++++++++ > 9 files changed, 297 insertions(+), 9 deletions(-) > create mode 100644 tools/testing/selftests/cgroup/test_hugetlb_memcg.c > > -- > 2.34.1 Thanks for all the comments and suggestions everyone! FYI, I have sent out a second version of the patch series with the new mount flag: https://lore.kernel.org/lkml/20230928005723.1709119-1-nphamcs@gmail.com/T/#= t Feel free to check it out and discuss it over there too!