From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C7A4C48BC3 for ; Tue, 20 Feb 2024 01:28:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4BC06B007B; Mon, 19 Feb 2024 20:28:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D4C76B007D; Mon, 19 Feb 2024 20:28:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 875056B007E; Mon, 19 Feb 2024 20:28:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 72B576B007B for ; Mon, 19 Feb 2024 20:28:19 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1B04F4048A for ; Tue, 20 Feb 2024 01:28:19 +0000 (UTC) X-FDA: 81810446718.13.76D48A6 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by imf24.hostedemail.com (Postfix) with ESMTP id 3CFD5180025 for ; Tue, 20 Feb 2024 01:28:17 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ebFjv7vT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708392497; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZK31cEr9hehp80gGWlXDH0T921MmH50qjE0kSGVtUsY=; b=FZLGqWGolyqXYOjBh9U0JcI5e2u2zYQ+4a3GFb5wrGEBPv0gX1+3uR2j9nTitlteIp7n6j BoxnXi9u55D0cMN2P1WBkOXj9g669doPdnEezWtKeJE3uHiE/j1TMgK16rHDLVkl1VwYb2 MyOrGQ5WU/pAXP9Ik5DOYUXPvfQfueM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ebFjv7vT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.53 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708392497; a=rsa-sha256; cv=none; b=W+mj60rb9V15QncLDxfv5CMP9cLcBI7FPWR51iZTKmBWZfFJRauWJa3nxXle6eaUZm+Km8 MyH/1rezpTvzD+Kp34CXnDfvlvBeew4BJZIrsc+7CMWubTlmvld5fBQKCu4b49jJLHPlp+ HvQXI2K1Q+gEW4FTkrIlQ7fdIRLry0I= Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-7c403dbf3adso261355739f.1 for ; Mon, 19 Feb 2024 17:28:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708392496; x=1708997296; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZK31cEr9hehp80gGWlXDH0T921MmH50qjE0kSGVtUsY=; b=ebFjv7vTSQhUY46VvIH/eRAXosAYJtEg6ikXroxDZtQxEMZQRFpgaDEpfQxDEKYVTa MYU2UBiUSi4+u8YXqYSLjcD/TQxezikws7d5ec0t2NFXwPxqmwFpcSB/dJvyXOCMxFMG 7gp0g90mbOacjoffqRv83GJ4wAXQeoOGt6KeVXThykApvVVKfenJclIcN9PPgnBidgBw mTMrcKaEG/bnDFgd11e6hyxG5Vyn2SCoSRqxOZCuGPww8TPG22Nr8sqMT9/AensaK8iV Yp1XxHg96hEpEHZDCxFekIHk1ada0XBKVI9b/Fa19GOVzsbzaaBCuVUTjUW8clkwmSdp g5AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708392496; x=1708997296; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZK31cEr9hehp80gGWlXDH0T921MmH50qjE0kSGVtUsY=; b=QquBj/A2KxDEhxDYl9T6vZI78KZQaxG3fSyvwDrD2irEhLJIXqOz0PxQSOAkhdUv70 plkS15ubS3vxjxVDKcYgeZ8Cw5tFxhoQJ22sWXU7OZATN9pK5LUdUo7Mkn7R+CL9Soeo pTIRtFTQbzl4BdZ12TuCHfCW53ebehGDBl5PMZE/pDteImvQACxvgXNsWE/pYDh0FYIp /+/T1NRImsMRJUBXs5hOMwuZJhfNelJe1qOwYfkAQ5duqdE/tmQ9vNHsfZ6h0SaevOTS A+QFoAGvFQbHI702CmbWjPPNK3L6e5gMFOteT+nJYQX/JIDrNy0R5TnQIxfEHNvKx0Ci CbLw== X-Forwarded-Encrypted: i=1; AJvYcCUr60WvEwapM2WIqyY2fCKFcw2/KL76e0C09+9UfpfBsoer8GJZAfJTVIcNFmmQVU0o1Snxt1wqRvzb83YwlkueUDg= X-Gm-Message-State: AOJu0YzubwXNZXdelkLPddbzgkYLRov4nI6Wsa4DLKCq7T2VAqDbimJM /m9A6SsMGjdn0+cdDWNmnnafI+1jx+ivOSkBZ03DNnbMkHPrw4Jex4/0p/eyFs5EKoFK6QYng8D LiIjqRp7jhtSbw6hVy0ZS5Zluj7U= X-Google-Smtp-Source: AGHT+IHyD8b3HQhCtghTRL8o4uFCt8wqF/sqZERoOEKliE9fJxFdcS81kappcd+XgV+AA1xEe6/AhLaG/z4/TRq8MTA= X-Received: by 2002:a6b:c8c4:0:b0:7c3:f3e4:8ed9 with SMTP id y187-20020a6bc8c4000000b007c3f3e48ed9mr16741687iof.6.1708392496280; Mon, 19 Feb 2024 17:28:16 -0800 (PST) MIME-Version: 1.0 References: <20240210-zswap-global-lru-v3-0-200495333595@bytedance.com> <20240210-zswap-global-lru-v3-1-200495333595@bytedance.com> In-Reply-To: <20240210-zswap-global-lru-v3-1-200495333595@bytedance.com> From: Nhat Pham Date: Mon, 19 Feb 2024 17:28:04 -0800 Message-ID: Subject: Re: [PATCH v3 1/2] mm/zswap: global lru and shrinker shared by all zswap_pools To: Chengming Zhou Cc: Johannes Weiner , Yosry Ahmed , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3CFD5180025 X-Stat-Signature: 381nasm4ochco9a3ioj679ryeqegoj9h X-HE-Tag: 1708392497-450287 X-HE-Meta: U2FsdGVkX1/OtdZrvA9VaFarC+1J51bb84lpEwKUOZANozwlw/VwkC75p75V97EmxEvKQsaUX7s4KDJxmyiCOxXCshiQbRwB75s5+gXW9KzzfbjKkDp3u8cWmigYf1XvEbZHblQPSqxdi84UARPldSkjMlzs0dkLouNEl7GXeNUCxXn1eUmxV68LoRAmusCrQbP2x6TfEEJTLhFr+ABatg5c0HBMqXASFTDCVY5JI6hPbDgHVRsuqhx6wX2oZbQWCAhUVuskSUm/fKWT09nFuq7De5XQ/jdf7/LeMnCvWR2Dx9CpjFACCQE0Cay+zMb2X+DtaTbwX4u6L8qbGJvX10i4MtOsM/Tgf0RFrx/pl4OlRltBzIcM6HBap2zsc3zrne+/z3X6vFBK/DCgmG+t+MFXdtTmv/HmKaNJ3kt6mkq/fOkO68b/yhe0n8Dq49RisFtjWgIyCngx+MGfuAvaDC11ljGItiCxHclVMllLO5tnsf12dZXo/GCqi35EA/buh+VCDLKgim/JQmM9XaCjWqKYC1r1Zs5cBMXa051VnB4a3jW1uhc824WF8m9OPuf5LGUW2eEm64dQwzjPf6i0SE30R1iggTcihzDhGiTe8DVzwWuB3vIga/AD6aQS1xTs0g/tNUMzRxcvvcMppEDTTe41JTggcTNanhORNuTnMpHTO/RMIuSbXDVlJeWIda4yxqM1cQhxGICd0HhKlTondcSZupEOCiko8r5ub/BjLQfbRLApb/PEEwC1jowcw+jmitisMttswFxdL3CspKrjdlympX38sZzoGDKhaeGncwqLhrIAE3nao2OXEBkpK1yPjAl1uUmpp++6f7kLhBJVmwpOZlQHf3SyA6EZY96ZvAud41GKMl/OdcOd8rhmLY1Kg5MG1vEsFGj2yXt9eNWQltOHzCXLQhnhtRQOPnp+HxwWBPDoyKjmDHIoQs0+zQjCUmGbKeI2eqmtaeSZKtq 8fumyZEg mFe8lNgDwR0OVoFVuu8Xx7mupLY0rPh/HJ/+DhAepLAgss5ozaOglP/15g6uJIaNUtKay2U17LBScR/WkxLt7TfvZQs8CDxeyhNX62iD4kG6ox7rptBUYKf9timB0/yw/n7g7/TxHEzF323pfhBcbg+4T/KpJIBHkdwz/4B8a6Pm+T/tdkxZTNdI/dNaZjB2W7M0KxiVGmB30q3W3HIHLc5LbZOBd6hA9pfcC7SpsfTSYFywGtHIxQDX/FFhZZD+fQEHPheuH5DGfZ1jyAcFhW+z25KRK6ABwVannDHuQOPoYZ7sI226GsLMlWbL6EaLL9YqdEr5gBS59RqJkO3RfuPs5NtMKvIwtque3xDtiqFVqY4u7wc9orKEDlwGaPAaI+18MM9byYV9y97wTlMXv4daLOYUqhOFfAouU/S6IDC8HZltyQ0DfOFcaWsCu16DecFbqeG96ol+EpZ2fgAsuLvnpBO32cqUqn0O/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 16, 2024 at 12:55=E2=80=AFAM Chengming Zhou wrote: > > Dynamic zswap_pool creation may create/reuse to have multiple > zswap_pools in a list, only the first will be current used. > > Each zswap_pool has its own lru and shrinker, which is not > necessary and has its problem: > > 1. When memory has pressure, all shrinker of zswap_pools will > try to shrink its own lru, there is no order between them. > > 2. When zswap limit hit, only the last zswap_pool's shrink_work > will try to shrink its lru list. The rationale here was to > try and empty the old pool first so that we can completely > drop it. However, since we only support exclusive loads now, > the LRU ordering should be entirely decided by the order of > stores, so the oldest entries on the LRU will naturally be > from the oldest pool. > > Anyway, having a global lru and shrinker shared by all zswap_pools > is better and efficient. > > Acked-by: Yosry Ahmed > Signed-off-by: Chengming Zhou > --- > mm/zswap.c | 171 ++++++++++++++++++++++++-------------------------------= ------ > 1 file changed, 66 insertions(+), 105 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 62fe307521c9..d275eb523fc4 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -176,14 +176,19 @@ struct zswap_pool { > struct kref kref; > struct list_head list; > struct work_struct release_work; > - struct work_struct shrink_work; > struct hlist_node node; > char tfm_name[CRYPTO_MAX_ALG_NAME]; > +}; > + > +static struct { > struct list_lru list_lru; > - struct mem_cgroup *next_shrink; > - struct shrinker *shrinker; > atomic_t nr_stored; > -}; > + struct shrinker *shrinker; > + struct work_struct shrink_work; > + struct mem_cgroup *next_shrink; > + /* The lock protects next_shrink. */ > + spinlock_t shrink_lock; > +} zswap; nit: Is there a reason why we're putting these in a struct instead of just a bunch of static variables (perhaps prefixed with zswap?)