From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD96C36010 for ; Tue, 8 Apr 2025 21:12:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0800028002F; Tue, 8 Apr 2025 17:12:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02DF728002E; Tue, 8 Apr 2025 17:12:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E124728002F; Tue, 8 Apr 2025 17:12:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BEE0528002E for ; Tue, 8 Apr 2025 17:12:10 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 31BA8161584 for ; Tue, 8 Apr 2025 21:12:12 +0000 (UTC) X-FDA: 83312124504.14.B4C9642 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf13.hostedemail.com (Postfix) with ESMTP id 5CC492000D for ; Tue, 8 Apr 2025 21:12:10 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eOUz7lbQ; spf=pass (imf13.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744146730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nojSFlVcSyIQcnEdfe6GX8xr2qQICvdL/DiJTdnBrCw=; b=ALs5uGCnKouYI91DhmgnlkbW18D3FPn8XKMTMV/TUXbNg6uhXh1suBtdtbCqdqVIFoK/0M m1nQHVb+8+hmZfadk053WGmKrKMV9l31+x4NcuOzfjehEqpb5tRqn49NbvqNmjkXCyQPqJ NL9XVB5ejwdD9+DYGwMGMtKAcaTBVw0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eOUz7lbQ; spf=pass (imf13.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744146730; a=rsa-sha256; cv=none; b=NMUGm4DdS/bTYf4lEu34MysfnHiHvJuXHmLRtNvDfr3+yaJcbVh7hNQO+s0Egtj9V5Z1J7 zhQkf8AXa+1rD9w1IuMGrY5rZUTHK7GvbzYhY0Y0jS0hqZmjhWS7bSUhn2LobsvtD8dbsy O+srf6CjBpSYv2jV5jpOZO4l2VMJW9Q= Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6f0c30a1cb6so16999996d6.2 for ; Tue, 08 Apr 2025 14:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744146729; x=1744751529; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nojSFlVcSyIQcnEdfe6GX8xr2qQICvdL/DiJTdnBrCw=; b=eOUz7lbQTd/HDswhIEbo2T9PSbiH7cRqhEr2hG2w75p0YhW87TMEGm+uUAcUt9kgko rtFOEAVUg+Fc/4spaBj1oOeK1huOg7zAoMSB5nJJ3FyB+RCWhaNwDwBz+0/AlnDSp3SZ RP45ZbXH2PAOrOwZMlr53FbEvlEm6HTPGgRmcegShBYQadyTcLY9wLoOEaf9U0uDxd5t OJrE7KI9T+BlgbuYVpiSWptrIDEFnnajJrb8y7CcckXGFF3giHu+0cmCdxc7LuFFVBQW vStHOiAmrT2mfBPs96pDMrdCFA253da+e+c10DonfKYRVOjAcVlofXfBjA3Sge46slaK lBDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744146729; x=1744751529; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nojSFlVcSyIQcnEdfe6GX8xr2qQICvdL/DiJTdnBrCw=; b=NZcpg4HuNuLZcYc33vGFvD+Sd8NNXc0fWWIwMbALW/NTw+bkDUNfTFzABSPaTiWdMJ eopJHKLhQhJuhuNr0qEinulmfZKDbCmhagWY69Hc1ZapN8WeYXVauYKMpFmn7HyBhahP 7fW6bb7XSb9iUBimdYWAPAL/hFEyoPDPyulqUTI2HRughZmpYLJyro1Che/jxMM/eWpy FfSE0pzDY/9w7Dnt/gYK81SNPRzR4VU7lF2D+BAJfVcCYhaxHuLwaeD44aWknIwIcHar EXf7Bu7bvAgUBKYjRqt7O76FpU06vT7V9c6L1o4VSS3DgVxTcqBEqDLIIJ1akPNT5KoP k/UA== X-Forwarded-Encrypted: i=1; AJvYcCUcbWoOe+sCSoS6vJu/33R4yJhxb4pWPnX2L9xXM3jRtGI6fotU0hIIgtifOUYy+uvbkRxgsMe5Rg==@kvack.org X-Gm-Message-State: AOJu0YyKR9GyicVILVFevAexLl6CTDAPogDC54NxMhNUuF36f1jnNZ7U 0GV+K/qZ3803e/aG4zLzKBNyNDS8bsryfLhS1ZN5rrsJPiPH31HnsHh7HjvDy+oVyBK3mlcXapt Fq5RpZI1+MS83/BP08FwKQQ270p8= X-Gm-Gg: ASbGncvqEbl7Cs2Q4lp1P4lNzjss+ZNjFNdy8PiervrW4xPKAw8IkMRu+BW291fyVSd z2V0Nl0xzP3n7WPp+0T3ARZaMxGnBaGabrJXrAwMDYPPWLmSolpcmr2BpqgzAjTa65JrXn9gkAo DMxjr7+lY67vR0AhzqvklBdeEIxFqOHTIkB0Ccq5YqVTEGjLgYh4JTXoWyz7PGEcyb6z8w X-Google-Smtp-Source: AGHT+IEv9ekYn/0Xa3K/HDTyJit7j9QjQxCq/pWIh1vT4jWUvxJoY0LpaZLnkQdm2tjJDX9Mg2Ipjc0YDXhZDSZL3bc= X-Received: by 2002:a05:6214:1d08:b0:6e8:9e9c:d212 with SMTP id 6a1803df08f44-6f0dba25c4fmr12781026d6.0.1744146729387; Tue, 08 Apr 2025 14:12:09 -0700 (PDT) MIME-Version: 1.0 References: <1743810988579.7.125720@webmail-backend-production-7b88b644bb-5mmj8> <0dbbbe9d17ed489d4a7dbe12026fc6fd@beldev.am> <3f013184c80e254585b56c5f16b7e778@beldev.am> <20250408195533.GA99052@cmpxchg.org> In-Reply-To: <20250408195533.GA99052@cmpxchg.org> From: Nhat Pham Date: Tue, 8 Apr 2025 14:11:58 -0700 X-Gm-Features: ATxdqUGe66tCEnADy_Rl2l-6ZAMQMIeuxX6rPnLrvjqmPV0SV9JCUJw_1bUTGWg Message-ID: Subject: Re: [PATCH v2] mm: add zblock allocator To: Johannes Weiner Cc: Igor Belousov , vitaly.wool@konsulko.se, linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Shakeel Butt , Yosry Ahmed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5CC492000D X-Stat-Signature: x4dc191zakohfzho8rgams6dxjcnpxiu X-HE-Tag: 1744146730-625426 X-HE-Meta: U2FsdGVkX185Q8AOWDoW8y2LyyM2dY4dSJ6Ytpl1yK6k1Ga24xPZbhyY/rnBYGhH+HKb4lO+T4FW5gYFMK+COC6/Se8bREUnmGkY66s52v2Oy0gB0tVCn6kfuropo2+QFA8Ng4HoBUFej2p14yWg+wY9qcJHXak0Ad6NX4UkBurgD5wdNakA+XZwLVnexmMHzaUNOG48My7sNwg1DegLT7L+4ZxFFAG+LApj84ifnBGmBe8McR9nslEhmP3nsNqr/fvyLxFd7R2rzKIYKiJ4u5YR2k6ss7q9M/4w0CAIWla2iw8oxgyxHt0GA1LSaQ12O+jCDwWKEYTVpS3eSqPJTMME7zWyUq2/oA8SVV20NRbAyRBRgA8QQfr0HuWbEShXw6b9fSpTRAlD6gL63lH5nmUmv8WzE3vMntkCkn3wTb6Es/uxz54Tt+psAg6Os+/8GTquVQmqH1U8W7t4XSH7x7s7xDLUyqoGuAQFLkSbLxBLz7eV1PNtl5mkSUiSzDAp9Ol0izLCkZm5nz0GKRz8G5MeVdNzplNNNlrnI9Mgra4B4DcwIhSWjcURuxZJCHCLZSfuS5gaXocybvJBow82KAHFUGUAJK+3pB09T6GHH5u8U3O0EgbfKDJVSIhXH63HvPiYFh5GYWuh5t6tsMl1FAIQrA29cocbBhuoBVtfwANrbzuJXJVXdVGXDrn1wynGqv9j33HzdCn4QPFHtV9tezntTUPT02YqXAwPbSyNcUVrPJ+Qdpc4pVCWelCYznaPZHWtrIuN2fWAldB8U5koRrA6XlDyrQ3V9gf87vFQmp7f3Ux3ZepKdKKJxerrEEVuje9R4oz/d/0Pqq4QBvGKkk7ap9jfPtkuZSM0TAejm+WnzShCJvyvMWbyUjparRa0kWjF2s5Scw24h5lQo5hrpJsnbI6IIcF9eQmqEja9G9n+kTnwUsm7NoOjmqPMxLDpW3x3W+pkaa0g2XqiQZW tiBmEwv4 vT1qS4oSaaaCdZ6H0+MerN9FQvSwe89nweB1m+/1gRMIVjL/rfXQMhNMqEnOEaRnYOjHdhxN+uAr34XXxvqc2eh9QgDw8dpXbivbj+26xHdUhBetJSFHW4YBfd91OIwTfXHX1+/4W3Vb+qxaDH/PvX1V94w/m8L+T0hrGFngDJ5LGb/2tvQF7DSHmAHszpb95S/S/qyrPl2WDb3j6pCnWmc3xGc94Stgi/i0AZ/Bnzy3ZZF2fm/YtLCujG/yyvBDr5cCWaZ8+pAY8CGMy/t2RKbeF72Zlt/1HFDxGIYQ8Jlmgm9+b7KGAmOrwJ2B/4TJi91XovOx06q6T4j6nM29YJWAyiR211f0/dMXT5AjkkFMn6FvQlCXO61dw7j2XjlA1ay66 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 8, 2025 at 12:55=E2=80=AFPM Johannes Weiner wrote: > > On Tue, Apr 08, 2025 at 01:20:11PM +0400, Igor Belousov wrote: > > So zstd results in nearly double the compression ratio, which in turn > cuts total execution time *almost in half*. > > The numbers speak for themselves. Compression efficiency >>> allocator > speed, because compression efficiency ultimately drives the continuous Yeah good compression ratio =3D=3D better performance, assuming we have an allocator that can ensure a good enough storage density to take advantage of the compression ratio. I think the experiments show that. We don't need the no-MMU upstream-speaking, so with this I struggle to see the point of inclusion of this new allocator. > *rate* at which allocations need to occur. You're trying to optimize a > constant coefficient at the expense of a higher-order one, which is a > losing proposition. > > This is a general NAK from me on any new allocators that cannot match > or outdo zsmalloc storage density in common scenarios. I'm sorry, but > I really don't see any reason to do this. I'll wait for Igor's and Vitaly's response, but this is a preliminary NAK from me too, I suppose. > > We also should probably make zstd the zswap default. Agree.