From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91D5AC4345F for ; Tue, 16 Apr 2024 00:29:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D685D6B0085; Mon, 15 Apr 2024 20:29:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D185A6B0088; Mon, 15 Apr 2024 20:29:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C06DB6B0089; Mon, 15 Apr 2024 20:29:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A2C456B0085 for ; Mon, 15 Apr 2024 20:29:26 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 58762A0353 for ; Tue, 16 Apr 2024 00:29:26 +0000 (UTC) X-FDA: 82013511132.18.9247B71 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf24.hostedemail.com (Postfix) with ESMTP id B36C4180015 for ; Tue, 16 Apr 2024 00:29:24 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VzQDmIuk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713227364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yf1gUr1tvKmKsM1pOVHTcwnl8aKHEskvwPqkV6rEw7A=; b=woXnuW5HDTQSXwlBvBA1d55PIszIe1m8bFk5oMKOOR1JuwxWdAN21xj1r44wbc4Q/u6bKy vJAvIdry2xh829gg74FJ2Z3fKbhM1SKU44o9TrpzxASQGsnGLzPJgEElFjBBahcIMKRwZB v5dr/e28UT2AOjtpuPVoNTBxN96Z5VQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VzQDmIuk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713227364; a=rsa-sha256; cv=none; b=m+Y4VUGCXniKdRdn2PyXNCdXYEiN+Lfxc3QGABVq6nQP8x+FJc/m22ld2jw6J+PGMjoaCD dEEg2gnjUBi3XJQHxHX/vlZBHG06YJdghaAT/RQ2DkSeuETmbZIeuX9/euUbaxQrK/8sL+ fEKX4x3xbFa3eq0f47SxEjbImRapwGg= Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-69629b4ae2bso33797466d6.3 for ; Mon, 15 Apr 2024 17:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713227364; x=1713832164; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Yf1gUr1tvKmKsM1pOVHTcwnl8aKHEskvwPqkV6rEw7A=; b=VzQDmIukxbZI5UAO99P+JElh7o64T1Gu7vdKdZo1ZFfwuckNqojPG0p0tizSghQg3L aqJDDt0xTb7SbZNSKnhsud2trhzmdFHY0J9VrNrRhjYYGwC+kbKODoDF0wQoCTdRupdd Vfmgny0ZpgNqR92F4jXW7bTeKHBN0KptZ95+YbcISq8BzTBbxlRZyLvWAson3wTO64sK TLLXxIMWGyceBDV5IzwmhpsYalsM/qzCe/EhMPT+YgQ26oBy4kPbj446KghWIx0cgUYC 66ezjfExUf20EMebi7pUQUxmfg9c9kkhYkXNYnj8zewXCOWU/8pKd+oAco1rzaxAJmtm PYXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713227364; x=1713832164; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yf1gUr1tvKmKsM1pOVHTcwnl8aKHEskvwPqkV6rEw7A=; b=TJGqoIqDmjG4JxxZlc759toNBlW+nzXN0b/TrFvH6HFLHDZpPEiykBCHtdiwTZhKt3 pwXAodPOb61sSAMByVwaq/mezhQBiiR+mGwrmOisSJHBjw15YdvScbOpBkPmxfyLxnMj B0eVzb6v2EtSEMjOyr+vX+XfN8afCy9Ecg/eWUlrDTTlf1+m6TNGt+ev5MLWA6DFI/AD 6on2ZvJy5owaZpG1IFUjr/W8uwUIm64SCf4P/n6oc6Ss4WDRKP+2prkLTEAW2iSKOM7a XhBUIqg4hMhN/gD9dGbYtDhscCKMttRVe4jlUn5R1MOHC8yGcZFjqRky8mwrzycSMafO bjpg== X-Forwarded-Encrypted: i=1; AJvYcCU8KGRJiQbqTnL685zIyux5SKG7lXpn1ehvGbO7bi4S9M/7QzEud40hDE00B7lgTEipiXgfeALl9zGJRz+n+Q3naME= X-Gm-Message-State: AOJu0Yzfrw1b/g48q2CEosfBF4nJAciHOpvBmmKdp5HSSMrTlyfoBAc6 orNNnCrclXqGpRqqnYB+n06dI/mq51q28qIoWLq3/ePZ+barbhZwKQ1ygGrJpzqv0tETa6N4X3H OdqahzyquGE5itieV+k2Kk1P5vaU= X-Google-Smtp-Source: AGHT+IFprmh+7vT78kNblQOtapK06gC/CQ9a7Zl18oKXuT/I8ULx3XNzmCJY5UzBGVmcdWWmKctXD7+TkZTWYk1wx8g= X-Received: by 2002:a0c:e944:0:b0:69b:7a52:a894 with SMTP id n4-20020a0ce944000000b0069b7a52a894mr5297027qvo.46.1713227363836; Mon, 15 Apr 2024 17:29:23 -0700 (PDT) MIME-Version: 1.0 References: <20240413022407.785696-1-yosryahmed@google.com> <20240413022407.785696-3-yosryahmed@google.com> In-Reply-To: <20240413022407.785696-3-yosryahmed@google.com> From: Nhat Pham Date: Mon, 15 Apr 2024 17:29:12 -0700 Message-ID: Subject: Re: [PATCH v3 2/4] mm: zswap: refactor limit checking from zswap_store() To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Streetman , Vitaly Wool Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B36C4180015 X-Stat-Signature: gr7awcka93iqe36k17de7m35wa6rbfkj X-HE-Tag: 1713227364-793681 X-HE-Meta: U2FsdGVkX18BSjEb0JHjmcSZQk5AH6Cx1YhcDWnCevPCjWKKmIS++oKmprdKvWm3/yAhxlANHQ5OyBW44YFV2hppuLfHDqv71vhrr7s7we2oHecKd0nK7vh9NZjD6z9H+S6Osis3Wvn30MRaYdSm6d5k8TGoy2sLjvIEcDzXswgTob1RfEQFho6XTCrjoDmpyeZUb1Xm993t0fsP4qfZ/vtf8dQ52W09lWKZ04JM5q0aWUQkThWtIIOr/vBy7Wf+JvOMEtgNeRtleh4ZoTSb8fH5V4tWvF7HIWdnHECDn3JlC9Lpf38MhMcxM/a2XJERqwlcMCIz+TYjqRRt7+TFE819JGzlaOTHDd1dOTY2+C5VFoyrMwNj2HmUfBPTMN5cfkgj5jx9Ia27XkT8qaSMoKtB+vPtvnza4NqGAjICQDCeOlnLFnVtbgCX5s1Sn9uajvmulhpLtRbzxWqpS/dvCpKtFUoed7h+nc69fBGiKekHV6mn6MTcv52ru//fV3nEWD55Fdr+ds9xj9gOUrCwdoDXXr1LSIwbC8FBBheGNnnMcqo5L+fSeiUxfSiqjRKXPA/1HOYmHwsLN+Dmb6lrTh1PAyjrrd0mYO3aV8jxLqDJziPOMGWMTJw2NXNQNkoXqPPE1zZV3gO5oR8uHa/MXzKCLVM1nKt740WgSJ2LL1YkfAKzVudArygKjEOkYbfJk3Yq7aOxS/2237HcNbJQNaxz8CLU4lSsdrSH1bxsMnnqdtBIGtwiiJaANrhXZN5PVxBw87fMMbp9qYP2VW6ptL6pRa9Kh2/2cIx8vraNYKTHR3c3baGp6bg949tOVeiynIXI7WjuCh060Rcb/oS9nc3EhMo6RZwEAoTooZVyvmdq4ZUY8uILaJG+at01HIoTipmSieX7lc0MWTJzXewf+Ayz4MlbqIhjrmWhWiQZ4vCynLDRLhVbjispggHI3/OVF3X6XEXSfXylXyBgVzH y8e4K5WQ CXPI4A/oSTIYg3X1SimygYPEWjAtwcNIxnl1lKScBdsNrhAQYDBcYPRTRYYJ3zhNqClcQZxqLmKmO4lk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.030696, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 12, 2024 at 7:24=E2=80=AFPM Yosry Ahmed = wrote: > > Refactor limit and acceptance threshold checking outside of > zswap_store(). This code will be moved around in a following patch, so > it would be cleaner to move a function call around. > > Signed-off-by: Yosry Ahmed LGTM! Reviewed-by: Nhat Pham