linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nhat Pham <nphamcs@gmail.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	 Chengming Zhou <chengming.zhou@linux.dev>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	 Dan Streetman <ddstreet@ieee.org>,
	Vitaly Wool <vitaly.wool@konsulko.com>
Subject: Re: [PATCH v3 2/4] mm: zswap: refactor limit checking from zswap_store()
Date: Mon, 15 Apr 2024 17:29:12 -0700	[thread overview]
Message-ID: <CAKEwX=MXKTWzCxPLy8VtdUxM8JFSpX4cR9agMDVtta_O-ZXFVQ@mail.gmail.com> (raw)
In-Reply-To: <20240413022407.785696-3-yosryahmed@google.com>

On Fri, Apr 12, 2024 at 7:24 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> Refactor limit and acceptance threshold checking outside of
> zswap_store(). This code will be moved around in a following patch, so
> it would be cleaner to move a function call around.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>

LGTM!
Reviewed-by: Nhat Pham <nphamcs@gmail.com>


  reply	other threads:[~2024-04-16  0:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-13  2:24 [PATCH v3 0/4] zswap same-filled and limit checking cleanups Yosry Ahmed
2024-04-13  2:24 ` [PATCH v3 1/4] mm: zswap: always shrink in zswap_store() if zswap_pool_reached_full Yosry Ahmed
2024-04-13  2:24 ` [PATCH v3 2/4] mm: zswap: refactor limit checking from zswap_store() Yosry Ahmed
2024-04-16  0:29   ` Nhat Pham [this message]
2024-04-13  2:24 ` [PATCH v3 3/4] mm: zswap: move more same-filled pages checks outside of zswap_store() Yosry Ahmed
2024-04-13  2:24 ` [PATCH v3 4/4] mm: zswap: remove same_filled module params Yosry Ahmed
2024-04-13 20:56   ` Maciej S. Szmigiero
2024-04-14 21:06     ` Yosry Ahmed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKEwX=MXKTWzCxPLy8VtdUxM8JFSpX4cR9agMDVtta_O-ZXFVQ@mail.gmail.com' \
    --to=nphamcs@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=chengming.zhou@linux.dev \
    --cc=ddstreet@ieee.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=vitaly.wool@konsulko.com \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox