From: Nhat Pham <nphamcs@gmail.com>
To: "Thomas Weißschuh" <thomas@t-8ch.de>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org,
sjenning@redhat.com, ddstreet@ieee.org,
vitaly.wool@konsulko.com, linux@weissschuh.net
Subject: Re: [PATCH v7 0/6] Implement writeback for zsmalloc
Date: Fri, 6 Jan 2023 12:32:04 -0800 [thread overview]
Message-ID: <CAKEwX=MPxEsCJ8V8vNvMgXJ66Pq7qxnOX6S1sf97dc-oqaJfWQ@mail.gmail.com> (raw)
In-Reply-To: <20230103045730.2ctv3n2ckzzmdzdx@snowball.t-8ch.de>
On Mon, Jan 2, 2023 at 8:57 PM Thomas Weißschuh <thomas@t-8ch.de> wrote:
>
> Hi,
>
> On Mon, Nov 28, 2022 at 11:16:09AM -0800, Nhat Pham wrote:
> > Unlike other zswap's allocators such as zbud or z3fold, zsmalloc
> > currently lacks the writeback mechanism. This means that when the zswap
> > pool is full, it will simply reject further allocations, and the pages
> > will be written directly to swap.
> >
> > This series of patches implements writeback for zsmalloc. When the zswap
> > pool becomes full, zsmalloc will attempt to evict all the compressed
> > objects in the least-recently used zspages.
>
> Then this part of Documentation/admin-guide/mm/zswap.rst should probably
> also be updated at some point:
>
> However, zsmalloc does not implement compressed page eviction, so
> once zswap fills it cannot evict the oldest page, it can only reject
> new pages.
>
> Thomas
Thanks for pointing this out, Thomas! I'll send a patch to update this.
prev parent reply other threads:[~2023-01-06 20:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 19:16 Nhat Pham
2022-11-28 19:16 ` [PATCH v7 1/6] zswap: fix writeback lock ordering " Nhat Pham
2022-11-29 3:47 ` Sergey Senozhatsky
2022-11-28 19:16 ` [PATCH v7 2/6] zpool: clean out dead code Nhat Pham
2022-11-28 19:16 ` [PATCH v7 3/6] zsmalloc: Consolidate zs_pool's migrate_lock and size_class's locks Nhat Pham
2022-11-29 4:01 ` Sergey Senozhatsky
2022-11-28 19:16 ` [PATCH v7 4/6] zsmalloc: Add a LRU to zs_pool to keep track of zspages in LRU order Nhat Pham
2022-11-28 19:25 ` Johannes Weiner
2022-11-29 3:50 ` Sergey Senozhatsky
2022-11-29 11:53 ` Vitaly Wool
2022-11-29 14:03 ` Sergey Senozhatsky
2022-11-29 15:54 ` Johannes Weiner
2022-11-30 15:23 ` Vitaly Wool
2022-11-28 19:16 ` [PATCH v7 5/6] zsmalloc: Add zpool_ops field to zs_pool to store evict handlers Nhat Pham
2022-11-28 19:27 ` Johannes Weiner
2022-11-29 3:53 ` Sergey Senozhatsky
2022-11-28 19:16 ` [PATCH v7 6/6] zsmalloc: Implement writeback mechanism for zsmalloc Nhat Pham
2022-11-28 19:28 ` Johannes Weiner
2022-11-29 3:58 ` Sergey Senozhatsky
2023-01-03 4:57 ` [PATCH v7 0/6] Implement writeback " Thomas Weißschuh
2023-01-06 20:32 ` Nhat Pham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKEwX=MPxEsCJ8V8vNvMgXJ66Pq7qxnOX6S1sf97dc-oqaJfWQ@mail.gmail.com' \
--to=nphamcs@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@weissschuh.net \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=senozhatsky@chromium.org \
--cc=sjenning@redhat.com \
--cc=thomas@t-8ch.de \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox