From: Nhat Pham <nphamcs@gmail.com>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Ivan Shapovalov <intelfx@intelfx.name>,
linux-kernel@vger.kernel.org, Mike Yuan <me@yhndnzj.com>,
Tejun Heo <tj@kernel.org>, Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>,
Yosry Ahmed <yosryahmed@google.com>,
Chengming Zhou <chengming.zhou@linux.dev>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Li <chrisl@kernel.org>,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] zswap: improve memory.zswap.writeback inheritance
Date: Fri, 27 Sep 2024 09:40:56 -0700 [thread overview]
Message-ID: <CAKEwX=MPtsX0OexWfL3j-4TcPuAdoDWP4E2BzehrkFs67bTv9Q@mail.gmail.com> (raw)
In-Reply-To: <5hnu3xa5hcusvmvg37m5ktsfcutghk2z3dh7lcoctyyfluabqv@u4ma5mafchpw>
On Fri, Sep 27, 2024 at 8:01 AM Michal Koutný <mkoutny@suse.com> wrote:
>
>
> What about assigning this semantic to an empty string ("")?
> That would be the default behavior and also the value shown when reading
> the file (to distinguish this for explicitly configured values).
Yeah that's better than -1, I agree. Still a bit confusing, but at
least the semantic is "we are not making a choice at the memcg".
>
> (The weirdness of 0, 1, -1, -1, -1 would remain. Maybe switching this
> via the mount option could satisfy any user. Admittedly, I tend to
> confuse this knob with swap.max.)
Yeah a mount option, or in general some sort of global knob (with
proper documentation) would be preferable.
And yeah, I hear you with the swap.max confusion. That's why I tried
to make it explicit in the documentation, because the difference is
subtle and can trip up users. Hopefully, when zswap and swap are
decoupled, users can conceptualize them as two separate tiers, and the
confusion will lessen...
prev parent reply other threads:[~2024-09-27 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 22:55 Ivan Shapovalov
2024-09-26 23:12 ` Nhat Pham
2024-09-26 23:40 ` Ivan Shapovalov
2024-09-27 1:52 ` Nhat Pham
2024-09-27 2:28 ` Nhat Pham
2024-09-27 15:01 ` Michal Koutný
2024-09-27 16:40 ` Nhat Pham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKEwX=MPtsX0OexWfL3j-4TcPuAdoDWP4E2BzehrkFs67bTv9Q@mail.gmail.com' \
--to=nphamcs@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chengming.zhou@linux.dev \
--cc=chrisl@kernel.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=intelfx@intelfx.name \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=me@yhndnzj.com \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox