From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A82C3DA62 for ; Wed, 17 Jul 2024 19:01:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 751706B0082; Wed, 17 Jul 2024 15:01:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 701806B0083; Wed, 17 Jul 2024 15:01:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C82A6B0085; Wed, 17 Jul 2024 15:01:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3A7746B0082 for ; Wed, 17 Jul 2024 15:01:30 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AAFAAA3912 for ; Wed, 17 Jul 2024 19:01:29 +0000 (UTC) X-FDA: 82350163098.21.8C7D701 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by imf22.hostedemail.com (Postfix) with ESMTP id E1203C0033 for ; Wed, 17 Jul 2024 19:01:27 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CeUzL+tc; spf=pass (imf22.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.210.41 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721242867; a=rsa-sha256; cv=none; b=cnE4B6HEkdA7K2kHez8YUOR8OqWcv+XkGoQ+iIvw81rjdRHw8LdfwuKNlm7TIJidSTWTsL mYzzECqEey1g/VwZuwDYrIksGG3UPSo0oFdJD5/MrMx3Jd6f9zRw1xa/gTjE0I8moIW3qc zvrB9WYpqmAnve8Uo3f8HIUD1VH0+uU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=CeUzL+tc; spf=pass (imf22.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.210.41 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721242867; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yKGmITPHeBZC/W7CCXq1yfugfxa5MVrGs9L2E2gIK4I=; b=A7XKytZUWN8ZJNj+j8pidiJvlBxN6znTAid7n2mt0eom1gixn+TOgLJSzcPf8J1GSY6MJ8 ybp9tlMTm8EBy7wIL7o7q3pdWHv/GVrVhFs8GIyvtq5ifokwUyRLCayfspCMiblext/JsN 1hdI/DoJAerdBJKUYcX6E4LkNIYJr58= Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-70446231242so7765a34.1 for ; Wed, 17 Jul 2024 12:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721242887; x=1721847687; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yKGmITPHeBZC/W7CCXq1yfugfxa5MVrGs9L2E2gIK4I=; b=CeUzL+tc5Mnlw41vg8oBr+yRHT+/VBH9v906W4KDkCRb1W/kUdf5S0xOFSFK4Ygq7y cbDX05jh+Pvu9E9Zi1KSruw21bBHv9BcYbGAnFO9yPwlfYZ+o+Mr6DiivxVjUZEKW4jc FUf1p2EOBVMbcqBesA17XKYSpXvl+shbrBg+FTQEC8UqNpF/6z5KjUVNFHzjAC4SbYVU /g0j2VN1XrYmUcUdL7S0QO2YtfkEISBXI0MAeBUiHDviFiQq84xzOcDTsHvi7PyAu1/H DKLhmhcLqGosLbQNfqPOHhGEVcnRRp+AfvI/+5ZMzi+W+bLzB7OY8qbjkoYSVGip/2/b DIBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721242887; x=1721847687; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yKGmITPHeBZC/W7CCXq1yfugfxa5MVrGs9L2E2gIK4I=; b=v+zNpffQp5qLYpywxZFmcLDkxeWlcCf+otfo/jF/L0ROhRxbRMpllSgR88NCA4NeCB qe/Jcys8few+Ko+KYGQStyH+Fy/Epi10G0ApyCvRLlHPgQzPhmkItodlNKDXgZe1KTjr LyKI9i9YukByqPvkVSFcX0+/3bAaqA+2s5aUPYPOdY8fmeH0Hl8Cmn02FwgMOFcGLbQh 24LJUv/V/ZHf8CWUgPwdCcOo5ttAbTpnLEyobbOvEo5vVl8BL+nHGZK7TDdidvaI1+Jr Wwu6dphtxDne1UP+H8sbYjjl9qaWVk8qlf7lWnongJDF/s/aMyGfdCH13yA1133q0GB8 zBXA== X-Forwarded-Encrypted: i=1; AJvYcCXbG5b5W1aCw7X//Id18KFxehVGALGuWvDFbeHIm8Ex9QyUqrp7nfaJFugWPn/Be0MgE8Z9lyieAtY4/iXAGrOSj+4= X-Gm-Message-State: AOJu0YzDPFWnQiRmhdzLMPhXPWXIXoRQjUwW/NcGqNLx8Qz5h2y1gP8R M3RHteQ1QSG+5pPSmwWglmwMz1mLOrIZy9804KbOD69Z51tGAC5FL36pztA762TiLvsQwFRqD0F LetbVE91CnwWao9MIWHZcu1ex55M= X-Google-Smtp-Source: AGHT+IGgMLRySBRxDItr4LJwkSAZttCB4F0EnNwbQ6R4S/aKgtby6Df7rUT7pWFyPRvqgvap5KjLn5UiZdUZkdtb34Y= X-Received: by 2002:a05:6830:3981:b0:708:b2c9:1a9e with SMTP id 46e09a7af769-708e3774d43mr3388507a34.12.1721242886693; Wed, 17 Jul 2024 12:01:26 -0700 (PDT) MIME-Version: 1.0 References: <20240706022523.1104080-1-flintglass@gmail.com> In-Reply-To: From: Nhat Pham Date: Wed, 17 Jul 2024 12:01:15 -0700 Message-ID: Subject: Re: [PATCH v2 0/6] mm: zswap: global shrinker fix and proactive shrink To: Yosry Ahmed Cc: Takero Funaki , Johannes Weiner , Chengming Zhou , Jonathan Corbet , Andrew Morton , Domenico Cerasuolo , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: hjc9um63irz7utdorxft8swzfsp3tnbn X-Rspamd-Queue-Id: E1203C0033 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721242887-567940 X-HE-Meta: U2FsdGVkX19ii85XvdpqH+I39M0pERzaQxnKdtnhDIl3uc4mVQTwm+rHla2sXGOix9qydkmNXDm0Er9R+yP1qCy41Jz/1v8dVc0k3eEe1lDj+2wnKFvfDT41fQ7IHN3PPEBG9n3CzzUduiKJ4o9djKxaGkitoUiMUw4pdXxPpilG/oRhdVLDtEL0E1G9ABd9Gh+Yy1riEUABEH5qamMRpAxm7LfK+8NbFK4Y/S4UFA66YDD94R3kH9CHGrrWu2lG1EtDhKL3wZ+Hzs9iyh6Q3/XI0ly7yPiydlu5du8nz5h2368ywZjf9sSkTd6gkWRnUHEEujUNzUmWOApRgGAjFQ0iFF6zcSsRiyNri2e6C6c4CXY7mmYxY813+0t89sZe+TqR9D5hvKOaHqX63MwlGxiZoDOakazs+O+O3jH84qbWUtUJbGB9G0pwvxdj0XDlzK88xciJ5a6WiMTywia7I49lcnuqXgpALfnnDtqCYLSu7fRjv4ILP6m9YDnSYQ2eaEQ2FdvBl8eFjqke2ztI8GjzBFJkgEurEFH5bRH4l/MT8dBjemgzVWdSBUeP7x7nT5NqrZYUx/dyqoSOmUVMYtrgJZVH9RUL6i4Jc0lfcn0Jx7ditY8Y2AAEITrISJouCCcEDEFNfXXGAm+9skG4eLSd+jga5tnhHj10WtS/VHg5VeeDCfv4kQJJY1rO0oU9xch+hjT5vjKvE9DO22OAJn5HR8oHmucOH2kF5av3aypMCg84HYmzjeCyCqzygCINBd1ha4hXq7DMHJczs1TafDADohWgtJjcDOtVioxxL50dx+HBsYqOoDI/y/619slksnXWMyw95YET9G8m5Siyhi9QSojKHqCOKDJMdA5O9oiFfrYYIRPJVI2k/+BjFGgegWBJfNJDJtw2+RyUzqO70m0wOx/L+pzFrStHdF1GDT655jAIOcKPEyAov9XstjVu6jEygHV9PcH2ljoJHSN +h/DB6Tp AJ7lwEvIC4jRifwDmw5a9PMD1y/H1216QOCV6P75Y3mM3xS8bvjBURNgiXNd/wHAJA2438gvAGP7tnhNd6Ct+GAQXvPxPOmxKpvG5d0h0SGBN/ML7uF9bjrwfSq3rdnhxNig5PjUcfy4KpXFK+DvMji4Mhh1QhqHFqJWy55Dcq0+Cdpd+W7FU5FRKc8+Hf7lmf3+bbEkz63c/hudw1A32cP7pZ7plIKuciwm2sdTXQ9M4GZTl1OqZyKSG7lHyB6m6WK0wV9LtMHROCDiT/WPc7KywDg61wZ+0kA8g8z7/+ZdjSHPaOcbTdZ1k7CV3wpqjhUnu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 17, 2024 at 11:05=E2=80=AFAM Yosry Ahmed wrote: > > I have always thought that the shrinker should play this role in one > way or another. Instead of an arbitrary watermark and asynchronous > work, it incrementally pushes the zswap LRU toward disk as reclaim > activity increases. > > Is the point behind proactive shrinking is to reduce the latency in > the reclaim path? Yeah, reducing latency is the one benefit I have in mind :) I don't feel too strongly regarding this though - in fact I'm more biased towards the other shrinker in the first place.