From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEC30CD11DF for ; Tue, 26 Mar 2024 21:04:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 469506B0098; Tue, 26 Mar 2024 17:04:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F1FF6B0099; Tue, 26 Mar 2024 17:04:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 293B76B009A; Tue, 26 Mar 2024 17:04:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1633A6B0098 for ; Tue, 26 Mar 2024 17:04:16 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D1EE880613 for ; Tue, 26 Mar 2024 21:04:15 +0000 (UTC) X-FDA: 81940418070.10.3901E1E Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf02.hostedemail.com (Postfix) with ESMTP id 23BC08000B for ; Tue, 26 Mar 2024 21:04:12 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fyUjCHI9; spf=pass (imf02.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711487053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X3KowE3wVTemf40htHz2gToH1Uj6cubwM/P4kmQ5UvQ=; b=oU55rtStIPD4aJz4E6hqBZWfAbCymRbEQj+im7S1wKCAuiEvrzEhyON2sCpx9iX5NPUCEy OVa3wcuM+0tHSdUDkyd3rZUdL/6Zxf1ZGu7Z96qIZmJAkIAoZCiHvYaLbRUL1jbbvPIDKF /caoaof2KdavEVOcEQsOtwK42Maozto= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711487053; a=rsa-sha256; cv=none; b=ttndxYWrDWGdWqIGonoYedBq6CNKgJ5xNIHYDk9hPfUBPy4CV7m6giI3Qpciz1uh6rN3O1 zQKVJ9aWLoUb+mUB1nEc5raT57cOOrSnaibTunC4TTrdMkM+Yl5vC72Hursut69zl/gEI3 xbFywQBkdlh1AW+rX+pGlXH7VkTp8P8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fyUjCHI9; spf=pass (imf02.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-690bd329df2so32245336d6.2 for ; Tue, 26 Mar 2024 14:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711487052; x=1712091852; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=X3KowE3wVTemf40htHz2gToH1Uj6cubwM/P4kmQ5UvQ=; b=fyUjCHI9jCzi+HZxR3COi+SJmKeuRj2iNftzmq0ZYbabO134mTMRjmJ59HHnw0fp7n lM4pSQRTgGTRJqR+rEyOlL+6gTC5hOeJ29tXqdSCVlHadlbAgoakDERXN2kU/GLQMJNx JBFaq7dqqZLunvQ3Gc0WyCNdNnrVqyQTzIL03556u6msjibvBev3L3dyMJrfjoKRlfmN mLTrlihMQtZO2V8gLwmNbH9ptNqSKxJzkE/vYRK+ZoR12dTkNvJaZ8U7uoDofT6gRI6V vLsjNSijb67Cp29RaLtjSrlCnYJ1gwoWTaI9FkMX+uFbQWJUpO1d1y0OqXUbyMK3A3wW rfYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711487052; x=1712091852; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X3KowE3wVTemf40htHz2gToH1Uj6cubwM/P4kmQ5UvQ=; b=DkPH7xXaoRFQxSWYWrjwJ/iFjpwhN8RVfOjoOUtt7xaLeYRKAd8dwQRDGnZADukQE3 JYZVRvPDfZkBxws20DVrtVT94lyW4iHnGQP9R5v4UEyvEOhbvM6QZG+xOniDbBi3tjTi yngGbbrv4Hwzasi4AjX0tzC/irFptBRhrL8pkXm3VtWy170j//KnnYtkIvtLlpc0+0b8 nqljEdjn/5zMa3XTBsUJIaXSUPkwP2Fo7w0gOZ67WI5fJN733rq1fzhk3QmDjJJpJAuW nBLTZ2DE8hGlc8eIiaqsiyG/V/U1X4V6EXGK5bSKECTe0tnxBVAcLHCpoS2EeKlCws0I +XKA== X-Forwarded-Encrypted: i=1; AJvYcCVJlwRkRAyYydAyeby6z6RixGP1Sachu18ic/tnJoPCUwcIx0D/vTy8LTLZTnu/3xDl5ftYg/4ZGDfAKNvEcsm//jo= X-Gm-Message-State: AOJu0YwPDI4NqH0btCszWbLEs5PIAQ+xzd3mmb+p+EV8iuRiaYjNSd3K QmBqMHvwlmn6nDq1go8T5EYydl5vtpoyLH79sa+8z4ZSpyc+x3YlWEhu+tnQAlbj94vx8R0J9ro 2Lhuvi9HOYgiwEyEV2Y0GTCipUAY= X-Google-Smtp-Source: AGHT+IGnsgsPtHwjQqvvqw0AQo9J2//VlexEtHqsny9L/8THBmfrv+lOtIF8PwVh2VM6oSafEo2/1kpFy1OoHX9Ur9c= X-Received: by 2002:a05:6214:2123:b0:696:3a75:2964 with SMTP id r3-20020a056214212300b006963a752964mr16506992qvc.18.1711487052237; Tue, 26 Mar 2024 14:04:12 -0700 (PDT) MIME-Version: 1.0 References: <20240326-zswap-xarray-v9-1-d2891a65dfc7@kernel.org> In-Reply-To: From: Nhat Pham Date: Tue, 26 Mar 2024 14:04:01 -0700 Message-ID: Subject: Re: [PATCH v9] zswap: replace RB tree with xarray To: Chris Li Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yosry Ahmed , Johannes Weiner , "Matthew Wilcox (Oracle)" , Chengming Zhou , Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 23BC08000B X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: inw1juaqtat15ncu63johmrrda3gzrma X-HE-Tag: 1711487052-534537 X-HE-Meta: U2FsdGVkX1+cIkq67jaYiaQzLWL8m2DwmSFB/qo3MWJodLwDmbPoQ8JjerRPveck2y4zL2NR9A42cR/HfioG3OoX9JeaBtXIfRqkLMDi5ryh1k2uSQ7/c88XqmnlDNHYU1TJeaF7V2+B3Krop9nJaqvlyNAqbf+EbkokneDtYXf5DJEigO25y0IMQ11MFqL5qbNe6XPCUPeZ2590lRxIALqTGlUMBJxqkTZ2xwLX6ydfH8QfM4w6UG3I8m2so4FDC/XP6ewEJ6jQHi7Pzr9SQNb9pch8QBAtdZn2h+Txtj3V3FnMfPDgL6diyZe3oJaTbxfysJkKGJuOO46IJd86H9un1yszWbjfi8tEOXFLTlNXRIgb6sq37dHgjbn7zivdRD1fTav2hI4zXmkSWrBuF/WhDewgESqb/yxHTbZYu+1q7QMSUcvfyekUMExL/nrT4WLwkb/dMKYnSZb0YowWWr+AcYBJtxbUqZgxMrSbwHxvQvmmwGqNAbH6lsjY+5ApP7IlNpLTv5XArNVP/pWkbuj7qW0EWYWSsQOv2H1GIEhsJ+UPjqt3lcDf4yRSTda59DKf0sWynZ8Z0xLqbnIRkdrxpDkuJ8VSyLIFLNAZkETGv6iXPTdf1EgbLFUGfhfxnJlNR56H37cXLyM9kspuVi0XB8kwgF0FE5PphrGR9RGr71aoMC4H7eqe9xK3I6XznZ0GIHkYfgj9Ar3+sOF6qNjDHtjNS9QLJLVp5v+c4cyylEuhmvPPjny7FC+KAgMBHJ/MgjTlhiTrMVQ1unl8OXhH0PoJkQn9vwXjJI+W6NZ3uEbtcVYVVvXAkmdqwk0vsXuape00Tt2jy2WtTNCtKxXkOsoOr7evfFEbR7lo4XKNPGGqyNpjsVsYz9HPwXU7yh4sRoKaCknqEHiiXe/6DxKat85PbUFuTtRAwwmohP2hnBJzaEKsV/VXB2iXAIZyAr7K4jDQFbjeB2DvUvY iXpNxQhH WXCFBuPtA5bgMsmBlhm7BR1vvdgyZ69tfRJ+MDCWOmExYYoPwkaC70AhP1u+46fm4hA6BctReq7lm/zm/ydQ3VGDlrFLMeJcFRdy+8ZeSfc3NGS9Ji6pOkDnfp9CsiLN6ZQSYLKW7bD7loSv7QgBzU7LbENASDn7kcdVTch8M9ht2XASxoo7Vpfvav+NbWYshtjHI8+o7E84xHrU+IsUE45jL6dstCO6Fo0/cowREKTMwAxlge0FdSZpmxsq6qBVZ2OWMEcJAoEGCea0Zi9xrK74zKla2LwGNOoD5nrmFU9fRv9KLX4W7p9J3ZKiy5x9mxnXDGiNtvUxgz5W3ql1acPo06hNLMdYCbhDMRp4nvlz1MucU59lqwDG2ZQBf9isuCjMN6UgrKzUsOVEJ+G27ByJBKTklB549/qCSdSWgVM/O+u2ZS0I6xKgSyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 26, 2024 at 11:42=E2=80=AFAM Chris Li wrote= : > > > - * When reading into the swapcache, invalidate our entry. The > > + * When reading into the swapcache, erase our entry. The > > * swapcache can be the authoritative owner of the page and > > * its mappings, and the pressure that results from having two > > * in-memory copies outweighs any benefits of caching the > > @@ -1649,8 +1581,12 @@ bool zswap_load(struct folio *folio) > > * the fault fails. We remain the primary owner of the entry.) > > */ > > if (swapcache) > > - zswap_rb_erase(&tree->rbroot, entry); > > - spin_unlock(&tree->lock); > > + entry =3D xa_erase(tree, offset); > > + else > > + entry =3D xa_load(tree, offset); > > This is the place I make the modification for the conflict resolution. > It depends on the swapcache to execute xa_erase() or xa_load(). > Obviously, the xa_load() will not delete the entry from the tree. > The conflict resolution itself LGTM. I'll let you and Johannes decide on the comment (but FWIW, the original meaning still holds, so I don't see why we need to fix it). Reviewed-by: Nhat Pham