From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54388CF9C69 for ; Tue, 24 Sep 2024 17:16:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B916C6B009A; Tue, 24 Sep 2024 13:16:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B419A6B009B; Tue, 24 Sep 2024 13:16:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E1136B009E; Tue, 24 Sep 2024 13:16:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7D3946B009A for ; Tue, 24 Sep 2024 13:16:47 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2A8F3120196 for ; Tue, 24 Sep 2024 17:16:47 +0000 (UTC) X-FDA: 82600286454.06.C438E47 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) by imf04.hostedemail.com (Postfix) with ESMTP id 4945F4001E for ; Tue, 24 Sep 2024 17:16:45 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="A6ssue/O"; spf=pass (imf04.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.161.42 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727198087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9UhF3Lpb3Of4bksCfE4JdFE4u99sE7yWYbcYeHYirRo=; b=2JTi7SDmLNQ+iElV5n9pvuspXsGk7fCbOP5C3kKrz6+9mnFIY6JlUv/Tt0M7xQqibMwf7e BWtnwWx7y/dJzGskF4iA8dRmkMcs+wI/8WEb7MQgNsat7RFE6izERhTguNGgS+qqL7LNm0 FFPpF2sjDUmjWZKyp69UHdXK55AvQlE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727198087; a=rsa-sha256; cv=none; b=TpK5atSBJ9GMQ/Nt7GQYUyqJVDpvgzLrg/PrAs5P3s335k8OkURMoSLX2S96DfacAQhd3B nspWdkJ9R56FqgvHgtQbQhC/Wxbkj02dv4pQS4tP0CNiVXFQg0B+dUWN2zHN+yRydJjmfD uWFaIe8DPLYiOzcQWbSR5pxgRSoQJso= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="A6ssue/O"; spf=pass (imf04.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.161.42 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-5e1baf317c7so2201344eaf.2 for ; Tue, 24 Sep 2024 10:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1727198204; x=1727803004; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9UhF3Lpb3Of4bksCfE4JdFE4u99sE7yWYbcYeHYirRo=; b=A6ssue/OCN7WmQwTi4yjUvHVPYZmg0RvuDW4OzjHzK/iD0fcCvlXmmsYYfFeSPYaP9 rguIi94uTo7NAevi7tvdsXMbKQ4UObtLSAk+t3LpQKl/PiwxpXD5Jg330c7SfMShY12v b8l6w3hxfggYhX3q5GsUSlLA+2FW6iTnsOiEP6ze+WoOzkS3L3GcUqbmSe+0WYZAoup0 c51wH2wWgSplsYOpFy9+LmyYzGQsh1rjFYU5ouEo+3GYapDDOtHRotx9JmWCipLNfKG5 L2RkaJNhdPGPLU7FKhpT8d0b9qh6zgeF2pNQSUCTeKAgAzUKdZw5zgU0WYpyCOFZMcSN FnQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727198204; x=1727803004; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9UhF3Lpb3Of4bksCfE4JdFE4u99sE7yWYbcYeHYirRo=; b=VKbCaOUAO0PYK0pJ6nAIe6VBAzVc0VK99ulPRzdviMsPMzwKNvhbNSFEBAGPsXV+qb 8F6nMcRtAic3Fkzk8ITdpwoVDTOHU+z4ePSHVBPdzOyMdU6bgXdRxClFLJYQuJYDA5V+ QB5r/ARmV6X2bw6oNBoaO+Yhmlen1al+8E3iOt/K+SoEaHhwsJkMc95uty7XwfDOlyR8 bDCFrwaee8Zuqhpd8CccVQxjH1RF4T1JkvVR668tqh53vnJrJ2mOwWvPMszXCOIglVhm HVJT1bBFDCR8hUWCUe4GyKRZhvFubofwFlmHrbMM9pPA9qVej/eJ5oVVOaL2hQlJVz+R W45Q== X-Forwarded-Encrypted: i=1; AJvYcCVWQfgpGxO/vEDPNWtKrB5ofc7AE0wWAVYkdZ47Z/vHCdrS6gE+byqIyK5asoJwOXFdy5PJR0Wj/g==@kvack.org X-Gm-Message-State: AOJu0YxQpwm/1jGwTzZKB/gAM90bXbCJLtvKaMX5Yze93/LQ7F6Y5BiN T/88z72NM21jiqnQQYIVaFNRrMjRZhjv06e+KGL1/IDQf6U8n4McM9hp/zFJKI8nohwDxiQStOt Kj1Hc4jlcoupd/+6biPonKOGkBkE= X-Google-Smtp-Source: AGHT+IGWqlR9a/vTU3vt9Wz51UyLVj7bPEk79EiMAdhuZB9DkQZgKDoAP+ZWHaFUa6CHqH4maDsKuR2PeBCPVjGhdXw= X-Received: by 2002:a05:6358:618a:b0:1b5:fa8a:791b with SMTP id e5c5f4694b2df-1bea867ddb4mr20389955d.23.1727198204154; Tue, 24 Sep 2024 10:16:44 -0700 (PDT) MIME-Version: 1.0 References: <20240924011709.7037-1-kanchana.p.sridhar@intel.com> <20240924011709.7037-4-kanchana.p.sridhar@intel.com> In-Reply-To: <20240924011709.7037-4-kanchana.p.sridhar@intel.com> From: Nhat Pham Date: Tue, 24 Sep 2024 10:16:33 -0700 Message-ID: Subject: Re: [PATCH v7 3/8] mm: zswap: Refactor code to store an entry in zswap xarray. To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosryahmed@google.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, shakeel.butt@linux.dev, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, nanhai.zou@intel.com, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4945F4001E X-Stat-Signature: rakg4bpu73gidkkzau814qamz4ctoo34 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727198205-945123 X-HE-Meta: U2FsdGVkX1/doxRdegusE8zhlhdACciv9kfQOgjEiKjQSZwfJFB1mB4I9DcdDDHCdFDZCQF/ggLa+Qd8vPB1vtRWhEIU5iFcwitvWNmOtH3DnrJJhYrInFu6LN1E6EMqWkcwU1R4nTh6H9AYksxvk+HwfEB08jr/Pfgf9qly1jJEUG8yzdNeVfAnPwb0kmvPvL4TLQGrKqatNGLwrbsQIapJdi7iT3iN/E/Rioo1LEeYjvxA7jzkxGGALqc2ooam71umTU4JJYKt8GtH5T+/EXmtw9i2pl9l6YMBzhT3vhPb2+HLMOVkdViIN9R0eyFCG+3SWhXQuq3mHFWuXqFxJdAYfeD6cOMvurpUxBk9QplHzChIi2kCuhZxQSDJRu2ujolfY6H9uhbIt+Ns8k06eSeKTrDQiXBk8LOwirdE9AZMluzY4EHLmRnCC95e81o4PQlx028GC/jxI51fCanu3ECtPrTku2oPR7R2fK2Ud/E7ocdGETtQr1LSJKwIQUC413KtpSV4ZFIhbNLco2tUCbcuLP1v0iggXRpA3odfRQyUSYUr0JBFhw6JLlkGz4Rk0EO/Jw9Fumi3u9Y+aMejfcHJwpvrfOfbDsnGYr+kFVaEO40iNdS/6NMYcb1bI4rFD1Y4H9bIy+BrQYk6C+aTeqfPCCQ69mXeWQb0VoDx9TXoo950cnL6NWWLlme7Zd5qj68xELYqi/w+5b9DsheanSUM0mGBZij0kq6KEKCe1d3SPbqd4AMlXa0r4ZWMzPQ6/cvmixEB6rBAh/uMD2m5bHt0AogMhFc116zTDBZIx2N6xpmMBXF4yUbCRcKpaqBRsinxd5R2WRLQJsQ1QlXPBLNeQuDKUWgbUeFo3Rj/+AAKe/Xh8xoVGlfPp6awSp28fz8RGtWhz6WtS5iUkNXNwQOZRXt/1uiRBgw4+rlNcHTPBAhqFBthJzgqSs0rvzzMWG5VQrY6Bl9aRZFbqyF KRSYKUoK I/aCXmM5Sbhh0CqM+B/ilwD119Er5OEPtmcxxgIQLYrty7tVGNKGU+W1xjImaS+cjLmXiGdlPXfzSSIifBMIqQPXvW1uUhVeUXskSee68TK31CE5zc3QZQHlPUBOf5lrqmu5T0lPhR4bqwOfFXM4yCfk5pl7ev1ypgtj6eUOmrQMEKKLehWFJeLAm5QVKuoz50iPHF8z/c7DrFCHpq3w523d7R4HM83bwWvaT8KK3QDVS4nqCNwUrxq4C9mjL1kjHHqrn2k/4YnrhtGp4WZ1ZkAcooD/6PUKsgWRfYHg5UmCQ09IDG3kuzrN2CdVXyIH605i6uiFfLKlSzCV/XA3/5R3/+wx+A8FLjwAgvH7If1edRJGFwXR578jh+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.126753, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 23, 2024 at 6:17=E2=80=AFPM Kanchana P Sridhar wrote: > > Added a new procedure zswap_store_entry() that refactors the code > currently in zswap_store() to store an entry in the zswap xarray. > This will allow us to call this procedure for each storing the swap > offset of each page in an mTHP in the xarray, as part of zswap_store() > supporting mTHP. > > Also, made a minor edit in the comments for 'struct zswap_entry' to delet= e > the description of the 'value' member that was deleted in commit > 20a5532ffa53d6ecf41ded920a7b0ff9c65a7dcf ("mm: remove code to handle > same filled pages"). nit: This probably should be a separate patch... > > Signed-off-by: Kanchana P Sridhar Otherwise, LGTM :) Reviewed-by: Nhat Pham