From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4D71C27C6E for ; Thu, 13 Jun 2024 16:10:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D96C6B00C5; Thu, 13 Jun 2024 12:10:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3622A6B00C6; Thu, 13 Jun 2024 12:10:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 201AC6B00C7; Thu, 13 Jun 2024 12:10:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id F103F6B00C5 for ; Thu, 13 Jun 2024 12:10:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6E2A61A0254 for ; Thu, 13 Jun 2024 16:10:07 +0000 (UTC) X-FDA: 82226352054.22.FF4FCE1 Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com [209.85.161.44]) by imf12.hostedemail.com (Postfix) with ESMTP id 6D7D340023 for ; Thu, 13 Jun 2024 16:10:05 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AoqC20Y6; spf=pass (imf12.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.161.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718295004; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HzWixo5RmZhsbV2y5X28R62OYc7ao/16u7JRIiYCfE0=; b=Dn68JZcSrszhZPD+dZDuaph+6SuvnNieUDqQZqrJR5QBsBYX6EntGSuJeH4xR/SBrttgrw 3R/xjrZvoBUldggDb5Jy6JTJz3UDid2DsyNmCL/vuGXH5l0M9bxkkq0abZ7E0mvlTIHz8/ QdaEhpCI58UGJCjXmfC39UtbklCaUfU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AoqC20Y6; spf=pass (imf12.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.161.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718295004; a=rsa-sha256; cv=none; b=b82R+y6cjss2kaeAtyeBp/+usyieG0kmXgSUrkDl+j5An/50aspa18eaaEgz/YbQGfRWee KNcWxlYoRZ+noDqLQBzpLrlYQptFPmBATZYwfud9jHuqck4F0v/RbJ9K2qEcLt/RqfILYp s4dNMr/59XApwv4K453y53kQa3T5U2U= Received: by mail-oo1-f44.google.com with SMTP id 006d021491bc7-5b970a97e8eso636193eaf.1 for ; Thu, 13 Jun 2024 09:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718295004; x=1718899804; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HzWixo5RmZhsbV2y5X28R62OYc7ao/16u7JRIiYCfE0=; b=AoqC20Y6Em0Fl8/IX4fcL5hwslFH0x8D806dajhZveZoDRX/9xoqOJoDtZDdHmw/Rm obDyO7As4KdjjAmPk90HXfS1fPr95ZafbUmtANrJYI4fIQ6bJZvkFktz0ZowLY7lU9FH hN2emIrak2eT7mw9ItS60WNM3BkPSe2CTqLw6SZZ+3WVkeagkj6tMuB9aZBZEenwS7VQ p2a9j5WBkD7nL3oWs5Dzx1pQ+psQA2ot8WjmGLbGIs6G7UcNQzbso6GoEn7ejoTeibbk RcU7UJp3smIdbZXATDDSCpCQnkjP4WTBf/+ndhG/hkS5TExoYM1BSlRFD97jWoD2zOOW 5TEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718295004; x=1718899804; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HzWixo5RmZhsbV2y5X28R62OYc7ao/16u7JRIiYCfE0=; b=w1ELLZbDKeXK4SP413aQiyGHNDPOevlYXvz8fqkPdugKffluKKVvAR7wDLemayWC7T z87HR3ZLYj/1QgI+d8jFesWXoZCm+flkMIUZ6fRo59Q3gXrNIvlU0Y4sZD4CSzwVz1nt 3U81yacQ0LEVudMEvZCLvV9pyjuZc7U/FPVUs15NVxgSAH1vLYf1FmC0ljqFapXuUudi 9tFO659pqDQST19od/jd+ctn9bzemyWZZA981ThVIAhPvpTCOs0OiOKkyc7caZW0U9EI HE9RWFZHb2BUwYUy2QlpUohaZM8Om3Kui0DtobSMKups9NRc1sr8WKlzV37PLws7n2nd evXQ== X-Forwarded-Encrypted: i=1; AJvYcCUvSmouvGbzuseSpyVnobLGP7mXcsA4fZrbWBMpISoGOs5FWKxJ3/+Uw0pjWsT5scVO3cUxOrN5fNyfcVqLt0A+/UU= X-Gm-Message-State: AOJu0YwxSsN31Yv1TIXejKE/cHzbgaA2S0BZrUoGa0xwNFYzQu8rl83z ISDUyYL/Aiu6XAuLcXOl4y1UOwH99D+dQRCXobrbRN51djB/LhlCHU6/wTWkZjfGMJSIjpCyHL6 o3m5p0rtpfds8PAtK6NX+zND6lig= X-Google-Smtp-Source: AGHT+IH+Bi6NtcqxsKHAPZncuhjTLy486P0VaxPYnmqtM3swNG6QVuiL2cbPhnJUTmJHKYoMc4gmRe8XDaSOuEkp9z8= X-Received: by 2002:a05:6358:7e86:b0:19f:3fc3:1f8a with SMTP id e5c5f4694b2df-19fb4e6497cmr22960555d.8.1718295004203; Thu, 13 Jun 2024 09:10:04 -0700 (PDT) MIME-Version: 1.0 References: <20240608155316.451600-1-flintglass@gmail.com> <20240608155316.451600-2-flintglass@gmail.com> In-Reply-To: From: Nhat Pham Date: Thu, 13 Jun 2024 09:09:52 -0700 Message-ID: Subject: Re: [PATCH v1 1/3] mm: zswap: fix global shrinker memcg iteration To: Takero Funaki Cc: Johannes Weiner , Yosry Ahmed , Chengming Zhou , Jonathan Corbet , Andrew Morton , Domenico Cerasuolo , linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 9ewsrwmm36ijqsqzjwamaswu4zr9q5z5 X-Rspam-User: X-Rspamd-Queue-Id: 6D7D340023 X-Rspamd-Server: rspam02 X-HE-Tag: 1718295005-525023 X-HE-Meta: U2FsdGVkX18M2MlnVgkF5nlfLlPBONN24okM0figVuQfcbisxxUPcgdPtVhlj9MNkz8/+SrGVxG2mMlqL/Fh0zE8+CnjiDe5yW2Ph1Cm+3eXxfYH4IAb6dQn6RGcxVsVHosystTuZzA1IbCLSUeJs8sCnro8wt5mzaOeSqTqr/jIDzJgr7xPT2PXc+biYrgfHPV2oEwz3Ct4a2heGK1bEjhi2/R7Xt2FVKakyZzRb8Y0yuqPFUwLQpk+XuYWjKyBFnRQHvVL8p+fDP/t6yij2YYOsLV1V17RjLRgcIk3dVBRXrtkUDSrle92Lure1hOL4haGuZ9ezLvxzWP9eyZTPpPuELWJ6lE3dLNGfZ2y//xR6e29677adA6heQJXCeD+K9x/nOugI9MzV66rhz8Oe/eqFSkyHKMyhMRF0A3vaX5Z0WfXNakA6YjxMo/BihakOz35p732ixEaQUDQ26zZAF56wI3zZkCWVADHZvTjI4jkzewPkAYS32kkjJ3RKl0nR0+7sPfHuAt4eaWmTKxBCMYzdW5ObSHD5g4w8suapyFdgqX6uwsnEebArzjPrclNtakLf2LvZf4gOztrtPqo1ca1ruwSntg+ipE4qA1FTXMUH8suGYaQDeaLxzXD/28vyNc+zNNE2fJl7WsXJ4N29ViOFaTJYJvBVyVtkV6xx/7U4wUinDspKz2VrxGJSWwEt80kp8pOzYbszSC+1hufsUdAc2xBn0XhsLl3T9YNVMdUPL7C/Jl7S/ZvILSTg4dNUlC/uieCIaEOgfEfEBYZG4h1W85/SEB5IJTP06aWr6lBRG1wXGRl4awkRlc1ppEVNuntbl9IscxKn1xgO2Qw1TReagDSYZHG6bpudhgsiC/LfHNXLQFQsxnnh64IdAJ9I7jXDVNSmbe53K0CC4xbIbIABTupzqudi3XOH2eCzpQBh1Mu+pU5kPGohAFG6WFXay6CAmYR3NeaDGNBLKE EHwZ3EVo 9sUEBV0+LK25jvlKnd/ivstp4Ca3uTR6TA8pXf750tCnZT6q7tcYGRHzu18xpXduR6ZvUih1JNPY0HmLq7lyNJ8Ue4iuBRbDAQtKHT9n6vzs8c3ZqIxivjvCnI21hEC7sFUBIphxd7+whGIQ8AAgbN8cyckrsip0KyCg+BcN5LCRIp3+V3dRItfjTKey3BwpHlq2DIqnrivA69MC+HMY7nDZHqID9ntEwWyr8TlTAJpWaOxijaENA9H9InmvndWugg8f3SRQyjTiydo/6y286N6yeAm/XA2bny/3P+917z6wPR6SlrVtgrulws/NaKtyK3CuIL+PhRWnnLamAB6IDt1NlpWwCeUUR+ZnFzqJrUmxRT4Gah4c3cVN06g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.020684, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 9:08=E2=80=AFAM Nhat Pham wrote= : > > 5. At the end of the inner loop, the selected memcg is known to not > have its cleaner started yet (since it is online with zswap_pools_lock > held). Our selection will undo the cleaner and hold the memcg hostage > forever. /s/will undo/will not undo My apologies - English is hard :)