From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ECB2C5B543 for ; Wed, 4 Jun 2025 17:56:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A66EF6B0099; Wed, 4 Jun 2025 13:56:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A179A6B009B; Wed, 4 Jun 2025 13:56:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 906436B009E; Wed, 4 Jun 2025 13:56:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6B2FB6B0099 for ; Wed, 4 Jun 2025 13:56:13 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1A68D58FB9 for ; Wed, 4 Jun 2025 17:56:13 +0000 (UTC) X-FDA: 83518472226.07.73775DA Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf24.hostedemail.com (Postfix) with ESMTP id 38625180009 for ; Wed, 4 Jun 2025 17:56:11 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IfDEjwu5; spf=pass (imf24.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749059771; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gnvEKTcmmLwrMRljEPpuN+GEAVNuq2EmP2jnZ/w/9S8=; b=5yvKMyFC7HRgJNA6E+IpsBITAA01uDv8hJCCTfWhbp8V/MLSr+p9nD3Wq++QRbwbsYrRPg PaAS5kbBfWSsEqAQ9g1Wmn23ExYMcek3gbL04a+Px5ak7eaVM9Qk6eg5zCXS/u4aH5y5AN dPNAYL9dme11eiOJANNxPC85bEXQCks= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IfDEjwu5; spf=pass (imf24.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749059771; a=rsa-sha256; cv=none; b=KM/yEJwsKyGQ+G3pR9VhMiTl9X8dkd5cCfS2Al1BtRNyIghprqwdaczyFss1UF+7RyXl1w AFc8tYwNV7TiAeQQ1LcydKd1CocPL4XYMGAjlVj1MKnkv0elyrmG0n8oypiq0q8EWT3yO+ pDjYPEWKTndjXNahfibkfKqh2+85gXc= Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6f8a87f0c0fso2443726d6.0 for ; Wed, 04 Jun 2025 10:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749059770; x=1749664570; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gnvEKTcmmLwrMRljEPpuN+GEAVNuq2EmP2jnZ/w/9S8=; b=IfDEjwu5wxQvqNOcYveOINJAEv/ZdgAFXZJtZyxdXNr/KqLxqDHf2EvNcX+dTkWQHE Xdybn11ENyS8yu/yLy4gcllo6qkpQPPu2Ibx9P8C9pmv7EdS9wMiQ0RkrRc5SC7Pxhuj SefsYWS1DqLCLXYlCvZm/DvKc2JQobIadaA3ramkxPT8hfMPjNrtdYmbXwtRnKGSoFjK 8NKKHmMtC2JJpjUhms7VEWto+4K0KwpugMyoOHKVXuNyX8rm1xblrmfqtKwfdbNMw47v Zj0iG27u8jXXYuLKuiO4LWPWIYUu6eyhicqM8zv7H/3lEBEK5cm55Yxe1Dje5XWqPu66 fk4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749059770; x=1749664570; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gnvEKTcmmLwrMRljEPpuN+GEAVNuq2EmP2jnZ/w/9S8=; b=lHNOtSwsqnOCyRHWgxvL9Qc6j+cjfEfcaPPAuLF+XHSDOHL+5oyASJMkwjI6bm52nG HhkhVrIsom04nanF9Oh99Vz0KZPoctnP+Lzh0PZw7ieSaOHuXVF6jZxUQsyNAatgoedX 5h5X1ELCWH1cBsphu9cp7NcT3VsC1gxQiEBFaHR86PcgVp052CmG+QGX75qCz2srMLld 496daa2fzAir948CwKeoD30fdTob1uTX+gZSEvkgGxmSSgNniJwP1lVuya6pJACQ+Pqv qmVM0C+6NDr3Bs2wSUDJI/UT8VpXjXV6IzFENsX2tfn9xvGBAbKqzYZmKCeM/4jJd8Tw qCRw== X-Forwarded-Encrypted: i=1; AJvYcCWxL8W9ZWismJTyCMbqSvUckVrtjhukp2FXXOVJJSGTn/me5DKsJi5SbmpVOk00Xhrb37a9xhihRQ==@kvack.org X-Gm-Message-State: AOJu0YzYVE9Hm6ZY2YuN6TLirbHsW4mVpPwS8YUGnHa26IYskWwq3ePL pKAFtc4CYxAq8Zf2qH0LavcsrdFTlEPNP+EG2L4faotEWKtKYYREnFveAmGeIiyFVpZj7E+GkvI i5ih0DeLPvc79xBHLy8SmPm4a2aYmdAE= X-Gm-Gg: ASbGncub/9f9NngRzlqc87iOQrLLurtSmcUsL6rTMjT1YFuvE6r/C1buRKtn0KVnHMb KWE05yDKA2I6zMMi2h/XiXt8yi5uckJoU92sZG8yY8m/2GsPoZfNqh70MKmUSwskal8NLqIVpTx ZCWfLwTxfDn1ZsxgZ+N7Hw/QQcBDJn03HAKw== X-Google-Smtp-Source: AGHT+IHgPYUhO6aBFmp/KGRv6pAgLdkGthbSxhqN+51/VWLbrFeRdK6jUDS8WlqrwQbaAL5J6gzzwUPAhrVoQpkLbqw= X-Received: by 2002:a05:6214:242e:b0:6e8:fbb7:6764 with SMTP id 6a1803df08f44-6faf6fe41aemr57817946d6.45.1749059769696; Wed, 04 Jun 2025 10:56:09 -0700 (PDT) MIME-Version: 1.0 References: <20250524083618.29615-1-suresh.k.chandrappa@gmail.com> In-Reply-To: <20250524083618.29615-1-suresh.k.chandrappa@gmail.com> From: Nhat Pham Date: Wed, 4 Jun 2025 10:55:58 -0700 X-Gm-Features: AX0GCFtcpSexHVVUqZ5FfuA5ekkM5E7Wr5rglkeeWBhvyX4PPBqfBC5CRQilNqg Message-ID: Subject: Re: [PATCH] selftests: cachestat: add tests for mmap and /proc/cpuinfo To: Suresh K C Cc: hannes@cmpxchg.org, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 38625180009 X-Stat-Signature: g3xchepwtm1cyddcbdgbe9p5uzhph5ty X-Rspam-User: X-HE-Tag: 1749059771-485994 X-HE-Meta: U2FsdGVkX190LMCPBSGIvmc4651Mtx1cinUoIuebW85T6eWxP4uimmt2lSiQIMA7SJD5FonzOIYuoPwljBpsm1vPrZv8bup+NNjl+pyZ334mBtEgzfNfGAfTcnbPpH6edaIVFWWvDFuxjD2GvOY06zgZxC5LrXYfn/PGnR1WT/a3e1GbXjZxIEEpiBhABAnFFGlAIPwkhlwifLJVvGDq9z1K8KS4TZHB3wbJ6WXgbDVgBt9t5FtKtnq8VRXHskAxvq4K9NvpmmS53vQ+3kjDCJTIYocofEEng/RnMuRChguD1Eua0h6FHhsajNgsZvHvXqrsl0VQnu2e6yz6mGDeYuXWyaB7YTkzefHzKiv6ptmVvnhOCRFR3xZjROI6mgyk1o/DWoytv2cHKb+qCj+BDb1Oh7JEKnpVrfFLUnb6CeFlNLypcrqLxvQfv6EsIfpFoUW6sG49fqLrsoi+jBnEhFV/nb4DBdmjkZ0u6vEDCafU14DECrCrwdExvxgpTeota45ABka0PI/6jbXZk8TcFec5618hqZtfFXK9No5mrogJC9k+pi2Hx5FUyPXXD5hI0D+ghT7eLzKbNP7niad5CaPZnNoePBZuNHqXBXrO6InLOaqFg9+mmnVrPNRzjlcLL80A5s+YzgZfbq2E1qZxMaHfxLyNC0V3OU3UDb3wlibEPJjhv+BK6iMN09PUmobXsZ53xSVmv8XWnDay1u7OexN0dM5ZYptdR58q+Eu1GSxdeVTX3ttZUTEqc4p+jf2TgDkNh1DdwmiJzlpIp0fknVl2R14I/fGXIcgc4ZlZE6Gg8bigFjJH4m3p0W8QpBQG42HNf+xm25FYhJb+Xs/1TSgBllR5YhBSsqKvU+Ecu70cybFVQkAUaTpNYGgBPxRTBqoghImtRg9kflvwGZWhWJ+0GNpLbAlW0DVf7INWaIm7mlQOQd/QIDxt0DJyXusuq6rJhAClJQZaaE9gKJ4 +thKoxas 06uckZgMG4ns6MWBoErodtjXck4bVQhgBfuhDZZ9GxOtIF21lzxCBwB9mNra5uzFkEZMRjjv3R01Li2PC4Ymcuw9X9gtrI81QdT2x06nuNt2+n+U01bXrp1BJfBAEZHhhtvDDoxycPt8cJKagd4jr55XvxNr3fmisWXMIAc5Q+cc3dHtFONIK25jJmV29/aMaY79Uf9lWtuEyhnj66CBwyODkh/4skjMNCj+xi/xA0IaBWGgy1Bfh/ynjHgnz8Rnsg1fkfsIwHfHjUvaCaBYAibeBT2RWc0j+/HhBPEi8wWnhAM/KglnPW//7bEn1tQavY+AAh9ukSlxELNA+xRDkzBqUu4aIi78ouXV3J7oZJfAdJu4X3oSwrkfrio/j3cHTiQ3fNoUc1aMifaNitgAC7XdLgUon5PjeXvFR//3oQMiVXCR/7X6jdswz3BM8dbwzIpV/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, May 24, 2025 at 1:36=E2=80=AFAM Suresh K C wrote: > > From: Suresh K C > > Add a test case to verify cachestat behavior with memory-mapped files > using mmap(). This ensures that pages accessed via mmap are correctly > accounted for in the page cache. > > Also add a test for /proc/cpuinfo to validate cachestat's handling of > virtual files in pseudo-filesystems. This improves test coverage for Hmm, it's been awhile since I wrote these tests, but isn't there already a test for /proc/* files? > edge cases involving non-regular files. > > Tested on x86_64 with default kernel config. > > Signed-off-by: Suresh K C > --- > .../selftests/cachestat/test_cachestat.c | 69 ++++++++++++++++++- > 1 file changed, 67 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/cachestat/test_cachestat.c b/tools/t= esting/selftests/cachestat/test_cachestat.c > index 632ab44737ec..81e7f6dd2279 100644 > --- a/tools/testing/selftests/cachestat/test_cachestat.c > +++ b/tools/testing/selftests/cachestat/test_cachestat.c > @@ -22,7 +22,7 @@ > > static const char * const dev_files[] =3D { > "/dev/zero", "/dev/null", "/dev/urandom", > - "/proc/version", "/proc" > + "/proc/version","/proc/cpuinfo","/proc" > }; > > void print_cachestat(struct cachestat *cs) > @@ -202,6 +202,65 @@ static int test_cachestat(const char *filename, bool= write_random, bool create, > return ret; > } > > +bool test_cachestat_mmap(void){ > + > + size_t PS =3D sysconf(_SC_PAGESIZE); > + size_t filesize =3D PS * 512 * 2;; > + int syscall_ret; > + size_t compute_len =3D PS * 512; > + struct cachestat_range cs_range =3D { PS, compute_len }; > + char *filename =3D "tmpshmcstat"; > + unsigned long num_pages =3D compute_len / PS; > + struct cachestat cs; > + bool ret =3D true; > + int fd =3D open(filename, O_RDWR | O_CREAT | O_TRUNC, 0666); > + if (fd < 0) { > + ksft_print_msg("Unable to create mmap file.\n"); > + ret =3D false; > + goto out; > + } > + if (ftruncate(fd, filesize)) { > + ksft_print_msg("Unable to truncate mmap file.\n"); > + ret =3D false; > + goto close_fd; > + } > + if (!write_exactly(fd, filesize)) { > + ksft_print_msg("Unable to write to mmap file.\n"); > + ret =3D false; > + goto close_fd; > + } > + char *map =3D mmap(NULL, filesize, PROT_READ | PROT_WRITE, MAP_SH= ARED, fd, 0); > + if (map =3D=3D MAP_FAILED) { > + ksft_print_msg("mmap failed.\n"); > + ret =3D false; > + goto close_fd; > + } > + > + for (int i =3D 0; i < filesize; i++) { > + map[i] =3D 'A'; > + } > + map[filesize - 1] =3D 'X'; > + > + syscall_ret =3D syscall(__NR_cachestat, fd, &cs_range, &cs, 0); > + > + if (syscall_ret) { > + ksft_print_msg("Cachestat returned non-zero.\n"); > + ret =3D false; > + } else { > + print_cachestat(&cs); > + if (cs.nr_cache + cs.nr_evicted !=3D num_pages) { > + ksft_print_msg("Total number of cached and evicte= d pages is off.\n"); > + ret =3D false; > + } > + } > + > +close_fd: > + close(fd); > + unlink(filename); > +out: > + return ret; > +} > + This looks 90% the same as another test. Are we literally just adding the mmap step to test_cachestat and call it a new test? Can we at least refactor things?