From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 764F5E7717F for ; Sat, 14 Dec 2024 01:29:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2F126B007B; Fri, 13 Dec 2024 20:29:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BDECE6B0082; Fri, 13 Dec 2024 20:29:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7F3A6B0083; Fri, 13 Dec 2024 20:29:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8AB1B6B007B for ; Fri, 13 Dec 2024 20:29:10 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 2BEC9C137D for ; Sat, 14 Dec 2024 01:29:10 +0000 (UTC) X-FDA: 82891830378.21.880AA0A Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf24.hostedemail.com (Postfix) with ESMTP id ECAD6180004 for ; Sat, 14 Dec 2024 01:29:04 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LoGaUARA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734139735; a=rsa-sha256; cv=none; b=KpEkfyyWmhjugUXNsK6v+Vs4XvoPTopANEDhjSvnfRBdHk6ftuXN+2Li58XHdzA7uTYvO3 OXtmz1JMsFIyPTELPrI8oLcqGTHMzBXefRv1tMcNCP2VzW7QiToVCFIAGIfjyG+MSNfWEL 7Pa6Zo6W9I0sOTs2LJjf1TJq66UJ7+o= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LoGaUARA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734139735; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vVAJG9syhr12rxWNm3fuV8weZg9JIYCn4ySR7qnbiaw=; b=IDKGMhYTWSyi6pH+pf+qdEW13TSh4GqmxdANwePv6GufY8sTjovoTWdtbR2PoDgaXelGgK UO+Jy5/U+q3hdwt4qQHV3Qh+HFBhG/VGPnQ5gbWDaXPTtip1ggFrGe5zfcYZRYoBhihpvA FddshBw1HDITEJ1drZPxvwyIwt0+IRE= Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-6dccccd429eso3349446d6.3 for ; Fri, 13 Dec 2024 17:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734139747; x=1734744547; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vVAJG9syhr12rxWNm3fuV8weZg9JIYCn4ySR7qnbiaw=; b=LoGaUARAbCVtG6ilIyQgokawvPR/nHGX79b2IxEbV4qoHDPdgXgbnb72TGih3L+Wwc piYOF3fUGboBqloE4q1/swqkPHU44+Sai5XKx2YreBWnOmC8e1hXrk2Vf9xOUlJdU+6T jOIlb2Z7lffSBj/zmmWGGkF0quLlrPu90HryYn0fjOEBz/aL7oYOdno6F3q5AqRHBEiI 1Wx08llPFXd4RMBl6j1VWYF7Cy5nGgZ+ApllAeNFoF3Qiz+QYThAUnlmTZ+7bMaapjqt nFFk8TljiKEAHIyXQIEL/hfUBzcYl9E8fgKrlcSsz+p0mW4DQMb3qH+jcIlSolEgOubl qmgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734139747; x=1734744547; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vVAJG9syhr12rxWNm3fuV8weZg9JIYCn4ySR7qnbiaw=; b=TSJSZvef3uJEHhANcywNbisER2fCvpojTmlLap/Dq9t1PYfaWrDy0q+Vqu9Geobctt S/swzyzs18gFmvdfOjEATF5r19AbT+aBsJ/d8XwEEdlXuRaxwKJJgtC3wYElVntP8sCQ EOc/3OeumKJSNGkxKJCqD4MVBlf8KRxD0dqSpnVned8Vbfaxs7ks88H9w7IG5A4Bj4kB knVqRdP/NwGLoGCWluxHNd8h0PCt9x9uSEr/6yQ6AguPE+4rXGl8Md+030FEQKaeTOPD tE8m0gjkATGcofiUMj5EJOlDRCVPQNBZB8Ufn4wEMcSzol++/3YqQcHGzKnEQqnGiTaB t4gg== X-Forwarded-Encrypted: i=1; AJvYcCWWQuQgPTCKFXMjgREoJV31gfgQqCLtoLO2ynpxCq58Ab5gBT8z0vllvIn1vE8EpjziGkN4d451sg==@kvack.org X-Gm-Message-State: AOJu0YxK3osfEPYC6VR8uI5pCRtEpfWEoJ+pQa1wdQq8zevV5EMZ2mRQ ovOPAUAvmmDVAM46uqINs1HjYAPBKprNGTMCd5oSOUvPoofmbqrVEtXqs0ozlspjEC+IKi9qL6e bM3ofB4JvRDPYJo+efb+HvwMSY7s= X-Gm-Gg: ASbGnctOIKM2UAAndbYlMhknJuaOaqeNfKlXAtzlZoTZyDtr/OGdH6HE5rnulHcnY0I tMqxG2NmzkrshUudEQgC6LtT8N/1S6MvRz0Cf4MSyx/ezE1e6dsT5 X-Google-Smtp-Source: AGHT+IFop/B49xJob0yTKWaxWZwzZX4K1rQCDUsZXhIyVoxAwHJLe4JFZQPnFuo3pRMZFIbSjgT09/+rmGaWLPwrDdI= X-Received: by 2002:a05:6214:4002:b0:6d4:3593:2def with SMTP id 6a1803df08f44-6dc8ca3e6f1mr89817696d6.5.1734139747204; Fri, 13 Dec 2024 17:29:07 -0800 (PST) MIME-Version: 1.0 References: <20241211203951.764733-1-joshua.hahnjy@gmail.com> <20241211203951.764733-2-joshua.hahnjy@gmail.com> In-Reply-To: <20241211203951.764733-2-joshua.hahnjy@gmail.com> From: Nhat Pham Date: Fri, 13 Dec 2024 17:28:56 -0800 Message-ID: Subject: Re: [v3 PATCH 1/3] memcg/hugetlb: Introduce memcg_accounts_hugetlb To: Joshua Hahn Cc: shakeel.butt@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, sj@kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: ECAD6180004 X-Stat-Signature: b4ujcxw3wwrq7aijoi53ynjypp5x586q X-HE-Tag: 1734139744-265455 X-HE-Meta: U2FsdGVkX1+SRdZdKnQrwCEE0bnlXkUOgBrKCJDICgF8vrOSWAYwFWuZTXLvEybdic2qBzkKtggDLWbeeAwGJtsNv9Qu3o50Wkfanu4UZ3sEoIrxZ2uvPnv3nKK5Dm14mZa57pApSKM8+h086iscGgd80XF3EirnZORr1B7qfpC8Kkb9GK3IWhkfxXwGuXi58wdxepe7pvVStWSjJWsasbINk35u3lAqsfV6ZP0B6DjfB/G5SrWYdc/CcE6owGFoLOqlVt1UkgX2jhtAJFgoKmC5fsWkJhbjfUUbRgU5bX498bWLpxErVgfOwVD05m20g+Aazt+OX40LqOwLZ9vD+JK4W52dz4dPrObmzigM0w347bRIw0f4PxD+2wDpihbgAT0iPpiFP3Q1P3CdXBUuMDKz3Xpjf9M5/++ZAJ2GHUAquuLBeHOlfsvnkp+37tLWgcr3Ek/SYoy4bOcjpqDtPszOJp/JgzIsjnQibT4uBau5N7NFHqt8/yAkYGhXqfnKKRj2H1L/lrso8HCHHlzhUgegqQFjY0k+QrUkAibDkc29SbklFaez5vlVYQgqIf0EImwyXPQOZwpTEJaZZ0hY3Gs0u6H0PehHeDNHwI9bHo/8vcbzpLA1QRUpoyKhtQ4z4ehX2rg8B+sgtzCInKbHjWTKMSJ+SrTrTJdqmtDVlYydwzlB+AkQ72FiUIF0WVwik+rfrw5VrRpZN2D5nzv8RJY/M875T3+0rxnHcHqwko+2/bLYBmHYjSWK96mYlb6S3C16lLcCLTfVvn1juXOcvWtYgm8/j9PALvfJZ0Zb/WihdgU+MscKF87p4Ij8biA5SyyNIZrnZkrPRn2Kbe/YSsADwqk8MMCuI+lN2qnk2XeiBdui46XgH0IQfMOcEw+4t3O6TjbAyqp4srviSI4vSOKPTknzPAmvtyA00+Thaz+hHFN1BHqBus3jHtlXfFVHwInsHpCU6NU17NwRHYb 1HyKuyLr OiD9dpJLPxYLHnwU4M7DBlW0wk1NfxeySAfHoNL98+is4pu/nem/AYcOcz3/BnLymzy5J0MpirsRzwvKFw2w74q9BykUdcP0FKrLLXtjuRWEeTATA4yq2tLnuvWv3//kl1N4h/vXjkgYIkPC20IDsgDzF901I/cSvN1FMUJxG0BPPXaMQNBlXb8IV6KR+veCMdyO7+64WOxCH7deNnJeSXZeDqIm1i7lbevf3Wys5kGIWbJnLfryPSUbmgbVY18Q+EhTrFPbaDlWddVG5YNtoVBFXLwjuKemPOVzWFlpj37H4XU8fpN+IdtJ04AFCVSnAx7A0fvyDoVrh1zhCtkl1DN8Krofv8yovYm7Cx27YdjXzr9wTSgP7dlexzH37CYgzgXuqltauCktG/87T6yLhosJvZNoSCT8xSLD9tVdEuea/BuZaneuXu5XIkMV9Z+DgMLwJZrSX0A7T5vI= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.499940, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 11, 2024 at 12:40=E2=80=AFPM Joshua Hahn wrote: > > This patch isolates the check for whether memcg accounts hugetlb. > This condition can only be true if the memcg mount option > memory_hugetlb_accounting is on, which includes hugetlb usage > in memory.current. > > Signed-off-by: Joshua Hahn > LGTM FWIW :) Reviewed-by: Nhat Pham