From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A494DE77180 for ; Sat, 14 Dec 2024 01:29:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D1CD6B0083; Fri, 13 Dec 2024 20:29:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1823C6B0085; Fri, 13 Dec 2024 20:29:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0466D6B0088; Fri, 13 Dec 2024 20:29:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D719B6B0083 for ; Fri, 13 Dec 2024 20:29:15 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8C2321613A6 for ; Sat, 14 Dec 2024 01:29:15 +0000 (UTC) X-FDA: 82891830966.04.E51F156 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by imf18.hostedemail.com (Postfix) with ESMTP id E07C01C000A for ; Sat, 14 Dec 2024 01:29:01 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UhbwJH7f; spf=pass (imf18.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734139729; a=rsa-sha256; cv=none; b=OpbsMZbJYzLJMF362blN4BMD88LKXH/elZPe1+ZCnEfsy0joWXkuXchzf9ldpns5A61ZLr f7bS7yGnQd9++Rl8iqt+wra7w7ky2PyX0Zk3dY/mdQ7WQq/16VuEkt9pD/MhKOwUL/PzLA EiVOOv3vEaeWNcXcRFBzKAcDJIwR7Sc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UhbwJH7f; spf=pass (imf18.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.44 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734139729; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4hUscQBSwRRYt9kBF/p96Az2eXar5FNycHLbwe+vqno=; b=fnls1XB8lEtXx+15UiAaLzKmTfR8zoautiODCPC1/Mz36r73GH1+BEAib7Yqi7KmPtdVos J3auKVxIRTZ3avkatNI48nvC2bu2cSxe35WXpxOlxhJEPY/C1nl2UhVKuL0622J//sGHwg OO3WBQEJ0Y49uygeSAZxkO8QfZiPqtM= Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-6d8878ec049so23979166d6.3 for ; Fri, 13 Dec 2024 17:29:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734139753; x=1734744553; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4hUscQBSwRRYt9kBF/p96Az2eXar5FNycHLbwe+vqno=; b=UhbwJH7f/hBYwsdZ7nax8hvY7rmgPVM7TAgDQ1IrPEEz7ark+pzH02298Uj1pIkIE2 ccRUS7pNaK3ti6SUxI8dN3Oh8mAgVnHCRYDah9RhVpNiwuUpiXPFOD4sBwbGk1j1Od8x wBWefIyTt5GQMv7qAufonGlPSqfSNws7krnChfsTuXi4BCxsgc9Gp2Yc6WTB0t9D26xZ huzsmp6ePYDhO6+COujbF4nTVoVwiWtdKIRVm/Wk+G+HGzpE1pPoGkWZAGfEYOpxKea0 HvpNbGXo16Ami7ZXbdCcWAf4nanqHkhel319pXkaQiD7Qk9p4+AUWTRFEBaswgNRM0h1 Db4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734139753; x=1734744553; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4hUscQBSwRRYt9kBF/p96Az2eXar5FNycHLbwe+vqno=; b=d5qtEAfF/y/iPbrT2PU68QrE0IuyuKWRhzVgu4LwVa7LxGvQkAWU5fY/xlYr5NN2RV 2mkvQ2AfS0OG5ko/q/D4GEZjkHpcZvJojhbjpiKN5bFEG59FnXjSKsOh/6Gnr3xt+Evj 4Lqb+TbJl4CalB2RD+IWaxaAJz+Cw7tU7vcj3jwsWFeDdO8oMbyuseVdBrjqcGU5PsdF y+eemVoPkHsB2/Qq/cLXk2+H2JPMHFhg1lkXu0GWSx9UJ3xjTsKe7nGZJgDgi8hlu9cg PSJfQOcT/Q0j7hhooWQraRlHih7vmDIrPp+YuslXJbbdnFVeXcWgJv2SCEoM485hf/4m JMQQ== X-Forwarded-Encrypted: i=1; AJvYcCWqmWCY8XWVc0iDvgEcTYST4WUOr7yFNrlBbmIm4LWLlmWS4Ejj1Tq8UFm5jvc9rtcuF8gSJ7MJHw==@kvack.org X-Gm-Message-State: AOJu0YxWWJ+aTi+ToM0AoD0FIBa1nXpHN8Hxs2wzocWsqoe9d8NLAq1B R0Te47gcVrCB/YFgDub9zUZdqdF7bdi2mvd5+XwFxpfgrOQ+38dIjYD3ISlSbvvjVY7MXJjXj+9 N4DLE3B2Em2UU/cZux4svC9EeJBM= X-Gm-Gg: ASbGncstbZcjEYcf00MBg+ZBV55vmOJUmlB0QEdVeDjx+GkVySZYbm/KJ27W37AxvMB xGE0ZjAkwP5HBxE90jPgCfMZlH382n5tpfoBOXHtDvxPU7/x57gIx X-Google-Smtp-Source: AGHT+IF2SkaokBCI7EQwZihdLkI9OJeDhfOmaAq6AzuJ9bGEHqNuMr+sYNVN4956xebsUPf0Z+xplVm4s8RCkQPk6ME= X-Received: by 2002:a05:6214:2a84:b0:6d8:861f:add0 with SMTP id 6a1803df08f44-6dc96838d5fmr84769006d6.31.1734139752893; Fri, 13 Dec 2024 17:29:12 -0800 (PST) MIME-Version: 1.0 References: <20241211203951.764733-1-joshua.hahnjy@gmail.com> <20241211203951.764733-3-joshua.hahnjy@gmail.com> In-Reply-To: <20241211203951.764733-3-joshua.hahnjy@gmail.com> From: Nhat Pham Date: Fri, 13 Dec 2024 17:29:02 -0800 Message-ID: Subject: Re: [v3 PATCH 2/3] memcg/hugetlb: Introduce mem_cgroup_charge_hugetlb To: Joshua Hahn Cc: shakeel.butt@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, sj@kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E07C01C000A X-Stat-Signature: hwmd3sirnqkouwhu5ebog4niz65kzkgz X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1734139741-934956 X-HE-Meta: U2FsdGVkX194Ga5j8F0FprpFmod1Axp57ReiisarotOHyO8wEQ8PTutfaq8pAZap2PxH9zhwuVEBd3PiIbOaOsaei99MDbeOPWgzrQ2uvh2hvlYoD3fVLSrbSt8tjM11Aeoh1g1sf56mcddgAsB5u7yi9SMn5vndxoDCciWhoUPV0DAbtabFZ9CH13v3uOF0O0RKTt6UhyCRfhyOHKN+e4fUTwjBCa64YG92dXjA9QmjQ0IRZJxMSNxmvM9uIWncwEJpujQoYY8i7YTmeSYVMSe+rif/rJfZ3/iKGYMc++/mrn68xWwtlFukm/rpjXJXtoknctNeVZIFgvW+/Z3nvSHU9jWRSXAhzVutfEEBm8TBv0wP9iDrnlI4ALE4z0IFKo8WZ/NRN5JVbNMAWtqbYqSAe6zcjQ7MnzIh7Tuyncd04Qa8MoMLwRpNnNstnJ4xLXye3lIo3VcfvfjogffFOGXqtokE0s+Vt9Yf7YAyuGCEJexfvLWf5Bu+Th4WF8Lmki9jVRJA+apKWFf+NaVCzp3UhqjAM9HoXAOvR4pQVH2CQj0Ic5IQmsEHGpiaHNssvPTZowyGIml3SuNWvORUlzBQe6ZLY+xZQdR7lhi67NDyETVgYyk2RRGo3WcKsxz/J8+yr4Q5DanbPtny9vKKOGUUBsytHQpsN2HgSd58rP1pmJcAPp2xJwHZn8V+Bx3GsJ2pHdVjAeyQWjk5vp36OB142q6Bfqjbm6jslp+ZgX/WhNmMtzBngm1Q0CskxICCWic2KhyaKuU7Z6Wgiq5iPVDFXTOFhBLjpHyFluxjX9u2sUhMiB10ULaLA4GMHx3oa710Y94ogEPUS7OcEANcNi4AwpnvvfOW//4TX8rkMSYgyzTUvsS41gNZPdNv0I1BKCBrQ6szdODuqORY7R9oLxJidrvERsOKzqZv8IFN18Bu2DGWWrgaOwytcQ826DcktIhO3+yhoZxUp81QzOP Vb6e40QB O7ETU08o6W7VM0at9DIrHyW7bXJA7PGaFKhkeMt4jeq0K6ab5ST0uo2J1c/oA1OfMlFJOdecMBSnz8gjcmxyuCOBqrZ+7qRsnQEREgBE+UsUMvHxodyvouCmfh+h8InwLNrMj5j908IWpWnii8xvLqZMg2pp9LoyK5RHHRLETUwJy07uN5emNxTEi2S5l10R+SyJqXBFdjsCy4BC6v1g/5TNJQt2+XAp9oCNSL9g8/oGQJJyFG6KuT50ZqjRaVqJkoifpT1Yy7s9yXZEBSLWhBV1YBjrGGkxDtvxOLp8d47gnpL9k6z6eoxfFmdMyJze46oH9izF3rXL7/p16OvaiClCbkCcHt+jCXE82cbQFpMY9aaKSSTr59v2Ty2ekLH9Fidh0EGDEEKMEPXK50QmBHO1aK0BnhRzwqANGuYW+7xu/C27RW41DUxCF9Xt0AphIIRhWsXTvQ4PLUn8= X-Bogosity: Unsure, tests=bogofilter, spamicity=0.499991, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 11, 2024 at 12:40=E2=80=AFPM Joshua Hahn wrote: > > This patch introduces mem_cgroup_charge_hugetlb which combines the logic > of mem_cgroup_hugetlb_try_charge / mem_cgroup_hugetlb_commit_charge and > removes the need for mem_cgroup_hugetlb_cancel_charge. It also reduces > the footprint of memcg in hugetlb code and consolidates all memcg > related error paths into one. > > Signed-off-by: Joshua Hahn Thanks for simplifying my convoluted code ;) Reviewed-by: Nhat Pham