From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C551BC54E58 for ; Mon, 18 Mar 2024 18:00:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 253FD6B0083; Mon, 18 Mar 2024 14:00:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 203C66B0085; Mon, 18 Mar 2024 14:00:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CB9C6B0088; Mon, 18 Mar 2024 14:00:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EB26F6B0083 for ; Mon, 18 Mar 2024 14:00:26 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 38C6CC0952 for ; Mon, 18 Mar 2024 18:00:26 +0000 (UTC) X-FDA: 81910924452.15.76D4B7A Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by imf16.hostedemail.com (Postfix) with ESMTP id 3E47E18002A for ; Mon, 18 Mar 2024 18:00:21 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FI7YQ5S5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710784822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IDpZJpAnayVu37/DhZQcXIKE2Hk/ZuslD6AOd+9Bwus=; b=ID3LECyZ4bsa79+22tDbfOL7e3zvwUpHX44cnf0lCs3nSm9WWF2iKU24CXnIBrTRSsL0NL HkX97djbZNgwcxqfF6ZF5VTikOTertKE3xH8Si5RSQD883PFdXpHNlGnOwIV/ufS5xxaNi TzJ9F77fWzrT+BH0WGlkH/OOLLC6Fcw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FI7YQ5S5; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710784822; a=rsa-sha256; cv=none; b=rHBNoMx2bYJYGArVE0F/CbM05QUlItNUSW8vdGgNfCdnq+4crIcd3RRqzTppZSBuLAQWKg GhQZiQhbgXgqpYWcQmwyqnTbG3Z6TzpDhxBRzT9dUT/gCnoUCsFfwQZntrc1o6YxBc8+MF 3g31e2Fb2r6I6rNo65l3Uj8hXv5r0kw= Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-4d44fb48077so578263e0c.0 for ; Mon, 18 Mar 2024 11:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710784821; x=1711389621; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IDpZJpAnayVu37/DhZQcXIKE2Hk/ZuslD6AOd+9Bwus=; b=FI7YQ5S5GDSCUFhYo/jYF2GpuFUV42FZgVcwJnLka7fgZpITjcEMZidpO0CjJSKXgu 52c/4T4uzjlSPf5EgcETpW5LPsG/g0cz8YEpy0EspI5va3/S3W8SmPjkqOrKpPYGyXZy IK69toPSM/4nAYq7go44PXLhPhPmEdvqibaXgB69g0sMiOjoMjPYj8M3hQ6pdDn0VfTf Ng3u+GqhWkSdnE/sNRnB0kk7DeaEGvqUnXwKLVlsJE7NPBHw+mGZWkdvxm4s49vaOAy3 swtIeykqg4PgAumECZI/Xsaw67bt7xmLMrptCF88iEfOfNKCmZCJdYvVEX1UuAgO0h3m J32w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710784821; x=1711389621; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IDpZJpAnayVu37/DhZQcXIKE2Hk/ZuslD6AOd+9Bwus=; b=gggi4Dqb2w/wNcn0+TcgUWRIXaZNm04MqSrBzlsQzddLhmhHB2tBzYwdlPhX1IGKnH PtjrHx9mIl2ZY/m/x1StoTeDDN+pypVMN02TWfkn2owGWHPg8SnxVbnHkyxKw0BtMPwE 8BgafzJiuo99xDj4cKDtJ2YhqQvK2N+9Q2UMu9m2+/US1sDHwn9YQlpl9h2fyLATlNbw Xl214/r2rMJq65WtGGAhI5iexWm8bMpEm+MOKfNpyygxpWWl3xgtd0eistNFuGSXoqIX hYgAMnQ9fpv8nfgSp3kiAyA3Gs9irx2BKoinDkvsfOaPxdRBFZ1JCMUVF1IsDO6tdkWe vtPQ== X-Forwarded-Encrypted: i=1; AJvYcCXrWWtDj9Wi+jcVIdn9J0Ai1foyIxrdgOUrjZTuZx5/vdrx4mrze3TAkdNSZnJcT+1+LfG0gkNtW69B3AqIvScnRC0= X-Gm-Message-State: AOJu0YzkymmN3yB2E9RFSuX80KW99yuFhRbqBLVFTqhNK4S19+sn3Ee+ IaFo55Rrr3TGO8uC1+/oAQzTy+LwNilQhPppT5sj7hYl2YNMw89qLOPbO7otpR70yMVDnqZERGW htewt6vp/AjnL4Me9tSYWzI9+tNI= X-Google-Smtp-Source: AGHT+IEr3h6RcgR2VPFctn3htgX7ul9X56SnWgtH8XpIwxTL2QN0E1UPZkkQvfhoH5mn1/xHBcnX8pfMY4vKRjn3zH8= X-Received: by 2002:a05:6122:4493:b0:4d4:20cb:8c0 with SMTP id cz19-20020a056122449300b004d420cb08c0mr10803190vkb.8.1710784821081; Mon, 18 Mar 2024 11:00:21 -0700 (PDT) MIME-Version: 1.0 References: <000000000000bbb3d80613f243a6@google.com> In-Reply-To: <000000000000bbb3d80613f243a6@google.com> From: Nhat Pham Date: Mon, 18 Mar 2024 11:00:10 -0700 Message-ID: Subject: Re: [syzbot] [mm?] kernel BUG in sg_init_one To: syzbot Cc: akpm@linux-foundation.org, chengming.zhou@linux.dev, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, yosryahmed@google.com, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3E47E18002A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: bjaeft993yfs6dc6brb6zzgbrimuku3o X-HE-Tag: 1710784821-214638 X-HE-Meta: U2FsdGVkX18uWM1NVg/s4VvysYOgfLlSzxyo6dDAbc0SXVhrmP075K0nKFlWQAeO4slrrO2eWQrxK3lDYtPnH9WCgoeoEZ5hq4Zaopm8wYG134AaIRwpNhFA/MFB8EtXT1fduaRwPN1NdS6/PFQNjGRtii/bXeh4UsDl9HJjAiREDHr4/5oczPkmCVyOC9WZ9IAi316xS/Tw3Xh6VWzkrItOt6oFm5OrbJTGr0COCBtIw79m0e/nViE3eQdSzc+DWPUx7UHdPKDxeKIrjXIBQIbl6oA0R/WMJHCnmpzDt703hGgrwPXyAJuJbwYbw96KV6IVnaP57FgwEQMM6oZIPtN6Az2DcE143/30UyxKo0wbeWRccirFXg2XK9eSg3/XvkbR4trYh0LBcPwd+83nm/4vu72aCrNlaIFaDgQEy4AcQZxwHzc7WBg54ww2M4nqZJ4VtvuDPrI975Aiw6S2Rt4+f5bvPEQ4a8cUOY5XsKT4qOKLKgsaEX8k5K+pN099fk2h7IkH8czsSFobz/fgRPOidmj2xiQHqorcnsYtO6FRpPQecZtGS6PvVvooGiR2jrAx6/uvkB47/q/iw+0TfaiKSf7SAXH3SuYqcVtMxiQfHRuV7zh/jBaximXQLmOVdJATQotG0FUq45KV3+ipUbmRhebwi5TXr0/QvRQpExk9B+V/b/zRQUNgnxEAEU/IwjVugiT1yu0bHxGy2fpiUgR4eL7n4y6f1jmHhj9L7vWXt06UdFn8U/v3MIStR/UkNgF5WV+XofQ+kM1eeDKlXRHzQs08F3at3S874tlaZGnUkSU9nKza12Bc8avnSPYj4HlJumSGjgI7tBJiWMAzo9PccP+hkr6gQcO1ItUiFsqQq7J26asIODxaY9As7zqyz9u4jNBOIkte7L+HnTfOR0rfb0tkh7RW7rCLDa26Eh2hHeraAcpkR61MRPqX92N8G/vwvZJNaEF9hPKuHxP wAYNiJSx ATMAnq91poL/Vx2h0LX6IpqjxUekFzmxnyZPxJslemLXabikJ2GHIUjlkjwDkG1qfh6bUIbg1BZT7Xu+fMp1Itt1a1+nbE7uhOO+jTOUvWeyS8Hi2zR6vC5/FxUakqJEgCga7Psrm5NZyGsveuZ+Xc0Nd+L50de0UHJ7nJM8pbn3RYzz3ZWWKOBeCoh0fsg6Jo7IhQxcbnxFOPV5zrrWe+0FIdSYmuWHGJH1uPFUOJZ4TjGimLom0y/HhvWQLa++evxKgTXIkUoqTs/xqfiDFzwrmZd0zF9vT/ehMAT87vRXmzUQ/e0JyzWkoyDVuztIu9Vu4JI+uusSbRO1paoKkvihbwqUjgLQi6ZYHdOuzinTyLX/wT2nt6JEYjgwQkrI71THTOQFW0c2a7cS+zxnLgiuYzUflUd+eBrfXo6xlckiHpkaKYFST6jvUvYjNBi7PhxvrbIftQiJsFEsqOdPxfZiLxHdWA3UOaAPVq0ouEnT9ZLqobA4I+cEyQDPtdAMQtnpSILCpjmCLkal1tT5cjg7yMOEgWlDlBLUQv/agzCeIQfKKsGWlgYMAqLphDOe+VhJ4uJO3Sfu9zxqibuzJPVeQQv+PpPBUABd2AnHNGGXd3e6f7D8sI2BgioGejDSQdQdCKSbW8/AOHcGk3iqJpa4j8IAXmdxXulwlspEsagSDtSgeGSfhdKbtMTeNrzcgYmBr8SdCN/vrQwXGnKD6EFrxnKo/k3zr1IFlocceFbbNw70QH1CHQmR7wRWCKKIEbVIntfVpMzjwDsSRMbrizsnKIBx7pfvI6ewdWnG07m6sZTm/8EStV/OxVNdoRNIMGVIb34D9AurcvPvOAu66MEUyhGhiTnkEr4sJdqlVLeDCZqhJQHSX5bpGhGfF6Ag6UtGJag8sh7ZQxQ8BTU2YbCv0cmkXnujUTvf9eUaoLULGRApxkHphBUv4YQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 18, 2024 at 9:58=E2=80=AFAM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit: e5eb28f6d1af Merge tag 'mm-nonmm-stable-2024-03-14-09-36'= .. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=3D13043abe18000= 0 > kernel config: https://syzkaller.appspot.com/x/.config?x=3D19bb57c23dffc= 38e > dashboard link: https://syzkaller.appspot.com/bug?extid=3Dadbc983a1588b78= 05de3 > compiler: arm-linux-gnueabi-gcc (Debian 12.2.0-14) 12.2.0, GNU ld (= GNU Binutils for Debian) 2.40 > userspace arch: arm > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=3D1706d231180= 000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=3D13ba795918000= 0 > > Downloadable assets: > disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/8= ead8862021c/non_bootable_disk-e5eb28f6.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/0a7371c63ff2/vmlinu= x-e5eb28f6.xz > kernel image: https://storage.googleapis.com/syzbot-assets/7539441b4add/z= Image-e5eb28f6.xz > > IMPORTANT: if you fix the issue, please add the following tag to the comm= it: > Reported-by: syzbot+adbc983a1588b7805de3@syzkaller.appspotmail.com > > ------------[ cut here ]------------ > kernel BUG at include/linux/scatterlist.h:187! Looks like the provided buffer is invalid: #ifdef CONFIG_DEBUG_SG BUG_ON(!virt_addr_valid(buf)); #endif which is "src" from: sg_init_one(&input, src, entry->length); Looking at the surrounding code and recent history, there's this commit that stands out: mm/zswap: remove the memcpy if acomp is not sleepable (sha: 270700dd06ca41a4779c19eb46608f076bb7d40e) which has the effect of, IIUC, using the zpool mapped memory directly as src, instead of acomp_ctx->buffer (which was previously the case, as zsmalloc was not sleepable). This might not necessarily be a bug with that commit itself, but might have revealed another bug elsewhere. Anyway, cc-ing the author, Barry Song, to fact check me :) Will take a closer look later.