From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D881FC83030 for ; Mon, 7 Jul 2025 21:36:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A7F38D0003; Mon, 7 Jul 2025 17:36:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 757FA8D0002; Mon, 7 Jul 2025 17:36:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 646E28D0003; Mon, 7 Jul 2025 17:36:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4FA648D0002 for ; Mon, 7 Jul 2025 17:36:57 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F1FC2C02B7 for ; Mon, 7 Jul 2025 21:36:56 +0000 (UTC) X-FDA: 83638778832.24.4E43384 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by imf14.hostedemail.com (Postfix) with ESMTP id 1DEC2100013 for ; Mon, 7 Jul 2025 21:36:54 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EGCXax8V; spf=pass (imf14.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.54 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751924215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WXMt5c9z5T7EEkHmHTONttuzAvrlHed+hbckXkH5d/Y=; b=gIasThWaSPDo0PzAsVOpk/KSJeMEETqvpo4Jy2Nm/+IvKbnPsSuAByv3pBDV1PG85WHLbX qKinleP4zkjsasPbscXMcErQTfBJuocOLqssVIkuPf23FwmfLFmNkPIcmjm9F8sKKz5mbe S3aVdSRO3aALC9ZSashVsHRwqg6Mde8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EGCXax8V; spf=pass (imf14.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.54 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751924215; a=rsa-sha256; cv=none; b=2BXHji0sYTnye5luIREcs3hz+ht226Sk8j/RoPhRcCIoGHmL8A2uRCVhliQNv+zh47wcuK E8Ul+ABMf6Xy7lhdChzM8viRpWVT3Np/Jgnajpjs4zUQo21n1qGSkOzkE458CdzYiji0g4 j+rHmpal6/0a04pgWS592f5VdZVqTIo= Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-6facf4d8e9eso40465576d6.1 for ; Mon, 07 Jul 2025 14:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751924214; x=1752529014; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WXMt5c9z5T7EEkHmHTONttuzAvrlHed+hbckXkH5d/Y=; b=EGCXax8VMBvbImBGflKmSkfpHFdZYGH3pNp7uhLFXOWHsT4crlbarcniE/VcWlQ+FY Eowh0HK49InAxJl+RQK7X8C/UGtIrJzb7KNkgzbr4vt7h3pgIvJRITgae82x7FNIXkxi f4YDAB0wwd/dlOEESRaN7Qsefhi7ETlfZNMyaRkxxD2cEVM5gNXe86wri/N3vwFA2tVT IpEhtSnOgNeln6uD3DXM/93kOgsAlvGC0D4EN9xJ87eUnxhlfrNScsZSp2apvyEM9QSb KtSkU0dInbtXssBTS72Zm7pVBFgH373y5INKcxhqYqkhYVF5naQPJ/RCEMipEn7ZP7dX Jy9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751924214; x=1752529014; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WXMt5c9z5T7EEkHmHTONttuzAvrlHed+hbckXkH5d/Y=; b=SQ1hWfXo0OEsxj10xeKv2Jaz1/ODe+rwsuS9Pg70cwG6IsiPpzFTI28eqcawr78UeU AOj68VmMVSXMVEiCB4lPO8T6rqAvTfBD5k+SUpD8FVt8H6sNxjTqLOI+mHHs79DZFcD7 iZPwakwlBrQxkz0gv9Px+p5A7XTa6cWsKzmUlFWg+TDcTlRQ8MQztNXo13dkO2XB/SEv qBNsJ7eqxROZB5a0dbV4RBHyWkbdqbsvZy2xQB7yUJzGuoHtZU6en+vnm+mey6iO4+6I w0qk7KaIH2ZrInS4rfOPx6nJ7a4Onr8pEs8E2/fyvtas5m9lYNRQDONUjtvHgRrzI8+g haQA== X-Forwarded-Encrypted: i=1; AJvYcCXK3NCcgva3BGLOJQyafkdWFWCdTn6248Bo9KzWZrENBmPeF00jUBgjcm30KFCo8LjjfK2UGqa7Lg==@kvack.org X-Gm-Message-State: AOJu0YwmPJPXPUDQ+9uTv87qjY3qcdyn/Cw5VaGJjKwIDV7P2st4GHrW r8YgETIvphRZoLIc3DViGVDF3jTkE38YnzuuQ6HF44UL0aZsHHpxJoS+NTbBbGbeGtJZYo9+LUE 1RM7doW7EP0H5YzMiDA5O2sOOMLmhRUg= X-Gm-Gg: ASbGncut9r7CPZi6CbMJY6yGj7PC58rPM6Er3IYl0SsD7JbdR7/w3hyBV1HUPu401k2 iXfoZPbX9QGi7FO7TXdH8mgwf+GcbNVTLrtFdyidAs/TqjdT/bb6W4XIL/TyGvzbTbm8yzsWu5u wP2+Ke4+0e6OjyQerwuGnScHMQxgerbogZh07gQisN4cA= X-Google-Smtp-Source: AGHT+IHUThxSB63AW5CQmAd9yQ9r3gS4EdoyxJOXpTu0VFbQmch2K0iEKcuRdMx4ew131TCobebed2kR88en6gvOTbI= X-Received: by 2002:a05:6214:5546:b0:6fd:4cd1:c79a with SMTP id 6a1803df08f44-702c8bc0efdmr224979786d6.21.1751924214118; Mon, 07 Jul 2025 14:36:54 -0700 (PDT) MIME-Version: 1.0 References: <20250707201315.9497-1-kanchana.p.sridhar@intel.com> <20250707201315.9497-3-kanchana.p.sridhar@intel.com> In-Reply-To: From: Nhat Pham Date: Mon, 7 Jul 2025 14:36:43 -0700 X-Gm-Features: Ac12FXx69sGZOSqNc9wEqk5H0AaE-wxK_VR_iKjhLveAP20PwkUU9RV0T58iefA Message-ID: Subject: Re: [PATCH v1 2/2] mm: zswap: Consistently use IS_ERR_OR_NULL() to check acomp_ctx resources. To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, hannes@cmpxchg.org, yosry.ahmed@linux.dev, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, 21cnbao@gmail.com, ying.huang@linux.alibaba.com, akpm@linux-foundation.org, senozhatsky@chromium.org, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1DEC2100013 X-Stat-Signature: fdz98hm7pjzwn9xihsb3i33subjkjbj8 X-Rspam-User: X-HE-Tag: 1751924214-499229 X-HE-Meta: U2FsdGVkX18tccB19bix8s4crgmDpKVeIiuaBHknTq8bbFwNZxy1OvFpI5eCmWjwlqkRT524VSo0UOE2tuHnbOnc2891Fpe2b/p7vMMiWuUoIkeN4Z6w6aYkjo79ls+R4dwh32xAmzPNmOqhDD5EznROKQPytZR4HPamSmzKOoxPbN+xYXV6XWlXbY7JdUGKROVNEi8uiK3dulsZR5UpLzwu0U2cbD/uQi8decSATTtr+aQaRHc7lWSos/K5sAtqh2/gawJ46ZSNx5yWbpDYI6FfSycg1NkW4lbA1F1XhvSXPLZsTWmGEkZPJkx9TXvRJ9m3MOPo6f5LchNMrWilVgQj/neIqwaAmmGvD/guVHHIxg705O+5zoZhEI/qq5Bnt7ubEsZJhb14eMRCF6gwX8gNVCYsrZANVo9/nWZ+eEqltNNF4tbbUT2Q+yelpO406WYscNuUArPBVxK4vxEpHKs2vi4mPYXL+PPFueVh1+I5B1LhbqFwRuohZjhfWUv5XUCr+0515RDxBCFp+dIq0J8MxQI8dgVDlFn7ev5/gsB+6Ljc6QXsWo/NaJkGxQ/qtKU6ElZQopl+wygDdA8e+S9OGWaNwl3jJf79/z0fUV+InAY/RuYgmLIAywV7T7qyDgL7gjcFUdYhD6gDpljM2rT8H2LPIocCm+y5S2EzFzLarpJO+sCNrgg0B4EdCVIESAP/KLXLtQyHBfWSUc0MVI+a0BM6nruJmP6xjEL63yYsELjunVybpeBovyh1Agquy3b+sppuVukwaGSa+gTB0Z1SheB0cAJFclCiVQaAjv4tS0R1+CY+1V1o1HJBS0yWLkt+8Wjlhe1E4/p+D1WoiluYVgr988OaKCSkENv0aSWFHhAqyNqsDl2JI+yka9tzf25XwPS8d/cWCWN1wYWwATJ5v4KV6dX52u0UlRqwweB1dIKpMP9ybxWJLetyRg9kXpdlTYYUSwU91KNBtB0 SkQJ2KR2 bgerOIVU6DgYyahqcIXVBFD94gKUxfINlAgbYX+PTKqYRGcSatrJfN1R3VEa57xXM8oZcnPL0jPBXq1Cz9YajNn3zzPsSwRES6AIxZE3l5J38cMtME6moXLBCcu5sWn8KMSbH1GC+o94ug0X2tkr6uISWsyEvYMWZVUJ586mQu8W5tlfisgM8osPJU16kV6bqOQivVWaTcBXR1ZvwCj/9XJDgRpPuLp2nZeOUvnrIwQvGIsf8uAvbGUyyL+e3k/8Ozh46hfi9P7157K5b0b6RswESIauLZEi4hstWhnKRkbvAujtCZISXdwRa6obuXkqqK9bE7IIXewIaRWIVlkkQyrVLWyZTLZ17fNjFEPqqTwjDznAp07k51Wynpl9sWt7v9B73yb/qv3ZJqytn88DBAieJ4cIXIUDKp5njmvgACKM9blfwc6gaULB2PbeRhgaP7K5AHqWoys2wapY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jul 7, 2025 at 2:36=E2=80=AFPM Nhat Pham wrote: > > On Mon, Jul 7, 2025 at 1:13=E2=80=AFPM Kanchana P Sridhar > wrote: > > > > This patch uses IS_ERR_OR_NULL() in zswap_cpu_comp_prepare() to check > > for valid acomp/req, thereby making it consistent with acomp_ctx_deallo= c(). > > Is acomp_ctx_dealloc() introduced by the other patch series? I can't > seem to find it. Ah nvm I found it in the other patch! > > Also, why IS_ERR_OR_NULL() in the first place. Can > crypto_alloc_acomp_node() returns NULL? >