From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 054B2C10F05 for ; Wed, 6 Dec 2023 17:12:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9172A6B0089; Wed, 6 Dec 2023 12:12:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C6556B008A; Wed, 6 Dec 2023 12:12:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7681E6B008C; Wed, 6 Dec 2023 12:12:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 630C96B0089 for ; Wed, 6 Dec 2023 12:12:52 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 352CBA0D0F for ; Wed, 6 Dec 2023 17:12:52 +0000 (UTC) X-FDA: 81537038184.19.821FAD4 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by imf20.hostedemail.com (Postfix) with ESMTP id 4EC661C001E for ; Wed, 6 Dec 2023 17:12:50 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jMbfW+pI; spf=pass (imf20.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.43 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701882770; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B+9ip8yZMAtxAFLF3RDeFuB04O8uGSJc2S5II7y6frs=; b=Ce/MbAWo0QasmTAsKzGj7NODUZ8WnDLyJNQ2vqGtpMbuSYlahpefqhAOkaDXyFC7EQg6qC 0+Adv6ieN+dctUV5mdxbS1qC9nonSU3TRZHf8o4zPWcTeLKdzODwbsWVhmvQ2yeO13RByV hac/GsYlNrG7W+5IjRsRDgyEoQ0l4D0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1701882770; a=rsa-sha256; cv=none; b=hzT361qBnrauXpoOr9MJtE2k54v4lZYKHh/sllTarpZyJmsfQZE2co9//ZuYWSE+IQ2IE3 UYxg/06nia6AeJhBtT6GM84BcRq3rvM+Aj8h3n2TGEqcrWpNkUu1edcS1el1RveZzYs9mQ GTeo3PXWzOLeMIy8Xycn5AtT5nyklmY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jMbfW+pI; spf=pass (imf20.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.166.43 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-7b35d476d61so229023739f.0 for ; Wed, 06 Dec 2023 09:12:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701882769; x=1702487569; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=B+9ip8yZMAtxAFLF3RDeFuB04O8uGSJc2S5II7y6frs=; b=jMbfW+pIT5b/wndGPgxuQYCqvOStGNf76KZK4D4Cqi20Yn6tKNmBXyDPU3bxNKyrSz OIbR/kAEgIOnakshPZTXv3Qiewn0cYyJflQpKave/mwoOa9zy3DmMqIXg7CgBQlgJ0Yb It9u2wpCMSJD/wV1Mdp/pHkKeTOEx2hC6pbmM7C/xrAOjudHCMeCWaKCiMcrstntaLY0 Kv88RcpZgJxZmBzoC8XpYso11uzYpP6sAg6KmVY6EyfPxSLUM0ZQSjH830Rt+GQ+Mq92 O/7rhgkmHywCINQBZ/w1WVbCJUsmOdBGSvsJJQdPX/Y/jv0KTy6EzlgVkR8WpFNkGsVi 4nLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701882769; x=1702487569; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B+9ip8yZMAtxAFLF3RDeFuB04O8uGSJc2S5II7y6frs=; b=WtJ8i6H7JZ7TSZYaWtw9NKvwI01TsPGEZj7hrahHR16DeQlx3CS8q+7NtktUJLQrfV wYrV3BhyiZ2UCXkvdNUP6rQ+xzLggmLZVa2VzLp+2fOX/7H48SzMetPKNreo1v2w6gWS zUufPHMCBtdxhkjGBoMyieRiaYVoKrKX5Vfh17KKAHdSmBMcqQk8PSjkhtPP8neNZjeJ cXh79nmFZApMqxPRBLXcDvLU+Cg/uY6YicGAxXMEXDhPZ2t6ot0q+wDU6y6HJJKk0hfN qetw2BMg1BQYq+I9vT6i4ixaSH5kRT8MpAUkBVQn9a+9wlNPR+Ne8ILgHLlE1o2ahzn0 s+1w== X-Gm-Message-State: AOJu0Yw4OlAZaDGcPpWnslh1D20mpgAifULGmInl1+APqvNiaWh0h+FN W4lYdf80MKq1lQoqymO67OWHTNrI+oO3MB5kqsU= X-Google-Smtp-Source: AGHT+IEZjGDx20iCLpsr8jzabySaPZgdP0pvoCTZrK9a4/+/3o58b5uvXyEwWBSs0l4XYmUjw6c3cWJSMnwb1I+x6Po= X-Received: by 2002:a05:6602:4817:b0:7b4:28f8:2670 with SMTP id ed23-20020a056602481700b007b428f82670mr1761277iob.43.1701882769239; Wed, 06 Dec 2023 09:12:49 -0800 (PST) MIME-Version: 1.0 References: <20231206-zswap-lock-optimize-v1-0-e25b059f9c3a@bytedance.com> <20231206-zswap-lock-optimize-v1-4-e25b059f9c3a@bytedance.com> In-Reply-To: <20231206-zswap-lock-optimize-v1-4-e25b059f9c3a@bytedance.com> From: Nhat Pham Date: Wed, 6 Dec 2023 09:12:38 -0800 Message-ID: Subject: Re: [PATCH 4/7] mm/zswap: change dstmem size to one page To: Chengming Zhou Cc: Vitaly Wool , Johannes Weiner , Michal Hocko , Seth Jennings , Dan Streetman , Andrew Morton , Yosry Ahmed , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: tqthgbsbqf976i6j8cyhqp35zghq9gad X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 4EC661C001E X-Rspam-User: X-HE-Tag: 1701882770-332799 X-HE-Meta: U2FsdGVkX19qDYvpp+/0gbuQCJST0PAbQzuBoYs1Xk58yIJaYpWeKJLmxDwv1bAZ0Q1hWyH7phisddAM7IlQa5WuoMNS/xGfmRqUNMEeNzwK1b1ETFX7Kx7q0YWeps5GENxI7VQg/W97trW+F+Um7Twy65GM4FNfgmPz6vR/JZ8HlFx5d1b+3S/ea5a35EnAlHr7GCRMrPe3/sVXzIxPtqkYdqGoaUam2Qs9jA1L3mJdTCv+ezWC/Nawoh/4mr0Z8WdzWyaHJU6ZcDWRzzdmb2Rx41ehDhsctLuEMvCe4ghkcynwB+yhwwdkIC7rVXFgPf9LtzW7tKC8XF8+myd+2t6dsWyGel4H4PRvy/KouhH3sqwFLp17/UX0yoEieyj/1wZsYF5eMJLilp+Y9rvT5uHuyuoI4noa+4RfIBt8cRolzXXGlZbtT4s4aMAuE6VoIbnltWj5cEwmhJ9Qqd0DYKejWDQ4oD8AJiFfAdHoeojxZ9YkzeX/itH4ix8MKO/zmkqimMLuJkSFwXIYnJyZzSWtPuMxE2RHMEtV4brZDCCs0vj/S863BkOcCHwNmG+7NjBvlG8HEk8xclOmNPDkFBJxW4Dnk5eQDmc/eyU7XM/C1ox4+7Ra9m6FaUVYohS6JtXmUO8OB/8gBM3wlLcT0jHytMhvYVcYGhC9sQHQwkFKFDaesUgqICJoMsa6/k08i/gSlDC6lP5N8MoW0DkV5uuN4rtFHNzA50Hp/owGfA/m710X07wDEXGMt8BT309e1iuroVA06fjmm6wtkBOYgLnHfTwjTJmi7gGfyQtXvSadK3a/6W6getlB49l3/gddtWdr8pjmosv6yP+eHz/3aSHzokVXf3ahMDj1SXCXYcKB0vSftgqHbvVK9HQReYEofwiPBmp/sTFcTLM/tl8I8VCNX6iX6P5g0XPfnb/Z3KNtqdyXMn5DzqqvLV9UwHAxzrIFdzNi+2JkvtOjO+5 vRiFXegk uKevRoD6lDAkOXEKROjtgIsnYQpxnoVdBnDsY92zV585zAeF4gufxU23zvoPAUBrQeEFmOumTW2lzUdEU764knubTupCin0RwR7KkY/Lgov0aCJ+42qzCs/Jt21KzhNRO5Z1p6qXm/8eC5ShS70RfYy5AxawW5+3SUCVTTPdLFJscjZw5pM1mwPm4IWmKL5DBofZbHkI69/xBSzZUe2pNPluX4YwhZh0AiuhuFMhw7KystendmCVXTZ1hHLSJoB7SaLBCGpEfnh28PRUdARR4nNrS7c41mM2cIHc3B12GsBU6Jw7b2hNmXa6mZOtN5ev4f4RdMEslnGRWBNpyVo9tBCF8FRMDqaN+v+vv9MTd5ww+MXUCDajwpFLuqEpGZRE0/UoB3Xx8ot8ALlLzmBKqjCoAtYtVrbo+iVc8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 6, 2023 at 1:46=E2=80=AFAM Chengming Zhou wrote: > > Maybe I missed something, but the dstmem size of 2 * PAGE_SIZE is > very confusing, since we only need at most one page when compress, > and the "dlen" is also PAGE_SIZE in acomp_request_set_params(). > > So change it to one page, and fix the comments. > > Signed-off-by: Chengming Zhou > --- > mm/zswap.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index d93a7b58b5af..999671dcb469 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -699,7 +699,7 @@ static int zswap_dstmem_prepare(unsigned int cpu) > struct mutex *mutex; > u8 *dst; > > - dst =3D kmalloc_node(PAGE_SIZE * 2, GFP_KERNEL, cpu_to_node(cpu))= ; > + dst =3D kmalloc_node(PAGE_SIZE, GFP_KERNEL, cpu_to_node(cpu)); > if (!dst) > return -ENOMEM; > > @@ -1649,8 +1649,7 @@ bool zswap_store(struct folio *folio) > sg_init_table(&input, 1); > sg_set_page(&input, page, PAGE_SIZE, 0); > > - /* zswap_dstmem is of size (PAGE_SIZE * 2). Reflect same in sg_li= st */ > - sg_init_one(&output, dst, PAGE_SIZE * 2); > + sg_init_one(&output, dst, PAGE_SIZE); Hmm. This is very weird. It looks very intentional though, so perhaps we should consult the maintainer or the original author of this logic to double check this? My best guess is for cases where the compression algorithm fails - i.e the output (header + payload) is somehow bigger than the original data. But not sure if this happens at all, and if the size > PAGE_SIZE we don't wanna store the output in zswap anyway. > acomp_request_set_params(acomp_ctx->req, &input, &output, PAGE_SI= ZE, dlen); > /* > * it maybe looks a little bit silly that we send an asynchronous= request, > > -- > b4 0.10.1