From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3FE9C3DA4A for ; Tue, 20 Aug 2024 15:28:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AE0D6B0088; Tue, 20 Aug 2024 11:28:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 85CF96B0089; Tue, 20 Aug 2024 11:28:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FDBB6B008A; Tue, 20 Aug 2024 11:28:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 508EA6B0088 for ; Tue, 20 Aug 2024 11:28:35 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EA342120314 for ; Tue, 20 Aug 2024 15:28:34 +0000 (UTC) X-FDA: 82473005748.03.BAB3A0A Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf06.hostedemail.com (Postfix) with ESMTP id 2CB3A180025 for ; Tue, 20 Aug 2024 15:28:33 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aM72RrL9; spf=pass (imf06.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724167634; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y5Ia15R1fE4O56YNp2nFk/C9bDA7ReCdChu+/M43J94=; b=2Brf27KJcERj4qkQxaRB2lfMvEPRWknED2bhUsx0tyeXmDeLaSUKeDfT51ZztLGMOBR4Xg jP6Nhva9UrnFGR1c12nBj3GyFj7qPw6ik79C2Y7oYs9MtmcpMryvlnrBGRG+djbVPoduJs B/ZwTKHEfbfzgY+jeG6ZYAKecusXKXA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724167634; a=rsa-sha256; cv=none; b=hyOoXF3KnVeC22hPndttuL+XThRq1dw1jNe3k2kUWWGK6lMbK6NZRMHtu9R169pwydF9Kd 4LJsSSnhW/kV1w9XTdbnCTys+6/kzMa51jL/ubsL0itwhCP2acGhuoUuhfguCynM6XJbXc 0CBzn2eiO6jF51gink8nDGlo0N34v+Q= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=aM72RrL9; spf=pass (imf06.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6bf7658f4aaso28234996d6.0 for ; Tue, 20 Aug 2024 08:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724167712; x=1724772512; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=y5Ia15R1fE4O56YNp2nFk/C9bDA7ReCdChu+/M43J94=; b=aM72RrL9hQFI88Tdz+JBFPY+sgSYf2QVMH4LS1IxxBBkT7XVCusOhgTh0QI2cgGnNh ECHYim0kFvDjOs3kmdhalc3kuG64mdOBV/z4ChO3F4Ee7LcPun2JVDjTlDjHzCLxIeH4 ktHPVQrOmMTDqQGm7njQbaXHoVuOBdWHa300JYak3HRQc+sbMzWBNzRVUuyfFIxLw4wY ZjA0SRsfLsgsdIjLbOJ0tnuiMZSU4oQ/VqWDMsC0sncX/VovGl70QDESeQeu5EU8QTjq 0x29ernVWtcmrv0i+YwzCOqAdK/MqHh+I6mQDU+TQVX48JllZtesUSShahANJL98Cng+ uPTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724167712; x=1724772512; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y5Ia15R1fE4O56YNp2nFk/C9bDA7ReCdChu+/M43J94=; b=ciQscWkprK+sl9O8IIdp2RJczt3ZLqgmOM/Lnx3MLQmNvuI8t+ome5K7gtmlzl5RyW gqyEFeSXOLmKTnnAmAvQl0XN6UbLgMKKpnoXGFczJc7R47Mij4i2xaLLnh5kQIWX4MPi ckMxuHOP7/QMcU9A9o/wdh/zEPi2Yl+Wl+xVwUSHG39n2l2z9o35Z/Sk59c8kiK2jVa8 4+sFhQ++L1peMGTzp5jT3gI/+52uxunA7xIw48J8Ip13ynlhNaPrJeHLIxeC8sQ/pAZp oViMSAZuk0aYGe3XD/Q6hCyDOxDh/9KY+unfAFPnVreIzuXl1lJdFdwZWxAa4lz1lgMw xd0Q== X-Forwarded-Encrypted: i=1; AJvYcCVQOtm15qrm91C0kl9Itw5Hg8Q3BJwux5ruxdbMrIOkHe7KGx57xVVwg3BsftzZRq2vPGt1w8yk4dpSoBu0SOB/uHE= X-Gm-Message-State: AOJu0YxlHNdRd7ahXONVVTFQOW8QKl9PpSwghqKKkoys3dpfptTR39u4 TltL1eOAnR/MBUIue+2aGMQtwpPZACeIxBxidczFmtKaz5o8sjSkKWAatO5Zi7p39xip+F1Ltgy Z3mD30vhlVWhQXAMzLjjox5C+qhc= X-Google-Smtp-Source: AGHT+IEqV9KEp2q8t9Yhwj+Novgkh6GlV2kQA5X+VhM+qBpbdD4m3xNHVA7TQ8IloKWoot40nDKdLpQ//xqy6n5FrqE= X-Received: by 2002:a05:6214:4608:b0:6bd:70ce:e413 with SMTP id 6a1803df08f44-6bf7cdef914mr179802206d6.30.1724167712113; Tue, 20 Aug 2024 08:28:32 -0700 (PDT) MIME-Version: 1.0 References: <20240814171800.23558-1-me@yhndnzj.com> <20240815150819.9873910fa73a3f9f5e37ef4d@linux-foundation.org> <20240819180131.27b0ea66dd50b83c85102540@linux-foundation.org> In-Reply-To: From: Nhat Pham Date: Tue, 20 Aug 2024 11:28:21 -0400 Message-ID: Subject: Re: [PATCH] mm/memcontrol: respect zswap.writeback setting from parent cg too To: Yosry Ahmed Cc: Andrew Morton , Mike Yuan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Muchun Song , Shakeel Butt , Roman Gushchin , Michal Hocko , Johannes Weiner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 6zqqama751u5945fk5qk16ow5szk31pt X-Rspamd-Queue-Id: 2CB3A180025 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724167712-546441 X-HE-Meta: U2FsdGVkX19veu54CBzTym/tKkDRXIQt9jgMVTWgGvot0cxVrgqQvstMWt3ZT9TZ03yKcQF+d67OqEjcwbBetHzu0r9xdB6gez98a+Jh9k3jGfzFvBK2D686eN/xirx0UhA5V8vBYz0B6qcd7D8mGGkLBdIgeBiL4W8LLWKOAgaSkV62oyqBY6EeHe38iKzYIj5cP+zPGmrQMSNPgPQYe4aGelZUOLK+Hmwkuh+omkWk8ozQgE+1tOydjO1MVhq9wEQtkkH/kBsS9rzIaSwWdVz02fC0Btw5vsRTT1hBZJS2gk8WrlxFBLpnwYN/pGS0LinNRLeBKVewUEAf3n0+dTkaFKAgeO/FTKiR6GKHLnfSuudDwqMfgklpFdwPuf9fBRa/kdUqlnXlyS3nTjVa4Zjm87prKpTWE1eOIaCiTFfPiFju0W/LY0SByipw+lF8JvB2ofTNXATzImcmv0rA14HBZf6vKuB9OtAHcHQE+bmq52PtM1Lg34HthtrZQPkX28jqe8HUAEmsS84zPl++Z8BV3Eo3INQE8qClqVdhvfpecudqO5Jni7N91seM0BnzPldOqvmygXzMKmbS+L2SdJ1hVevkMLbDEJdyLbwKdcO1LDcwnSkeNRKouZ+fF/oqyp8WEvqu/cXIBkmxzajXI8NeOmvvC1ExdhT17/6YCHxWyPHpgzm7by/2fR/sGgxKEa6CLcro918KffvGdO0/JKbyinG3/y9vt71rNZ/oZHpvTd6HDZEBS6BjJD5G7pkWv+9bBk3CWM0mOXyvRZbrrjk668uMDCHq9VjL6pFtpVujO2vSEx5WJZbwJtRycp8q3VS84SxoMxcjtiXPSYy/iAguqSo/ZZzWlSircmr4ByhUGz8pMT3SVFDh954WWQ9llVcNsH+dHCde32mj7K6Joo8y/jpL19bNWph/AohFJP2eTs4L01bWKJdE6flcQRvyM2ioTdVcfjSX7fZD6dQ r7uvn4bs C0DqF5sa+iMh1eqCQ1+83ocA3EjkOJ+Eb4t1Zn4x4lfuBUIR7iMh0korAalkD4NpCBlMmk9/2Y27QPAZD7w9U0fqPhQTVKu2BJ5S/T2bYqvUypAwqOSlPXQDRx8Jfx7cRjWcIKpQSXv/Ao4w3sNhzBLq290y04LPmdX0c6YMbyZl5SojnwKtTZOXi3F7PQQaRJNHCa4x/YiMZvAFooucyBUFeXMX5DBdz0zEWdV5A6JUT8ns0zSDCRHscFuNWlS71sG3qc0rllusFunOTsfdgWBq0fl1hMd/AVU9CGhxw6FMPi9GNeGTvdwoul2pVbA1+jDt7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000272, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 19, 2024 at 9:07=E2=80=AFPM Yosry Ahmed = wrote: > > > It's commit 501a06fe8e4c ("zswap: memcontrol: implement zswap > writeback disabling"). It landed in v6.8. > > I suspect there aren't many users that depend on the old behavior so > far, so I would prefer to get this backported so that it's less likely > that more (or any) users start depending on the old behavior. Agree - let's backport it then. In hindsight, I feel like this is already what users assume. We don't rely on the assumption internally, but at least one client of ours has asked for clarifications about this.