linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nhat Pham <nphamcs@gmail.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Mike Yuan <me@yhndnzj.com>,
	 linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	cgroups@vger.kernel.org,  Muchun Song <muchun.song@linux.dev>,
	Shakeel Butt <shakeel.butt@linux.dev>,
	 Roman Gushchin <roman.gushchin@linux.dev>,
	Michal Hocko <mhocko@kernel.org>,
	 Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] mm/memcontrol: respect zswap.writeback setting from parent cg too
Date: Tue, 20 Aug 2024 11:28:21 -0400	[thread overview]
Message-ID: <CAKEwX=M-BDNNJo5-LXj3iR51BksH4t-fZhFDD4Kt_DvNqj7oUQ@mail.gmail.com> (raw)
In-Reply-To: <CAJD7tkY5u4vYRytMb+nuW3VhA9xHEPVux=vv_+k9oA1haFxa9A@mail.gmail.com>

On Mon, Aug 19, 2024 at 9:07 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
>
> It's commit 501a06fe8e4c ("zswap: memcontrol: implement zswap
> writeback disabling"). It landed in v6.8.
>
> I suspect there aren't many users that depend on the old behavior so
> far, so I would prefer to get this backported so that it's less likely
> that more (or any) users start depending on the old behavior.

Agree - let's backport it then. In hindsight, I feel like this is
already what users assume. We don't rely on the assumption internally,
but at least one client of ours has asked for clarifications about
this.


  reply	other threads:[~2024-08-20 15:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 17:20 Mike Yuan
2024-08-14 19:52 ` Nhat Pham
2024-08-14 19:53   ` Nhat Pham
2024-08-15 18:39     ` Mike Yuan
2024-08-15 19:10       ` Nhat Pham
2024-08-16 13:25         ` Mike Yuan
2024-08-14 20:22   ` Yosry Ahmed
2024-08-14 20:43     ` Mike Yuan
2024-08-15 19:12       ` Nhat Pham
2024-08-15 22:08         ` Andrew Morton
2024-08-15 22:10           ` Yosry Ahmed
2024-08-15 23:31             ` Nhat Pham
2024-08-19 19:05               ` Yosry Ahmed
2024-08-20  1:01                 ` Andrew Morton
2024-08-20  1:06                   ` Yosry Ahmed
2024-08-20 15:28                     ` Nhat Pham [this message]
2024-08-21 16:14     ` Michal Koutný
2024-08-22 17:49       ` Yosry Ahmed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKEwX=M-BDNNJo5-LXj3iR51BksH4t-fZhFDD4Kt_DvNqj7oUQ@mail.gmail.com' \
    --to=nphamcs@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=me@yhndnzj.com \
    --cc=mhocko@kernel.org \
    --cc=muchun.song@linux.dev \
    --cc=roman.gushchin@linux.dev \
    --cc=shakeel.butt@linux.dev \
    --cc=yosryahmed@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox