From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41C64C4706C for ; Tue, 16 Jan 2024 13:15:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9782F6B007B; Tue, 16 Jan 2024 08:15:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 928E06B007D; Tue, 16 Jan 2024 08:15:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F0326B007E; Tue, 16 Jan 2024 08:15:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6E4BC6B007B for ; Tue, 16 Jan 2024 08:15:04 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3F7D740259 for ; Tue, 16 Jan 2024 13:15:04 +0000 (UTC) X-FDA: 81685219728.12.2CAD632 Received: from mail-ua1-f48.google.com (mail-ua1-f48.google.com [209.85.222.48]) by imf10.hostedemail.com (Postfix) with ESMTP id 43120C0029 for ; Tue, 16 Jan 2024 13:15:02 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ieee.org header.s=google header.b=f7I25cwF; spf=pass (imf10.hostedemail.com: domain of ddstreet@ieee.org designates 209.85.222.48 as permitted sender) smtp.mailfrom=ddstreet@ieee.org; dmarc=pass (policy=quarantine) header.from=ieee.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705410902; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VxE5gRKWX5WIlqZll7ZuGHm5XyM3jSfNT9oAYPBUFVU=; b=HpWtNRn9BHYAttvdV5RH3ohD2Rgv9wtZ4oftpgG46nRX7xxqID/DY7xKPwQPR4qRWQc8aE TgwcdpNwFFPLTyNMlo/9ifMBrEaVjn5ZvgfI2vlS8GNJ1VeY8S4eho3fPhkBviCfMv5I1E TwIfHZR48adQjun3GBY0a9VUYLGrLa0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705410902; a=rsa-sha256; cv=none; b=qnz9blIooj7ACm875NhQRo+e9DrjorbEgcVJfeJIZCM4CYHnR303wnKGzlEnlJ9EdZm3LF iRLeyAfcWySgO6ZVVi44Prww39vCx0Usm5uejn5B8xprl37BYQe4H2/gicSS3NBXwWgJ1j Qw6llvly6c12jgruirkR8Bljekk30C0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=ieee.org header.s=google header.b=f7I25cwF; spf=pass (imf10.hostedemail.com: domain of ddstreet@ieee.org designates 209.85.222.48 as permitted sender) smtp.mailfrom=ddstreet@ieee.org; dmarc=pass (policy=quarantine) header.from=ieee.org Received: by mail-ua1-f48.google.com with SMTP id a1e0cc1a2514c-7d250629e25so367850241.1 for ; Tue, 16 Jan 2024 05:15:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; t=1705410901; x=1706015701; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VxE5gRKWX5WIlqZll7ZuGHm5XyM3jSfNT9oAYPBUFVU=; b=f7I25cwF7lDGqWQq1Ju4k5EK9bUwPY31+P/iKZll5ZNPno96ZbxURRCWRuddLUwqor Bnyss+X8Eegr8d1JASmP9sfl+q8owrUs2fZutbWq4trp3R4NErHF2wCeTqB2Yo4sseiD /2evKM9/DRg+YnCuu90dbm/XNj+T5ZTrjjFcU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705410901; x=1706015701; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VxE5gRKWX5WIlqZll7ZuGHm5XyM3jSfNT9oAYPBUFVU=; b=beeRUCVaEC07tkmKUP42pisZvBTHljIvEUCy8BtlJs+rk/GEc+p7xVsEcWSk6ZxqcW 5O6AhvZSg2yAFUyiJRGBnDmAUxGBnO1EkcbaUhVE/v326cfxyXdhhDgB1snhI4WVo1j/ G+xO2o30Pe9pBeKljKFg/mr6EbwPXzy+B/9UebAzSKv5StW5c6vPiCeGm5GKwLgAC5fM E13i9h0ZNRocfQB1rL3cYrWsuZs0nQu03J0lV30wpaJ1VvD3pst1sxJ/yHQVFo6ZPPa6 nO+jaTjpPEgT5d0lGomY9z0HNI+oH2Ke9PGLTLM6mPTDQQY1HirtQMU41jgQAaO94HO2 Q5pw== X-Gm-Message-State: AOJu0YxEZG+oBtdg7X0zK/pKn1dIdRl0VddleruBDOnJr6ZN1ksT4cD6 rUgZUvAF9yVC9ZNLfc5/q54FsVa6Gbf333B2JPqdnZy9+6Cg X-Google-Smtp-Source: AGHT+IG03YIQdfEcDrGRfVc58pi2W90U/Nh1GP6rA9MIiUj+tZumy0pbNeWvqnOz4eneEECCZ4R008D1vz+MlXpAcxQ= X-Received: by 2002:a05:6122:1c8c:b0:4b6:dc25:3d53 with SMTP id eu12-20020a0561221c8c00b004b6dc253d53mr3297104vkb.16.1705410901101; Tue, 16 Jan 2024 05:15:01 -0800 (PST) MIME-Version: 1.0 References: <20240109174302.680353-1-yosryahmed@google.com> <20240109190200.GA35140@cmpxchg.org> In-Reply-To: From: Dan Streetman Date: Tue, 16 Jan 2024 08:14:35 -0500 Message-ID: Subject: Re: [PATCH] MAINTAINERS: add Yosry Ahmed as a zswap reviewer To: Nhat Pham Cc: Yosry Ahmed , Johannes Weiner , Andrew Morton , Seth Jennings , Vitaly Wool , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 43120C0029 X-Rspam-User: X-Stat-Signature: dhfy7z7mzwgudbsmfd8ysymxatyotjyi X-Rspamd-Server: rspam03 X-HE-Tag: 1705410902-749624 X-HE-Meta: U2FsdGVkX18W5m88BbcNt0NeD50rq/LSmuNeHcbC1b2UYk+xE3Yo1jeE4JOUElh+4EW+dn+nWAvts085r6LCa5dapYAZieWrKSv7+MtKBcwsSMJCFuqJHiGSyyK84IFtSH0vVBB+86Istbbm+KjEV7mJs/tubiem26N+nhVeRvZ6iF4RXVmtZGuT+ygSL3BhUFz2bRfpcfR8797qwlvcaZlCJoRAnItSolt/NltXEk/4xxxdVHaPEmguIyjQRgwQmaoLiMEEM02B7MIszokDg20grl8GfyOAm4KLOSxcVBONwT/i1WYkepAO0gJTfLrnFopOAlGnJdgHdct9Hm8EAonUql3E8Edzat61hlgf9+4lHD25gbJFXrZ/2+qNDY8RbdKX+DC1KrD2JYtwk7FDuNBgRCwthIvsQVXpSD1ZJr1fzoV7Ye72gqlT3sQQS+rn/QkSgUmY6iQqyFgCYtnF3F9laf9E21m+2A7djwaBRUXjzRG8DrSOyrYHjg0aQLGr5gmBwUzRqG3eJKKuuhblbtIQzM2TCBRTZRueCXcK47BVdkz7q3AJiNMzMgSFzM1oGm1+v6KQN3+rjjpJCAcTE4Bc0KnQxDuMtliF9pRUNhpBlmQoTulNLRAeLs6Sr9rsbFwpDAbtdC8peFSyOAGdbodi9jguyqRYPjXirWsRlScUiPWzOCN7+3OvJdSvDag+A6ZA6aFefAPEMzYPUkmIvVYDof36vKGV8sePbynuOyxXt8WPlZaf5kk20ABc9yO38ODTuGQA42O38UVUMTvfo4hdSQiDp82cRk6SKcDyah24s4JfV9IJjJjp0YfpkF5XcKalJgBL/4HHo8n0Hyrg8xrNxf6d65Q8BZ16NcmL0D1+Rru63+DK322CAU4KwZTUi/Dou2O8KKJPI7kBeHJaltjklKvOrAsa3wHsQR/VpjYTNbruolachhJYegUN9KKEHS4BtY8PhqtIypa5L2K foGJtAlY DDKPgqg/sQc+I/v9d+HmYVnePqixyhKFDu61Bmd6oXg2zdrDDAVelbiFtrD4T0NkUoK58SR2FcmHAca44e9JND9u+yFZU1L1aBiXBr9rAMTvQJc/q5Kzcj43uksnqG5LwAbGj6k5wuTgfJgcQ3FBEjEuN2M5KB8t6r0wkQg0CX0+h35Ce5nZ8irtoyymx1BG3+fmt7eS0hfMWdbVqNTKu6n1aiVrQcDwsaCBc9dfEDFtpS7xBxJoOvmvpdI1O50rHfb25aCPc9ppSOz+9GUDSaOk5vKLdRt+ZS8VCSB1UsQaCizxeJrumTjlrKu4ojVJXYaOb2UetzsYopJ7780q503vZG821AsxuU6gWMym8eJWxCz7O5sZlwBpjjs8PGM77nRjzlN2axA+WKh8iXhotKxIUAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 14, 2024 at 5:48=E2=80=AFPM Nhat Pham wrote= : > > On Sun, Jan 14, 2024 at 10:54=E2=80=AFAM Yosry Ahmed wrote: > > > > On Tue, Jan 9, 2024 at 11:02=E2=80=AFAM Johannes Weiner wrote: > > > > > > On Tue, Jan 09, 2024 at 05:43:01PM +0000, Yosry Ahmed wrote: > > > > I have been actively contributing to zswap and reviewing zswap patc= hes > > > > for a while, and I am already getting CC'd on most of them. Add mys= elf > > > > as a reviewer. While we are at it, add missing zswap files to the e= ntry > > > > in MAINTAINERS. > > > > > > > > Signed-off-by: Yosry Ahmed > > > > > > Acked-by: Johannes Weiner > > > > > > because I agree with what you're saying. However, I think that > > > maintainers entry could use some more help. You, me and Nhat have bee= n > > > doing most of the recent development and reviewing of changes in that > > > space. Those patches have been largely met with radio silence by the > > > existing maintainers, which makes me think the folks currently listed > > > have moved on to other projects and/or aren't able to spend as many > > > cycles on zswap anymore. Maybe it's time to update the list? > > > > > > get_maintainers.pl says this: > > > > > > [hannes@column linux]$ ./scripts/get_maintainer.pl --git -f mm/zswa= p.c > > > Johannes Weiner (maintainer:ZSWAP COMPRESSED S= WAP CACHING,commit_signer:14/29=3D48%,authored:5/29=3D17%,added_lines:121/5= 51=3D22%,removed_lines:192/440=3D44%) > > > Yosry Ahmed (maintainer:ZSWAP COMPRESSED SW= AP CACHING,commit_signer:11/29=3D38%,authored:3/29=3D10%,added_lines:86/551= =3D16%,removed_lines:44/440=3D10%) > > > Nhat Pham (maintainer:ZSWAP COMPRESSED SWAP CAC= HING,commit_signer:9/29=3D31%) > > > > > > How about the below? Dan, Seth, Vitaly, what do you think? > > > > > > Thanks > > > > > > --- > > > > > > From 9170b8a17029550bac6b315edbd0db21504ec5d3 Mon Sep 17 00:00:00 200= 1 > > > From: Johannes Weiner > > > Date: Tue, 9 Jan 2024 13:50:53 -0500 > > > Subject: [PATCH] mm: zswap: switch maintainers to recently active dev= elopers > > > and reviewers > > > > > > Signed-off-by: Johannes Weiner > > > --- > > > MAINTAINERS | 8 +++++--- > > > 1 file changed, 5 insertions(+), 3 deletions(-) > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index f71c525405e0..b65538e85e9c 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -24122,11 +24122,13 @@ N: zstd > > > K: zstd > > > > > > ZSWAP COMPRESSED SWAP CACHING > > > -M: Seth Jennings > > > -M: Dan Streetman > > > -M: Vitaly Wool > > > +M: Johannes Weiner > > > +M: Yosry Ahmed > > > +M: Nhat Pham > > > L: linux-mm@kvack.org > > > S: Maintained > > > +F: Documentation/admin-guide/mm/zswap.rst > > > +F: include/linux/zswap.h > > > F: mm/zswap.c > > > > Probably a bit too late, but should we also merge the zpool entry with > > the zswap entry? I can send a follow up if we are in agreement. > > Sure, if Dan doesn't mind. Yep fine with me. Thanks! > > Also, maybe we can eventually deprecate that interface too, once we > have retired zbud + z3fold and no new allocators are invented after a > while? Similar to how frontswap is killed that is.