From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AB8CCD1283 for ; Fri, 29 Mar 2024 05:15:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F158E6B00A7; Fri, 29 Mar 2024 01:15:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E9D8F6B00A8; Fri, 29 Mar 2024 01:15:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D16E16B00AA; Fri, 29 Mar 2024 01:15:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B304F6B00A7 for ; Fri, 29 Mar 2024 01:15:52 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6F7F98114C for ; Fri, 29 Mar 2024 05:15:52 +0000 (UTC) X-FDA: 81948914544.17.F543C4F Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf02.hostedemail.com (Postfix) with ESMTP id A94B480007 for ; Fri, 29 Mar 2024 05:15:50 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=vKx+DCsO; dmarc=none; spf=pass (imf02.hostedemail.com: domain of debug@rivosinc.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711689350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SA5bcVE32KgGG5TtTqzFEWB8zyElCwHL0lTeALGfaJE=; b=uwRAPPabGHR/5+IyEbwvCnofwVZev4VKIhRlWTlQmSe7M3J/884Anfvy9CUpm6BQaLFeQV 0WuxRDU/ImsRp0fTXXNQgn9tDqO2m89OJW4MeStKn9Jx3e697IhHHnG6tG3pl9qUFPbzfA wHWEXw2jFpetISJ1OLOlbFofeRCcgqU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=vKx+DCsO; dmarc=none; spf=pass (imf02.hostedemail.com: domain of debug@rivosinc.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711689350; a=rsa-sha256; cv=none; b=7uGq0Wm0ELhRvaZ2xgkGoegn0TP8l8vqR6ZbxiQxZa62kxAOuE0OZEhpmi30X5BlVJbVQ5 0RlbXqofh/EZRCWc0taptTXVga9/J7cURwDqL82ArZ8NF5d/Pg1lRzs9/YhZpJaUhuVvDd w+5FOGaqJtPKsl1cQOz4VXVjxVDQULE= Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-609f3ca61e0so18214137b3.3 for ; Thu, 28 Mar 2024 22:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1711689350; x=1712294150; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SA5bcVE32KgGG5TtTqzFEWB8zyElCwHL0lTeALGfaJE=; b=vKx+DCsO7LxwNep0u7AdHm5C2dgbDA3mrzyZ+6ZObiPNDeRThv7POSCRtOAk2HbCxs IdbS6JXkbHWjngP6bh3nFKC/gFoCIwHoNWTwaCzb4JrFatFs/kL3ekIqlBZuvQI6XOa9 3sfw7pyh6x2cCwxKQYwzfMd2EEh4x2mIo7mRSHnYIkp7UKLQQaBNfl3lmEHGyg0OaA7y PnglisBgwRRwAktnuHcRaWXQqs2iHy+aG9DIjhcxysNfoU72lqopSK4d6/WPZNaUZDk/ K6Pdt6Lqqwv5g5wspS+t/d5sCUwYg6mtkHTI3QxaCXQufN+YJ52+KqbhQwmkqwlwRdhh HlpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711689350; x=1712294150; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SA5bcVE32KgGG5TtTqzFEWB8zyElCwHL0lTeALGfaJE=; b=S3Gphhgb0daHEmx6hZU/sXssOgczLqNARDB6IMGm/aL30Ta4szX+iv6tuczvzZry9c 9koPJGvUOU3w+dQtL/DliNrrol7X2zan7xNmdqZGJiSdEzLxbY63lIbUToWOQvUvRZYB 7U0GOTRl+pomFPZ7r+dP4tvkloCyFYJ38oVy0NyjP4XJBhxLQnI5LvAipbgaAhixNrzr i4acSHj0TllYIR7pYpXrp11A0zyiLCnIKqW4G8Z6rlfbr6kAycD6uDdOGyggVe/xTxdT o6l4GW9ZaFG+J/eQQGFGhpglblJiiV0zIh5qFOx4Anu1QBuU3ATG0Nc5l4DGqVZcLds3 Lx4g== X-Forwarded-Encrypted: i=1; AJvYcCWJHZiVy5zCzSHrkCzukKTLovzCXmUF2S849cdSHdMtXIXNS9NOImt+SJtJLKP7yXcdx5CJL986R4FwozUqAIOaKtQ= X-Gm-Message-State: AOJu0YzShleG3XNh9rt3Q3IvjwyTHXpItfgzLwQNKhShkMQdtgMrJKpi abZiJphZO46Nb+0fSHeksS6gZX4ycrx9AHK2HgxVHAqiswxPgGOy1e6s5ERnfkPqYt9sX4A0MX7 oAYCPOxIyGMp5MH6Fxb3Olph1O5fN0JLYR48UnA== X-Google-Smtp-Source: AGHT+IEKGRQwrWyCqxzJ0SB08UytfQ1UABftg33xsS/BUh/oR9gt6JPV6v/mkEdtL2mGt8izQHtaPErdxwMk9zmhQVo= X-Received: by 2002:a0d:f184:0:b0:608:5dfc:1336 with SMTP id a126-20020a0df184000000b006085dfc1336mr1323243ywf.39.1711689349755; Thu, 28 Mar 2024 22:15:49 -0700 (PDT) MIME-Version: 1.0 References: <20240329044459.3990638-1-debug@rivosinc.com> <20240329044459.3990638-12-debug@rivosinc.com> In-Reply-To: <20240329044459.3990638-12-debug@rivosinc.com> From: Deepak Gupta Date: Thu, 28 Mar 2024 22:15:40 -0700 Message-ID: Subject: Re: [PATCH v2 11/27] riscv mmu: teach pte_mkwrite to manufacture shadow stack PTEs To: paul.walmsley@sifive.com, rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com, samuel.holland@sifive.com, conor@kernel.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: corbet@lwn.net, tech-j-ext@lists.risc-v.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com, shuah@kernel.org, brauner@kernel.org, andy.chiu@sifive.com, jerry.shih@sifive.com, hankuan.chen@sifive.com, greentime.hu@sifive.com, evan@rivosinc.com, xiao.w.wang@intel.com, charlie@rivosinc.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, dbarboza@ventanamicro.com, sameo@rivosinc.com, shikemeng@huaweicloud.com, willy@infradead.org, vincent.chen@sifive.com, guoren@kernel.org, samitolvanen@google.com, songshuaishuai@tinylab.org, gerg@kernel.org, heiko@sntech.de, bhe@redhat.com, jeeheng.sia@starfivetech.com, cyy@cyyself.name, maskray@google.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bgray@linux.ibm.com, mpe@ellerman.id.au, baruch@tkos.co.il, alx@kernel.org, david@redhat.com, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, shr@devkernel.io, deller@gmx.de, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A94B480007 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: yq97ap3ng9c6eeymf6xupmfbc9tw6rm3 X-HE-Tag: 1711689350-879069 X-HE-Meta: U2FsdGVkX1+p9j1B6B1BVLKcipOsO5ACT5I2qwJ7sdjDTpg0B5jKzuF92tu/vNGc1PHceujwR1m7UxYlut40UG5YEEEqAjLvJtOspy2PObOpVwj/+adD2V41GXLDQaqUnTmtFWJ6d2pZC9aQgLgr7XE47iWPrS37Xii6x2j/kh6ONkSnaTbtKV1H1xSLiDq16PLRy11jxJ9cW6b6XmCeM/VekV56wyGIdGp7JAAI70x1PxX7KsnurnuGfRe7DMpMZ6ViXxwhyw1OXeC40SFrMkC0Cj0lN+YeGG+N5duNvtgxqIp0yWcNGmjlgFDEn3LHPyRSPTW3lHI83zv7y4NoIUHWwwNRwdgoBUH8Vi+mvmJv9FgULYv1+PDefBNIpraF3Ho2OtdIQlIZ2H+atJ0sD7/VCECcObhBXntWNE9qpssaEfWMRJS7Ku+18q09lPcthu4ySzPtsaNnnpRorNstohj16uDq0kRdHJSIy3QpsJzKGPOFBcTBVB88BoVEKS3nFC+Z5KlPzH0Y6F5BQi2A+0nzvU9W+7uibYMjd8UecCEvvGkAy20p41p7VZmLSLFmRGK95lFcEnwOGBZjE2XsnJYJw/rEKoG11+MHx+zfjTWSXIy/wr+XtlPS7mItU5U5q/yea4V9FyqoZFwnXOOZeCKmG1eMvduDRrL7MHDl+C48JQMWakeodtjXK8NffwQHeKSMSyBF/UAp0bkwiVKg32xWgwxt0dztKGE2f6Y4MkU66BoJOANGEREaBVxgxcoLz6IdPgWUAOpoDOveKiR1wIAikfG/SSiNc5RUZiwtRp0kZf9Is0+bPvPGABQb69QJPVmwDTHzfidiUS1EOcHGzUGSZTfNMP2Sk9vs5Dz+xCFlcNZBzXlM9hMDwDUoWmvT7EfdBJsLmF/ApQ1KS+4skpgh+vWQXXVHhuPJthEPHjIxfWYwKcVI+6udDDF7fqQv6wDP+y8ZnAPiZzEYZ8E E84woqMF CumhNyuyCbBnf1Kj0YTazrfy4d2YSN8czlVHRvBvJemkgfOn8LKmi0sG5f9B1Sog119JLxOB1cOLS/MbY4VMK+EdIm+rBu32q2NMe/wpcKrU+I+XDKa6kt/jNnCeWeTkcBLTAmmgco7ww5TgmKyn5fR0OVv/+lo+JeaB+tsOnYFAa/7pGkOFyni2rHjNayxwfDtBak1DhopK5rWvVqhQizthFsF5jLgn7JgZV8Iy4oRL3wHd2YrQL1AT8ZDBxMopacz0nAS3EDsrL7vCTLOwSTPF2DeNgy5tKxE/F6xMA21yFT+l+aTtK+xxBPsA2RGqXjcTTtPp9Ru99Pc6c7CTKPneh+O6hWY+HGU02g7csb2aC1b12vF2k+yTCmabDjHOlzsI938KIQm+TgzLGp+JDXBzT7MzTsZ4xim9eV26PjJHGl5Cn9X5G8TWeWriqqFM1uhWmp3LVFlHGca8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.240203, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 28, 2024 at 9:46=E2=80=AFPM Deepak Gupta w= rote: > > pte_mkwrite creates PTEs with WRITE encodings for underlying arch. Underl= ying > arch can have two types of writeable mappings. One that can be written us= ing > regular store instructions. Another one that can only be written using sp= ecialized > store instructions (like shadow stack stores). pte_mkwrite can select wri= te PTE > encoding based on VMA range. > > On riscv, presence of only VM_WRITE in vma->vm_flags means it's a shadow = stack. > > Signed-off-by: Deepak Gupta > > rebase with a30f0ca0fa31cdb2ac3d24b7b5be9e3ae75f4175 > hmm.. Note to self: Missed removing this lingering commit message. Will remove it in the next version.