From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6E40C46CD2 for ; Tue, 2 Jan 2024 18:45:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 491E36B00B8; Tue, 2 Jan 2024 13:45:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 441F46B00BA; Tue, 2 Jan 2024 13:45:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E2EC6B00BB; Tue, 2 Jan 2024 13:45:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 194306B00B8 for ; Tue, 2 Jan 2024 13:45:20 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D933C160175 for ; Tue, 2 Jan 2024 18:45:19 +0000 (UTC) X-FDA: 81635248758.07.0177251 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf18.hostedemail.com (Postfix) with ESMTP id 0ECCB1C0009 for ; Tue, 2 Jan 2024 18:45:17 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=l8nnUOvU; dmarc=none; spf=pass (imf18.hostedemail.com: domain of debug@rivosinc.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704221118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vjVmfRb4lmSQIEbZDNGApWLh10nZ5LL8tfeNBp5q+Ow=; b=0jtSah7ducMlFO/HIm8Pf5VfNIRusO1FKBmXCU/4GQQwkul2HNN9G3ysNGSts8TTF1PYij KOVoFfubFDJSXbF8b9Z2+xDjyjgr6JVWEVnCYwM6F0AqnOhOS8lIQEnO/JlP1JW82fU9xY gP20U6CZK/7FC9sK6315VXnFSX5ATDk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=l8nnUOvU; dmarc=none; spf=pass (imf18.hostedemail.com: domain of debug@rivosinc.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704221118; a=rsa-sha256; cv=none; b=kHrvusJU+mlgQMq9eeENs90RVuZ1BqgXKUdNFcTjE6LHkcYIorjkQYO76UhnhfAIdt3tYc x1/XVRVPYsRS6UFnH5zuaZwKukqebtYtY2dWHErZLGL+jI94n1UBKNbFijCnR3BtC5f32I 8Qo55C+V3gra/+OEI9oVm8UZEB9g//U= Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-d9b9adaf291so4466551276.1 for ; Tue, 02 Jan 2024 10:45:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1704221117; x=1704825917; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vjVmfRb4lmSQIEbZDNGApWLh10nZ5LL8tfeNBp5q+Ow=; b=l8nnUOvUThQigl0+yv7okbs/fYl6Etn+/BYsu1GcC9myF4SRirBEQaPdWDCxbYnDUH HwW7c9/5Gh5LVG9AhOTItT8BglAGxhTHDaF4Sr3AnJTjrvGk3wGO5mrOaGv7JyCIUnHX gR9nYSnt7SWSOYWkvbF/ph/b9r0AVS/6rPpRKjX6ypEL3dXNdJz+0ooFyTqd8gEy4cmP vrq8T6MPkiCBA+VAXx2YW/Ro5ZXIzvpAIq43qnylI79q8FzaPW/PBOqHip+cK/fZigSO q1u/2VAevOyOUeyg2Ir/181ZRGG5inCIDcytchjq36L70nVCHiBoYtw3M98jeTJbfPI6 3z5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704221117; x=1704825917; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vjVmfRb4lmSQIEbZDNGApWLh10nZ5LL8tfeNBp5q+Ow=; b=lPxSzUIOHj6/n5exXRkHdzZyjDhQlFjtL8svki+mEuf4aEg4QrGWB4FyzeOHHiMlkJ e40TRY3frqgRY3qwO/jgNrCF+pu+ygQRiDDg6tGkzsCX/F/E5KqI0gc+PjS/JxC8nQLa Xgdr5ePjqI3HksdVehLT0CieZvDG5mpXtS/QWHh06fKXfRdPOwxsqOwu8yF8lRlf82Jr nAR616PCj9rpGP8ycaSdH4R7Do4JBsA0NgaeaXpVwK3PrKjduYIyYIPC4aEegZktrTLb mWxOOa1RP4sh4qv8nUgEG6y8ktBq1cnE6f+Ibj+DpfXozQOoykOD3iAx9QkiVWXrhqNq R0eA== X-Gm-Message-State: AOJu0Yzabkfs7ZfhMJpgpYCtJJN6G5KPK/FliikS7DBJVtid7D5Iq0N5 83YGCccaXbeWn0IbtuwjkrofS6PO2p3spS1S+Yc3BxgCemq2cQhctoWjMg3XAvs= X-Google-Smtp-Source: AGHT+IGLuB7cRoNhgCe+Q8pUixsF6gjSJJvEoxyK9Hh+eUGbYV2c2G9Z99y8hRHKLR6/zScsyFW2p6yUKbe0INgeFvY= X-Received: by 2002:a25:e90c:0:b0:dbd:b59f:217a with SMTP id n12-20020a25e90c000000b00dbdb59f217amr5574774ybd.17.1704221116966; Tue, 02 Jan 2024 10:45:16 -0800 (PST) MIME-Version: 1.0 References: <20231222235248.576482-1-debug@rivosinc.com> <19703a88d00b6e2d9b6ce2bf911ee34d465b1a11.camel@intel.com> In-Reply-To: <19703a88d00b6e2d9b6ce2bf911ee34d465b1a11.camel@intel.com> From: Deepak Gupta Date: Tue, 2 Jan 2024 10:45:05 -0800 Message-ID: Subject: Re: [PATCH v1] mm: abstract shadow stack vma behind arch_is_shadow_stack_vma To: "Edgecombe, Rick P" Cc: "broonie@kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 5ze5sj4z44i5w1wrzjpwckbzibjhm4fh X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0ECCB1C0009 X-HE-Tag: 1704221117-890092 X-HE-Meta: U2FsdGVkX19pptNyD8MB97dvrurh3q0/4nzBlO/lip48earileuWw7f/BrGem6XnXUa/9ZtvPebkPD5ehIsFe04gIAcQslv62WJJr1yBlAOdiWRo0tYhn836CNGNFzBgIVldmn08wdLJZkdfJKtbQYVAvbrkZe54GF8fD+JF2Q7Iy9uVwhZvTCaMru2HUf1SV8DKkjtSDp/jQBGWxURFWD8VQWX2jM348xdUB6IN33nExCc4iCPt+qifvS2AVdAheZmlOsC307TCBphbX0fB95DUkC+vUXzWrk/IuUyVRv16K64468f8efqibz/FPEKggB3WhTqRyZia4iRToAhxYhwTMCE0cK4+DNbO3BbAfEqLv8yomFzwbFKbwHqIOJkYOflL7jHUNY6tssNCtsFtOgI1t2LKjxVUUE/EWIZ6EIM7DdDGiL6Y9P+tzIBErOiA9cLvreO8aaYdhyoJsO4PxlslWK5AgIrEec/LucoD+Ugw1vIqh0iXZxU9O8pl+NTaNLozUSmWE/YoOZ/kLSVsMON5uYZcA61WBdrDoMyrZ45dWODDqVksFG/S1ah3Pnl5QoN/YKP2Ve604MbnPgeQCShOGycBNXyo7H8hr2C/qVXEr/pV8V1FBzZnHK39OLVt84aZ7ZB9znYqnj6uIsJf2JCFP5GD0ZiOBk0apOtlPgLtO0ZpeFpRkYbIuFrxjN7ov1sfeHsl4ZT9d3IJJZBU7rkNa32AKrejolep/5TLnDWvqf8MTTR706SWxVp5RuCWDk3EVdJkQUJLnQGIGnl3eaSuA3tBZQY5x8jLVBth++l0UH06vVfcU0ZKj7ZyL6B6REDu/mD/Q9G0PdDeGFWUpclNviV4hiJyWK7YMWn6eCyTLNG/+TTFAz2g5D12DA5FXBE8sgqN4BffGr51k/LyJR0JqdHFSV/0UkKuk6xjcZaTSDo/lOc7VAvWq7V+h8+gWjqk7a3HGdNg2ZSJJzN 8FZ8oGdG ahq5sNDNohfPcNNGPiHv8mZMCRIhEojzfvf+MM61UEjA/VpsqBAiBEHSn9bL22MGFxwBDgug6fx4+sdL6/FF24amz6RoHWJmNGODBldUuRGJ3MqD1/e92FIkCd6Meb+0zRFw0IeFrqrcGP9h6M3ODLRlDE4VZO6TSXd5BOOJuFyh04Soi5Bqg2P/VhZeMiCdJmnjbX25uToJviaURlNy6EL8erBxomck/jG+3qs/RhQ52Jen5/SH0j0lfVJd7t76j2KAao76oqtz9mDlaquMe2fd3qEHsj+Rgw4yyeCXxmyKbXW/k2Dow8Cu3l07Mjc0F2RrebWI9PWplnQuuWGBCwci4RF8RZGwfKALbSYY4tSbjtTBeuL3Q+GFwhkH+kH3UgU8jIjPKse+onaaFLJpn4PIyK9FcT6Z39W6p+Y1wvfXnymCq0VFVVv4LUr2D/KRWLWX5nggSeifIGuM7EcmtqroaDFtsbeNKxINyWamUkaAWII0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.010953, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 2, 2024 at 9:50=E2=80=AFAM Edgecombe, Rick P wrote: > > On Fri, 2023-12-22 at 15:51 -0800, Deepak Gupta wrote: > > + > > +static inline bool arch_is_shadow_stack_vma(vm_flags_t vm_flags) > > +{ > > + return (vm_flags & VM_SHADOW_STACK) ? true : false; > > +} > > + > > The bit after the "?" should be unneeded. I would think that patterns > like: > > bool res =3D val ? true : false; > > ...should never be needed for the kernel's current bool typedef. Is > there some special arch define consideration or something, I'm unaware > of? > > https://www.kernel.org/doc/html/latest/process/coding-style.html#using-bo= ol Thanks. Just checked out the link you sent. Yes it's not needed. Will remove it.