From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A53CD1288 for ; Mon, 1 Apr 2024 17:56:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6750A6B0085; Mon, 1 Apr 2024 13:56:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FF2F6B0089; Mon, 1 Apr 2024 13:56:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49FB06B008A; Mon, 1 Apr 2024 13:56:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 284866B0085 for ; Mon, 1 Apr 2024 13:56:10 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BE8A4408BC for ; Mon, 1 Apr 2024 17:56:09 +0000 (UTC) X-FDA: 81961716858.03.CF4FE21 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by imf04.hostedemail.com (Postfix) with ESMTP id 00BA040015 for ; Mon, 1 Apr 2024 17:56:07 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=qPau9wGm; dmarc=none; spf=pass (imf04.hostedemail.com: domain of debug@rivosinc.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711994168; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ayg8yEodnyIkhrNKh0vWxZ555hD22ZpFvhWL8Rikvao=; b=lZPgOgHbS+QV54XZQUOa2OywNMDD5ei4oRKM3f8UYhqIinuXqZ7txwO0/0QLQSLZlARkae C9QC5wnYhHC2wEh58edUJHrMNLMCfDemXV2yEQ+Qeek9EZHtzshcIgL8VYKY0Wtrht3OvL wNyeJVCc64tBfMKoFN5afh8n3LiAqPE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=qPau9wGm; dmarc=none; spf=pass (imf04.hostedemail.com: domain of debug@rivosinc.com designates 209.85.128.171 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711994168; a=rsa-sha256; cv=none; b=UsjGbA5E3QCd98/Hpz8vdvNcT+ZsdB4YC3SgQpHpIG3TSCwfiWH9E7ZjhPEndpbMXchft3 Bwdmg3sK4V8t9KbWh8hpa4nGUJ5lxwufyU+sxrb6s5ESCsm5J7Ta5/UuxgFXf2urc/4Xs2 hlxQM1FLtTOfY2kKe13RICwyIpA0OB8= Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-6150c1fa3daso4845757b3.1 for ; Mon, 01 Apr 2024 10:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1711994167; x=1712598967; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ayg8yEodnyIkhrNKh0vWxZ555hD22ZpFvhWL8Rikvao=; b=qPau9wGmzD54gOm6yOl42ohVEVQVtr/bkn+0juyYnoLez9T3SW3ttf5JmzfbgNBSpN ZbamSwhB7O3S7minAUO8OF6LIJCtfFBJ3Z1kvC86k/avyxIBwrzLrfw41SfVcohh8ywN i/t/uAfDWgsR9lx/KEm26AkRfMTvhfZ77LHoY7749gBtW47GTcSbbRHhulvHFe4NUVn0 ZpR3cjT3+f/wx6ABthQ/bsqnwTdgOn4RV3fJgoq4hnWjUTQpSr12zDocmOVrfiY+EABf TzHIDEtEMJMqN52HNDIdG08Narlpj/JRx2WyZKrf2rZI5SCz4tB4Z3fHtyrNGmxkPcYF onqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711994167; x=1712598967; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ayg8yEodnyIkhrNKh0vWxZ555hD22ZpFvhWL8Rikvao=; b=tSJSeOXasnIvb4VabL/GJIPtho3ngVxjPMyaZS6mZk5OtHhIInMV2w4niPoPo3GH0N 1xInEj7sXwZ0qqy2M8bpRqonSZoZw1DZ/c8NUzhIvECfikeHKg/9U52RiYQQ+mxK7N5W wytSaS41ehoiQTXnAor//12llsbB+LcLYAPuIS9DSEueBLjpjivGdo3WAgQeN6ncTzar +1ELEaiDhy3NRLjnKi1I8nOoMi+b+YiAsBTwpKSPOh1OopWUNzsuPWCH8KMBbwtZJXj9 +kyDxShMSPmX0qtICEQi+yTaJYlyUrvWzQSjHvkyGPsimwdgp9NTZLKgbO063zZIElr9 Lp8w== X-Forwarded-Encrypted: i=1; AJvYcCUcOi88VU8eFmP3YjwKAaYkGaETtrZKvpxNLsnjo8RFI9viM17lPVE8F86jvzXk+kgUkbxnjN8DghyBHD4DIdDxLNQ= X-Gm-Message-State: AOJu0Yzdv9PAZojVQAUq4DDOSu3aAbQZEEuZAqvUMJrbT2qnTHJmV3y+ EJMzC2fOqx2Ix2XB0pwWJP3WCPFFBFEypWy2ctaZqghI+UObWHrps+2/ws8OOcNYZU/JDZNBlqI RIJz+UZPayYP4v1PNdZXR1ug6pJ4x+liHNUEy/A== X-Google-Smtp-Source: AGHT+IHbNEbSTz8DBCYKR9MqO/caPtbEZWICPniiYQejcusJBa6iSdkbnh9sfMt7GjtTJc/3SigyJ/z+M6qQOU/SrM8= X-Received: by 2002:a0d:c984:0:b0:611:a5b:337f with SMTP id l126-20020a0dc984000000b006110a5b337fmr9528979ywd.10.1711994165573; Mon, 01 Apr 2024 10:56:05 -0700 (PDT) MIME-Version: 1.0 References: <20240329044459.3990638-1-debug@rivosinc.com> <20240329044459.3990638-28-debug@rivosinc.com> <4b38393a-f69d-4a77-a896-b6cd42c7edcf@collabora.com> In-Reply-To: From: Deepak Gupta Date: Mon, 1 Apr 2024 10:55:54 -0700 Message-ID: Subject: Re: [PATCH v2 27/27] kselftest/riscv: kselftest for user mode cfi To: Muhammad Usama Anjum Cc: paul.walmsley@sifive.com, rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com, samuel.holland@sifive.com, conor@kernel.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, corbet@lwn.net, tech-j-ext@lists.risc-v.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com, shuah@kernel.org, brauner@kernel.org, andy.chiu@sifive.com, jerry.shih@sifive.com, hankuan.chen@sifive.com, greentime.hu@sifive.com, evan@rivosinc.com, xiao.w.wang@intel.com, charlie@rivosinc.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, dbarboza@ventanamicro.com, sameo@rivosinc.com, shikemeng@huaweicloud.com, willy@infradead.org, vincent.chen@sifive.com, guoren@kernel.org, samitolvanen@google.com, songshuaishuai@tinylab.org, gerg@kernel.org, heiko@sntech.de, bhe@redhat.com, jeeheng.sia@starfivetech.com, cyy@cyyself.name, maskray@google.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bgray@linux.ibm.com, mpe@ellerman.id.au, baruch@tkos.co.il, alx@kernel.org, david@redhat.com, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, shr@devkernel.io, deller@gmx.de, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: eewnoz4ddufdqfcs8zkstuugzdb83xhz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 00BA040015 X-HE-Tag: 1711994167-971282 X-HE-Meta: U2FsdGVkX1/YUZsBVm3CbzT/cpHCpk+KbZTT7O9ssuw1n1vNuaun9FfGeisUvHuDGSiH+P5Va5PzNbZwUkveIkjB7NudLT48AcYIp20BVzT07aenBqyqjvdskQbwVhj7ehJ6Y+r1Bf5U2bqsh0J3YXDxLhHMt2XTlCXX11o7P79hlqvmffzJjD7yrkGalPvgrnumO3MPv7AZ822fUQHljmnrapnL40oahzLgI3z7hmeFRVcXf+Y9xz/QSBSAg/zJ3n0P9rW3bkTJGHa83jkKEnCb0N/iZUyBN+O+fQXWAMbKxh9vYtJZCkYifmnCXAWkajzXwZ7+ki6UrH85ABYjx+HOmxXopfFW35VaIb8VHG1bZn2xASRp/G0ZNvNNPWGPjfcs3P3yg4jesQGFHQdeeKPx6av+pdeJy/CCYItChywtlTBrkltGOotiDmOREDcEm6qBWMQFwA5Ry0rN2ojIP4cHlwVVWSaPp5xoiy+mRjN+hFImfCM25pwQTmCfK3ie1ljvWj8VP56Sxitd6eFi7xjXd2cTUXl/Mrli8opnqTQwPNJw2wb1Fs6jDy2I3Z+XNAbRZ2FYZOVxb/yobtsy8i73CXlWLXKlYF47fVME6IxZ45aapVGiPhlkYm9Af1VKhwmE4ORgjrl1DD1JBcLIlHKgcdrdo+k8Ckq7NwWqBLeCmkjb3pAw4KMiOrqlbmx8X2mGPeDQSeyhtAphn352DilILsVC3WnKAt875AYNJ8AZwWEY72o6eg7R5BeYYCeNEqkX/WS8gbMX723i/YYqyMzgqc4ZYe0Ae/cbbTaga6Mx3N01LT8y9hXZ5QOGZiMC+fY/YXEXSNK12v5oknn46xxGqkAo26324hsGIrjw7updYMyFiyks3kuYR59CRJW/kb7QSJFqvGUkP3gTdDxUfOH14BhLglJklyEN2tLrVNj/fZFollNsq6v8vAGWzz3S4pJzkBisK9piyuS6b7l JhhO61Em 0AIiu9IYLcbaStM+LtGMu7vJ9cY+dpDMHINZisP6365VFoMkitG2Hl0Rptb8mGlITplO18BOjhCEDSmYpa5asUfjkK6v0EBuOaJ6AnIpUKWqrJnzOOhXVluBhnKH9EGzozG3GcoK460p3Dc9gD6Arf+aYeYwwkFn7Q0rZAofXPlvRQOiLdwS+4MhcihJBpj4oG0jCCeyeoo70kDPX4h38GkylnyztgdUVPcL7ROo8R/cez2dofPFQJi1ckLohyBT8PMYxJ8JFKtHJuxacbmCFBFmiKc9CqUCTCz+uo2NlJvhMftroM2u936ks/LVmSlr8LD3i/h2MlW8VWpSMcs96zzt89/KvuGauw51ovvPdqkmOKQOb0YiFuuXOvDM8Tls2GoqRMwdyK0t0QOCH0bkzCk1SEUrkFRp4VU0VR4/kghJdcn/yOIja7WKdeIBtUhVaG+gjLfzXBBFjCelDaIV9Zm5YJg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 1, 2024 at 10:34=E2=80=AFAM Deepak Gupta w= rote: > > On Mon, Apr 1, 2024 at 2:48=E2=80=AFAM Muhammad Usama Anjum > wrote: > > > > >>> Signed-off-by: Deepak Gupta > > >>> --- > > >>> tools/testing/selftests/riscv/Makefile | 2 +- > > >>> tools/testing/selftests/riscv/cfi/Makefile | 10 + > > >>> .../testing/selftests/riscv/cfi/cfi_rv_test.h | 85 ++++ > > >>> .../selftests/riscv/cfi/riscv_cfi_test.c | 91 +++++ > > >>> .../testing/selftests/riscv/cfi/shadowstack.c | 376 ++++++++++++++= ++++ > > >>> .../testing/selftests/riscv/cfi/shadowstack.h | 39 ++ > > >> Please add generated binaries in the .gitignore files. > > > > > > hmm... > > > I don't see binary as part of the patch. Which file are you referring > > > to here being binary? > > shadowstack would be generated by the build. Create a .gitignore file a= nd > > add it there. For example, look at > > tools/testing/selftests/riscv/vector/.gitignore to understand. > > It's `shadowstack.c` (a C source file) and not a binary file. Nevermind. I think what you want me to do is add a rule in `.gitignore`. I was thinking otherwise (that somehow you're seeing a binary file in patch set). Thanks. Will do that in the next iteration.