From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68742CD128A for ; Mon, 1 Apr 2024 17:34:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EA606B0082; Mon, 1 Apr 2024 13:34:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59A516B0083; Mon, 1 Apr 2024 13:34:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 461706B0085; Mon, 1 Apr 2024 13:34:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 23D086B0082 for ; Mon, 1 Apr 2024 13:34:17 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A7A54A09D4 for ; Mon, 1 Apr 2024 17:34:16 +0000 (UTC) X-FDA: 81961661712.18.24AFCB9 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf04.hostedemail.com (Postfix) with ESMTP id CE63E40002 for ; Mon, 1 Apr 2024 17:34:14 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b="y4IUx/61"; dmarc=none; spf=pass (imf04.hostedemail.com: domain of debug@rivosinc.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711992854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q4MAUcmgMKuhD5Gbh9i7N0D2vbnfTkjFUipl6Ki2fa4=; b=FY8A2nGx7sZGrsf0D047SaWtK+fkmpmyphYb3YcZPTeWVfNrEmvqBwjChUShoav7Ct5aeY ZKl/Bn+ZDGazyGcdWHEufg+10Tdz6H0++2GKMHS1lHQRhOCUNIzGjj2eru/8Vc13tKt9a4 gH3rlOugF9zScn+xNQeUeEh+zSDhwoM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b="y4IUx/61"; dmarc=none; spf=pass (imf04.hostedemail.com: domain of debug@rivosinc.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=debug@rivosinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711992855; a=rsa-sha256; cv=none; b=AzN4YavtQiMfWqwUbxtU/tEmR1uTPFyGbGd17sKR5gJOGnaIarkqXB2eZ8SMLWjUPfSggI V4u6PwvXZBZqKxZ33oMwZMqChK7Q5DycCMHrKpkugQu9xsW4wDxzxUPeRX/FyDdmZCYwjN IZVAuV+LVPumkxSqu9qKRjsjeVkJjuE= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-615053a5252so4176047b3.1 for ; Mon, 01 Apr 2024 10:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1711992854; x=1712597654; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q4MAUcmgMKuhD5Gbh9i7N0D2vbnfTkjFUipl6Ki2fa4=; b=y4IUx/61BN4rK975Q8M4pUJhH1MmbKArPUB1e4StF1vrh+bAr/8lU45ZQrTsbTkPce +Xessf0dWaBkm9yr3tNNURjLpBFNx7FWFcb3HPk2xwuUdHdDwsufSSEENeKsNL8M0TwI G9E1NmEWkwN/5YkYn1DhAhX+0qwHLkrZjzntrSQDxH83Mq5snnpIU1WZFY4fzBCDedcE sxUhlaiiTRXyigVtxoXRhP0F6lM1s64WWnV55Qa9++NKI2y3VpQZHxNTb9aMrxZnENm/ nQ862M4UhuvxWUkk5vByM/T3Vb5yl7JSlWemUJceRbat6kkRVhI1H1GndZ9gsVLjdrDo 1D3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711992854; x=1712597654; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q4MAUcmgMKuhD5Gbh9i7N0D2vbnfTkjFUipl6Ki2fa4=; b=fIQOshBPZRT001Z2BDXWSSoLgKLUWtP/bSAgAJxE3YYF1Ijs9KJJMbksJ3FWMYBsL+ dPmx0+BBmIYblPs3uqtrxNLx4q38tis6+GHCWAleQPZtp2mAwWjTP9AYAuRFtcbJcCJM BR4EojAONNKJCTzAANdufbi8DKhRG3Ujn11eOtsWdIqD8wbg3zYAPvE5zGNUSzDPbSV2 bYhzBITdmBDyckpCT7xRGaoAysZPBOBoZNEHR83mQZ4v+zhliHMAi9mLsosdc7fQ5LGg V9tXs+chxyh/8CAGFr44zGFNFRO+AxxdWqzVbVbOkctU0cY40hok8dr3ST53b9u4YT7M p0wA== X-Forwarded-Encrypted: i=1; AJvYcCV+fdE3jpmHN7a0r2IqlE4C0LrVklnmP6Xbs+e10ABmxe7YL/wjvY6gVaxO+8nnOwJxv/JLW8Ym8queLfuMRdO9HaI= X-Gm-Message-State: AOJu0Yxq0OCWkn4XXTvEBCYaA2uauDma0MGAb/ABsAOC6oP5VqbvbnAk 76OpEcyM8gwI/MPJL2NUjaXOlYtM3U5lCXIspcYi0DxMwHLRz2uT/HyVUTBO6SXJEgohzHeW/cB ZM2ghTJE58bjExtaQW3ZyK6/ASe+rYN6MyCBH8g== X-Google-Smtp-Source: AGHT+IGWLd+uB6H49i9ExUSpS3d/6MA4XGgkBBQBM3nTLsDV2PwbysZLh8i9VvQ3W9VGzIjrMeAWK2hXdQjjikUWmc4= X-Received: by 2002:a81:4849:0:b0:615:19b1:5367 with SMTP id v70-20020a814849000000b0061519b15367mr22572ywa.6.1711992853801; Mon, 01 Apr 2024 10:34:13 -0700 (PDT) MIME-Version: 1.0 References: <20240329044459.3990638-1-debug@rivosinc.com> <20240329044459.3990638-28-debug@rivosinc.com> <4b38393a-f69d-4a77-a896-b6cd42c7edcf@collabora.com> In-Reply-To: From: Deepak Gupta Date: Mon, 1 Apr 2024 10:34:06 -0700 Message-ID: Subject: Re: [PATCH v2 27/27] kselftest/riscv: kselftest for user mode cfi To: Muhammad Usama Anjum Cc: paul.walmsley@sifive.com, rick.p.edgecombe@intel.com, broonie@kernel.org, Szabolcs.Nagy@arm.com, kito.cheng@sifive.com, keescook@chromium.org, ajones@ventanamicro.com, conor.dooley@microchip.com, cleger@rivosinc.com, atishp@atishpatra.org, alex@ghiti.fr, bjorn@rivosinc.com, alexghiti@rivosinc.com, samuel.holland@sifive.com, conor@kernel.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, corbet@lwn.net, tech-j-ext@lists.risc-v.org, palmer@dabbelt.com, aou@eecs.berkeley.edu, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, oleg@redhat.com, akpm@linux-foundation.org, arnd@arndb.de, ebiederm@xmission.com, Liam.Howlett@oracle.com, vbabka@suse.cz, lstoakes@gmail.com, shuah@kernel.org, brauner@kernel.org, andy.chiu@sifive.com, jerry.shih@sifive.com, hankuan.chen@sifive.com, greentime.hu@sifive.com, evan@rivosinc.com, xiao.w.wang@intel.com, charlie@rivosinc.com, apatel@ventanamicro.com, mchitale@ventanamicro.com, dbarboza@ventanamicro.com, sameo@rivosinc.com, shikemeng@huaweicloud.com, willy@infradead.org, vincent.chen@sifive.com, guoren@kernel.org, samitolvanen@google.com, songshuaishuai@tinylab.org, gerg@kernel.org, heiko@sntech.de, bhe@redhat.com, jeeheng.sia@starfivetech.com, cyy@cyyself.name, maskray@google.com, ancientmodern4@gmail.com, mathis.salmen@matsal.de, cuiyunhui@bytedance.com, bgray@linux.ibm.com, mpe@ellerman.id.au, baruch@tkos.co.il, alx@kernel.org, david@redhat.com, catalin.marinas@arm.com, revest@chromium.org, josh@joshtriplett.org, shr@devkernel.io, deller@gmx.de, omosnace@redhat.com, ojeda@kernel.org, jhubbard@nvidia.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CE63E40002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 48ztzt9ho4ey6ehpi666f1z6xa1osr1u X-HE-Tag: 1711992854-385639 X-HE-Meta: U2FsdGVkX1+GrIYEnVzhmQ39Le9V7GG2CQH3Iar8wiP43qEL4/QuTrv7OnFEKui3ir+GMS4SStxWM5zDFWhLB0e2ahCLOaNaKPdjxF4T38rEs5eVuR/M4T0x1IoST7sVEwMbn4lJhx5iF/vIChEW3q+iwsF0YMGTC4a7OdR+yoc0/CoQ30mTFh+bFrtWOt+JPSOjia+cPJxjNeGZd96sO1XXH3/6GH+kaNHkrLtbdLdh4kdJ6Sb/gc3B8+PuVYgsOl3Dr2t91n7YAKhqQnHXrsgMcWHb5ND7J/xwfkLnEuYCHwplZej6eLXkVWoc/fSb1HA7RsyW4RYrKsdTG0Y5y8eWyzkf22VK+u0iaFmpTreGPl7Zha4QA7eyVq+HxFUWTz/ILvecUki51KmzJIPNeu907lJXunutzsnyeowZGrroB91kk/IhsIMOBSRpTRsIPUGz0d05Ut6kBNLXklDi19Su7uP1aZF2kXR05XKwibB7lYorQmQ2MkSOCaaMqBlOeoienWgsR+ey54DtWbOJTORN3xwcNTWcZADgmOWwEVX/JSFFpFZfJbhr6Yd6Mp5rL9REzFaqoYFTSEm+2cQnC9odknNV1KuKttsz42I2UUK2mdNZMaSstsQrq29eeI5EF02CrTxPXH4c7F4/q5YJZNpJarSbvdM8hRsCi9QiwILphAxr8cFBgbEyvoSJiHA1x6jecOkufFyHLhvRiYRAb/txv2Afhd4eBNyfMyo+ib7/wvSijNNlzY0Ji2rZqtRfqEeo3KYLSE2tmnwfDXPuD9CfWPmY2R8hPYDyRuIp+XIxFlUAUu65v8RgwlWpCdNt+eRcmZ6lWbEDGn7J5G4vodQvm45IygL24DgU/KzJsTnHScGRmDs46onbIJRPPeqnoLD7aQg+tX3FURBh0s1axk9nTH7LrVaE5p+CM9EZICnJFTmuZNTEhW4Z4u/A0q5p5LNOjLJSHATubAumdU7 lA/9+ErA pdWbC8S0MHhL9Un1z0d5rnfoEimY6Fw22NkMmS6eVO0geSWTHV+Hp5tFgOiy96Z1nZjMl5tNuaphQ8jQq3kN9tOEdnnEsI0qzSlTzwVapsHYNcXCUDcQKp3QtMmAICrWRjpFFaZm/ddW4XgqRNxTjHfuqKwUcZhsDL/10RLFsqhVJuPHh5pKtDV9540yxKyG3MdoBMKTRGvmVzMAmWu2TcGKq0kdk1G7Ffu6RB5h9T/wmnFuwf3YkzyTGztTxRmcU5fT8Zp7PQ/RoX/L+1Gxqne/rBZdVJlnoT4Io5Hk5aNCn/ThIj+lmVoETYLX5DbuS/pR3mlNdD0pNdK2aRZyapRDXp83jjbvOTlu0zFkYM2xQxLwbISSjB1bG2e9gDZyTw+ZBahj3OnINSzasWzSyb3fAwDr+fjnW7/eEn03AdbZCa6fcHjzmYVq3usARgTVvSl+Ccrj3UjNXmFZRAjvu/w9IEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000089, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 1, 2024 at 2:48=E2=80=AFAM Muhammad Usama Anjum wrote: > > >>> Signed-off-by: Deepak Gupta > >>> --- > >>> tools/testing/selftests/riscv/Makefile | 2 +- > >>> tools/testing/selftests/riscv/cfi/Makefile | 10 + > >>> .../testing/selftests/riscv/cfi/cfi_rv_test.h | 85 ++++ > >>> .../selftests/riscv/cfi/riscv_cfi_test.c | 91 +++++ > >>> .../testing/selftests/riscv/cfi/shadowstack.c | 376 ++++++++++++++++= ++ > >>> .../testing/selftests/riscv/cfi/shadowstack.h | 39 ++ > >> Please add generated binaries in the .gitignore files. > > > > hmm... > > I don't see binary as part of the patch. Which file are you referring > > to here being binary? > shadowstack would be generated by the build. Create a .gitignore file and > add it there. For example, look at > tools/testing/selftests/riscv/vector/.gitignore to understand. It's `shadowstack.c` (a C source file) and not a binary file.