From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 386D9C433DB for ; Wed, 27 Jan 2021 22:36:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BF47F64DD8 for ; Wed, 27 Jan 2021 22:36:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF47F64DD8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 07B696B0005; Wed, 27 Jan 2021 17:36:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 02B026B0006; Wed, 27 Jan 2021 17:36:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E83156B006E; Wed, 27 Jan 2021 17:36:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id CD0FB6B0005 for ; Wed, 27 Jan 2021 17:36:41 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8560B180AD838 for ; Wed, 27 Jan 2021 22:36:41 +0000 (UTC) X-FDA: 77753015802.11.brain03_2b074322759a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id 38333180F8B92 for ; Wed, 27 Jan 2021 22:36:41 +0000 (UTC) X-HE-Tag: brain03_2b074322759a X-Filterd-Recvd-Size: 3396 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 Jan 2021 22:36:40 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2BE7B64DD7 for ; Wed, 27 Jan 2021 22:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611786998; bh=4xDf1kIQfdD+/0DKjaNAYSWNulamOzwTvt/dOjpQOKw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bVXZ62brHhthxPi4Yg3se74VZHO+RCRm4kNMsAoeEAmp3SefMgDzenGz7rUysVmkJ 3KC5NVkkYum6joJiqhB/+z+N7faTUDnJDlwn0L4kF72NIFoKthXoaUtgy7IfZwv4bf RN7VxPQp25ViyG7qy5Km4OVvY9quwn85b/RIxjmxTv+gPoR8qcY1ts/yXot+bN3t9E LcaYiXDjIFmHZHb0TlK1PRUyZ85iPpB375JF6WOLeoRlgIY27Hnm0+62bw636h3AZ0 LHoB/8NaWlpiC1psQmUULh+wSnLCFYcUdJpYfTvJRC+M93V0m+3z53c3dp3bKP9mBH AGlMuMtsxrWGQ== Received: by mail-ot1-f45.google.com with SMTP id e70so3336917ote.11 for ; Wed, 27 Jan 2021 14:36:38 -0800 (PST) X-Gm-Message-State: AOAM531ZOIHmewiwMpvClKOXLChT1oZFmN/MkccE4QPsvKBF1TeN5Cs+ SdXA8ogIKh6hGjjMKYFfjyPVYo4IRfAbnFb2gq0= X-Google-Smtp-Source: ABdhPJzDCowXa8XY6WxBMWr+0d0DA1axhb8zK38NhhukzF1pqUiVvL4QdnU/WgZ1PqhqNToIJC/IEP1HyQbX1F7OZ4A= X-Received: by 2002:a05:6830:139a:: with SMTP id d26mr9405785otq.305.1611786997504; Wed, 27 Jan 2021 14:36:37 -0800 (PST) MIME-Version: 1.0 References: <20210125112831.2156212-1-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Wed, 27 Jan 2021 23:36:21 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kasan: export kasan_poison To: Andrey Konovalov Cc: Andrey Ryabinin , Andrew Morton , Stephen Rothwell , Marco Elver , Alexander Potapenko , Arnd Bergmann , Dmitry Vyukov , Vincenzo Frascino , Walter Wu , kasan-dev , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 27, 2021 at 10:25 PM Andrey Konovalov wrote: > On Mon, Jan 25, 2021 at 12:28 PM Arnd Bergmann wrote: > > diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c > > index de6b3f074742..32e7a5c148e6 100644 > > --- a/mm/kasan/shadow.c > > +++ b/mm/kasan/shadow.c > > @@ -94,6 +94,7 @@ void kasan_poison(const void *address, size_t size, u8 value) > > > > __memset(shadow_start, value, shadow_end - shadow_start); > > } > > +EXPORT_SYMBOL_GPL(kasan_poison); > > Should this be _GPL? All of the other EXPORT_SYMBOL() we use in KASAN > are without the GPL suffix. I don't care much either way, the reason I went for the _GPL variant was that this seems to only be used internally in mm/kasan/ and lib/test_kasan.c, unlike the other symbols that are meant to be called by other modules. Arnd