From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B9FAC433F5 for ; Thu, 21 Apr 2022 07:12:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F8BA6B0073; Thu, 21 Apr 2022 03:12:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A8BB6B0078; Thu, 21 Apr 2022 03:12:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 070616B007B; Thu, 21 Apr 2022 03:12:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id EC1DA6B0073 for ; Thu, 21 Apr 2022 03:12:35 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B5CEB62D14 for ; Thu, 21 Apr 2022 07:12:35 +0000 (UTC) X-FDA: 79380018270.01.39CC91F Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.13]) by imf27.hostedemail.com (Postfix) with ESMTP id 29F2040018 for ; Thu, 21 Apr 2022 07:12:33 +0000 (UTC) Received: from mail-wm1-f41.google.com ([209.85.128.41]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MuDsZ-1o2H8821SH-00uaFy for ; Thu, 21 Apr 2022 09:12:33 +0200 Received: by mail-wm1-f41.google.com with SMTP id l3-20020a05600c1d0300b0038ff89c938bso3338573wms.0 for ; Thu, 21 Apr 2022 00:12:33 -0700 (PDT) X-Gm-Message-State: AOAM530uDQMR3NBPdy4nDF1UcKNeQzkM8nH+WJBlvBw3Gw9DWfUlrCF4 RTjffzmJvxOQKb9YRwhC91thLmu5QBppKmmmYao= X-Google-Smtp-Source: ABdhPJyiDq8vDuHIbY6D8eienOMlm5JvlAwo2YuDKmIos2MBFwy3hSQ+D3GAoUjwkE1kjA32vI2wLWEQWYui85aMEb4= X-Received: by 2002:a1c:f219:0:b0:38c:782c:3bb with SMTP id s25-20020a1cf219000000b0038c782c03bbmr6996684wmc.94.1650525152760; Thu, 21 Apr 2022 00:12:32 -0700 (PDT) MIME-Version: 1.0 References: <20220414091018.896737-1-niklas.cassel@wdc.com> <81788b56-5b15-7308-38c7-c7f2502c4e15@linux-m68k.org> <87levzzts4.fsf_-_@email.froward.int.ebiederm.org> <01b063d7-d5c2-8af0-ad90-ed6c069252c5@linux-m68k.org> In-Reply-To: From: Arnd Bergmann Date: Thu, 21 Apr 2022 09:12:16 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] binfmt_flat: Remove shared library support To: Geert Uytterhoeven Cc: Greg Ungerer , "Eric W. Biederman" , Kees Cook , Niklas Cassel , Damien Le Moal , Alexander Viro , Paul Walmsley , Palmer Dabbelt , Albert Ou , Mike Frysinger , "stable@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-riscv@lists.infradead.org" , Linux-Arch , linux-m68k , Linux ARM , Linux-sh list , Yoshinori Sato , Rich Felker , Sudeep Holla , Vladimir Murzin , Jesse Taube , Giulio Benetti , Patrice Chotard , Pierre-Yves MORDRET , Alexandre Torgue Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:Rz+UOt1D2jurHxXFjtc8vSTurl77xCTUvyG4Lj8yj7PRs+fi0q7 52yVObQ8vLiY0vmTk2rD/p5rtzfhnwyh9/yvrUKS/EiI3mI2xqQEZKr13Aix/0uqyXSj4c3 7nM09R/IRQzw0vIlKpZiu7qo68AxPwlHsTEEWOTYR/HpBszzQj0O2PQbt2VZyjlAmCqs7gw pq9lHo+fNCjADNciCc+Sg== X-UI-Out-Filterresults: notjunk:1;V03:K0:jBrSL56ITGY=:TeCjEdxi+4HYactQqLTw5e VBcD1tCRm59pc32FhFyWZynnFATJTPA4B8gNCx6pmbrvbBCqHxqcDIpPH67bBvxb66QeDcqhk O9UUVAHsuzfpLLeYU5S6ekLFqIx8WWE1w7HzMIRCLrsd/wVE08trHAmePGAWRqVxORp4A+Zvr WxmtUoyhk+nKhHpN6+7RjRFf7TfIsLLTMKzTyIGq9Nyr8wckJ3VTIdwrBc8oROg7tcEe4Q5uM 3aY9E6B9vDf44s3kcnfmzT7yGK+32QXPSkQml+KF5WLerZF2I1wETPzCVPmV5wQ96j2ZMqvAU xP+WWL1KuFJcPDFsF/puoGA61B/fJg1BOiZmivj2krU+nTQSAxJ3tuhG+XxH6tD0XFdFj+u0C lgDOPimvDPsqOLq/scwBElcq12C26Tdu3L6Hl9JKhVvMt71Q2Rkg9PYfjKM/w8GSQGf3pJYJV p1dn4qEvUO+qK35fWA7mLAFEkVOTxgd02qOw1cavEYrhzGwSZ5bBpbUo4hrIX9MnaARIDdZWc 96xmfyPvJ/0SRm2T56l9RgDvL703NhE1/2KIVoi2XIyi0kzZrzOoebGx3EBdq9bdwLMi1CT9K AkDcnF/oGIr/zAmvf+0jDk8mIr+s64q/BkPtjOQeQLJ1MjDy7X2zUPgxqKSTP5oUAcaw628MQ 9kG49s6EIExHNM+89lsgvBvQOq96LvjGKF35H2DP6VAUfV56ZEt7QYNNaLn8wx3iRJksqtooT uV1r2NLY+vC9n0GE1dqmKO1vmJp3WqaUqWu4KeZaP1twE/QAZvzO4xhG0XJZk+br29eZT2/3O oBW1uX87gAxIs/+o99LZNet4CRAhaRepT6E0xzk0MhUYYk8Oak= X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 29F2040018 X-Stat-Signature: noutswaeppncpm3tdg783tzyukcpgfbq Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.17.13) smtp.mailfrom=arnd@arndb.de X-HE-Tag: 1650525153-120687 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 21, 2022 at 8:52 AM Geert Uytterhoeven wrote: > On Thu, Apr 21, 2022 at 1:53 AM Greg Ungerer wrote: > > On 21/4/22 00:58, Eric W. Biederman wrote: > > > In a recent discussion[1] it was reported that the binfmt_flat library > > > support was only ever used on m68k and even on m68k has not been used > > > in a very long time. > > > > > > The structure of binfmt_flat is different from all of the other binfmt > > > implementations becasue of this shared library support and it made > > > life and code review more effort when I refactored the code in fs/exec.c. > > > > > > Since in practice the code is dead remove the binfmt_flat shared libarary > > > support and make maintenance of the code easier. > > > > > > [1] https://lkml.kernel.org/r/81788b56-5b15-7308-38c7-c7f2502c4e15@linux-m68k.org > > > Signed-off-by: "Eric W. Biederman" > > > --- > > > > > > Can the binfmt_flat folks please verify that the shared library support > > > really isn't used? > > > > I can definitely confirm I don't use it on m68k. And I don't know of > > anyone that has used it in many years. > > > > > > > Was binfmt_flat being enabled on arm and sh the mistake it looks like? > > I think the question was intended to be > > Was *binfmt_flat_shared_flat* being enabled on arm and sh the > mistake it looks like? > > > > > > > arch/arm/configs/lpc18xx_defconfig | 1 - > > > arch/arm/configs/mps2_defconfig | 1 - > > > arch/arm/configs/stm32_defconfig | 1 - > > > arch/arm/configs/vf610m4_defconfig | 1 - Adding stm32, mps2 and imxrt maintainers to Cc, they are the most active armv7-m users and should know if the shared library support is used anywhere. Arnd