From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7ECCC433F5 for ; Sat, 21 May 2022 20:30:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 749CA6B0072; Sat, 21 May 2022 16:30:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F93F6B0073; Sat, 21 May 2022 16:30:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E9BE6B0074; Sat, 21 May 2022 16:30:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 50EE96B0072 for ; Sat, 21 May 2022 16:30:22 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 23AD032C26 for ; Sat, 21 May 2022 20:30:22 +0000 (UTC) X-FDA: 79490892684.30.D2ED31F Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75]) by imf22.hostedemail.com (Postfix) with ESMTP id 07B15C0021 for ; Sat, 21 May 2022 20:30:18 +0000 (UTC) Received: from mail-yw1-f172.google.com ([209.85.128.172]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1M597q-1ntcCd3dAK-001BlR for ; Sat, 21 May 2022 22:30:20 +0200 Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-2ff1ed64f82so116197247b3.1 for ; Sat, 21 May 2022 13:30:19 -0700 (PDT) X-Gm-Message-State: AOAM530ShBHuVgZ3lB1PfIDuc4kG86LeCxs9Ba7Mkd98mbZ429zfO2Mj VV8M2ayeJ2q+ijcLIUmRJnuWurpSymbM8LGd3m0= X-Google-Smtp-Source: ABdhPJxdzeQ8ppWmG4FaNugj1IVJL8hVon5ICr2txVNKnWSwzCAfUIa/u3XB2kovYWtRi5zFhQ8P1BD7cK9iFDjy8rQ= X-Received: by 2002:a81:950:0:b0:2fe:d88e:5529 with SMTP id 77-20020a810950000000b002fed88e5529mr16185220ywj.320.1653165018339; Sat, 21 May 2022 13:30:18 -0700 (PDT) MIME-Version: 1.0 References: <20220519082552.117736-1-wangkefeng.wang@huawei.com> <20220519082552.117736-2-wangkefeng.wang@huawei.com> In-Reply-To: <20220519082552.117736-2-wangkefeng.wang@huawei.com> From: Arnd Bergmann Date: Sat, 21 May 2022 22:30:01 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/6] ARM: mm: kill unused runtime hook arch_iounmap() To: Kefeng Wang Cc: Catalin Marinas , Will Deacon , Andrew Morton , Linux ARM , Linux Kernel Mailing List , Linux-MM , Christoph Hellwig , Arnd Bergmann , Anshuman Khandual , Russell King Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:JUcbgeVAo2y/gNslOVU+Kd5PSOwv98QQrixGvArRWJ9DOVP6X00 2AotDZowPVWXdRoe7kGlgo70wovmCQKxEButKODUyg4N3r8kYt2ry3uUXsE+vOvEgX6nNup Ph+n0Da4HRyhD/m+7+a5xuriOGCd/fwB/hVpAKEGIi6qQBFqOmjAlCLHCkttVE+UOxM32PJ tVRSua9feFqC8HUZ1Jhng== X-UI-Out-Filterresults: notjunk:1;V03:K0:L37wvAF5m58=:TsVTJyRhuCUzNy+Qlnuzyu QxM9n+Ci2zrVCOTBP6rHqmNutxc7ttFHLdRtSp/7fB8zdU+pt3jcznXLOrz/O56MpERI6Q8cu 5AprN0JTY0chQI/r3nLz0RWu8VTgSCLITEe6Hmd+0S8Nxx0vW98HINUehR7trhGhXpdmuPv52 +P4rB2fdhOGyy7OiP92WYim8bVSlPA9d+y0Wz7vp5L3AOt+o/XKQ11Kc6N+Shq4AoE9Q0OVtk 2cVfs1qwlmKu6mb42RjYfevI0IhpSbqAbPsB59eIlYJ+4g/Hfq3boUcPiK3ElzT5FXuJgkB0M KicYX7D60MA1uTZmmNMfhhKcmAicNYK3cQkBCOohR96hHBgUqMlb2YXGXaUvY/e/NcXjlG2nZ kP2tVwUJBgOpXy1YuAXLB2hLLjZ9fORZrEWyKuG/hFflL381c1h5hlLYUBtUYn54/AoFMyIi7 BfFVllLglRvZ6WC3h+INdAkQ8CE2L3Kksfp+PoCfCR3og6MmDUxPz+4SsnklGbJ1ArYAe+rlB G6BPwkWSgaIISVAQ8NhTBYsxUY/DQd3Jbyi53ME4szRVFJyb+l7COvJm5XuAubtQFxx0FfSH2 nIFUAJ4Z58N0MP0fYvi2YLjbiG6oojKSKXsBwxYb8Ua/L97zQS5f381QGTGhgVzbAUKHNkdwj 95gS63EsquXDNgaAakI3N4/XjiA9YAIbzon6C7DxD1xvZNxw/5b+LpthssqA6X122lZ3zZeZt Q3Ty5ZeJWRsxmoWsB6bAxFQBDyrXvX0nEfnzHVJo6TTb3PSLLy8nLkk3ZwdoRt06DMGC0FB2Q PZZJmxTtUE6roFFJzvrWkE+PQr7LZLCQu8S+MuSW5QTjYLS3Zl7Y0jSXzB5fHaUyPbY4wD9pE W658JwA5KG1fwDzuUQCg== Authentication-Results: imf22.hostedemail.com; dkim=none; spf=none (imf22.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 217.72.192.75) smtp.mailfrom=arnd@arndb.de; dmarc=none X-Rspam-User: X-Stat-Signature: tm3iagorpq69ywz5b3rgbup6x3h4y63t X-Rspamd-Queue-Id: 07B15C0021 X-Rspamd-Server: rspam01 X-HE-Tag: 1653165018-91296 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 19, 2022 at 10:25 AM Kefeng Wang wrote: > > Since the following commits, > > v5.4 > commit 59d3ae9a5bf6 ("ARM: remove Intel iop33x and iop13xx support") > v5.11 > commit 3e3f354bc383 ("ARM: remove ebsa110 platform") > > The runtime hook arch_iounmap() on ARM is useless, kill arch_iounmap() > and __iounmap(), and the naming of arch_iounmap will be used in > GENERIC_IOREMAP with the later patch. > > Cc: Russell King > Signed-off-by: Kefeng Wang I had a very similar patch prototyped recently, Reviewed-by: Arnd Bergmann It would be nice to do the same for arch_ioremap_caller(), which now has two implementations left for mvebu and imx3, previously we had more for iop13xx, ebsa110, ixp4xx and msm. For both armada37x/380 and imx3, the only purpose is to override the mtype argument, and it feels like there should be a better way to do this, though I'm not sure what that is. Having an overridable mtype value per 256MB section of physical address space would be sufficient for both, but I don't know if that's any better than what we have. Arnd