From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBA1CC4338F for ; Mon, 16 Aug 2021 14:30:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7625860F5C for ; Mon, 16 Aug 2021 14:30:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7625860F5C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 19C0F6B0073; Mon, 16 Aug 2021 10:30:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 126766B0075; Mon, 16 Aug 2021 10:30:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F30AF6B0078; Mon, 16 Aug 2021 10:30:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id D9ABC6B0073 for ; Mon, 16 Aug 2021 10:30:30 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8721718F47 for ; Mon, 16 Aug 2021 14:30:30 +0000 (UTC) X-FDA: 78481179420.12.E96ADA0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf23.hostedemail.com (Postfix) with ESMTP id ECAA1900589A for ; Mon, 16 Aug 2021 14:30:28 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 116BA60FC3 for ; Mon, 16 Aug 2021 14:30:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629124228; bh=J4KUxI/3leGxqU9U6smcSic6HkuIdltya5RAFoAZj/w=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=iICcFaRDTRYos4f7qzYI7Lq8jGvUNavOLhmC321Gdm2XdOvPupo3EuT3781DOAeDW r7emhCuEsnTi1AxTO+bD7rLOyrfF/m/mGbVzpOYHxonENe0w9ry5cXX+wvsTahRKCa VFCwxR+OMkSvq+O+qivk4Vgehlyz0Hz7qq7zh231s9H8jyernLGFaDSlQSER62JhV6 un5+sQOpzOdwHxR8HWQbcN4SyjnP7XQFBDVGno/i/nIi804if+G+yZEDseoDN8oRJJ izCZFgcA3fM8YVDEILFvRfAQ+Had/kyDrBGElrOv9Ddhw5oyJrASM9A7MbaFL8dgGp avN69+co8A39g== Received: by mail-wr1-f41.google.com with SMTP id u16so6813928wrn.5 for ; Mon, 16 Aug 2021 07:30:27 -0700 (PDT) X-Gm-Message-State: AOAM5312rLphvEAbCRgskz+7urUTfjFfq7VKERKVSxcLrA+nwJQoDCeA fW3eIXM1n6iPaUN0z3MfYsKKa/kusiS6ra2b0zs= X-Google-Smtp-Source: ABdhPJy5RB8DgxGnaKKOznAPybkglt1lOPjlBX/c0ALJMkGaQJgH6Rjw1Taa6v/E0FOE50DTeAbZKpDyCcNQfTVuX4Q= X-Received: by 2002:adf:e107:: with SMTP id t7mr18967060wrz.165.1629124226666; Mon, 16 Aug 2021 07:30:26 -0700 (PDT) MIME-Version: 1.0 References: <20210816141609.41751-1-cristian.marussi@arm.com> In-Reply-To: <20210816141609.41751-1-cristian.marussi@arm.com> From: Arnd Bergmann Date: Mon, 16 Aug 2021 16:30:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] firmware: arm_scmi: Fix virtio transport Kconfig dependency To: Cristian Marussi Cc: kbuild test robot , igor.skalkin@opensynergy.com, kbuild-all@lists.01.org, Linux-MM , Sudeep Holla , peter.hilber@opensynergy.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: ECAA1900589A Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iICcFaRD; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of arnd@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=arnd@kernel.org X-Rspamd-Server: rspam04 X-Stat-Signature: aho9tuwa8boayatoo1obdp97wewbopur X-HE-Tag: 1629124228-67750 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 16, 2021 at 4:16 PM Cristian Marussi wrote: > > ARM_SCMI_TRANSPORT_VIRTIO is a 'bool' Kconfig used to include support for > the SCMI virtio transport inside the core SCMI stack; a bare transport > dependency attached here to this option, though, cannot be properly > propagated to the parent ARM_SCMI_PROTOCOL option and, as a result, it is > currently possible to configure a Kernel where SCMI core is builtin > and includes support for virtio while VirtIO core is =m. > This allowed combination breaks linking: > > ARM_SCMI_PROTOCOL=y > ARM_SCMI_TRANSPORT_VIRTIO=y > VIRTIO=m > > Bind the dependency in ARM_SCMI_TRANSPORT_VIRTIO to the chosen kind of > compilation of ARM_SCMI_PROTOCOL. > > Reported-by: kernel test robot > Suggested-by: Arnd Bergmann > Signed-off-by: Cristian Marussi The description looks good Acked-by: Arnd Bergmann > @@ -68,7 +68,7 @@ config ARM_SCMI_TRANSPORT_SMC > > config ARM_SCMI_TRANSPORT_VIRTIO > bool "SCMI transport based on VirtIO" > - depends on VIRTIO > + depends on VIRTIO=y || VIRTIO=ARM_SCMI_PROTOCOL > select ARM_SCMI_HAVE_TRANSPORT > select ARM_SCMI_HAVE_MSG Looking at this again, I noticed that this still needs the explicit 'depends on VIRTIO' line you removed, otherwise the prompt pops up when both VIRTIO and ARM_SCMI_PROTOCOL are disabled. Arnd