From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C61D5C43334 for ; Mon, 4 Jul 2022 12:18:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20F696B0074; Mon, 4 Jul 2022 08:18:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BEDC6B0075; Mon, 4 Jul 2022 08:18:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0874B6B0078; Mon, 4 Jul 2022 08:18:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ED0066B0074 for ; Mon, 4 Jul 2022 08:18:35 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C35B360347 for ; Mon, 4 Jul 2022 12:18:35 +0000 (UTC) X-FDA: 79649320590.11.3C32430 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.10]) by imf17.hostedemail.com (Postfix) with ESMTP id 1033540049 for ; Mon, 4 Jul 2022 12:18:34 +0000 (UTC) Received: from mail-yw1-f169.google.com ([209.85.128.169]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1M6m1g-1oFSpr2WFC-008Hcf for ; Mon, 04 Jul 2022 14:18:33 +0200 Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-317a66d62dfso80286627b3.7 for ; Mon, 04 Jul 2022 05:18:33 -0700 (PDT) X-Gm-Message-State: AJIora+01ZXBhQnjC9wovxR5unfY/1464IOp7gAS8s2VrWZ8ffDo1RPR EqoO5yo+mxVe/VR8mkwGp9N7vbxuAcQ4BZeSS3c= X-Google-Smtp-Source: AGRyM1t524xzXaLIHc9+YLKm6ZLrM8h13HdFno4gZgaj1dmGgvuhogt+hY7ItAhxUJF6ZzYWUGTcd5U54H4EPHTirlY= X-Received: by 2002:a81:7742:0:b0:318:35e9:728b with SMTP id s63-20020a817742000000b0031835e9728bmr32899958ywc.209.1656937112121; Mon, 04 Jul 2022 05:18:32 -0700 (PDT) MIME-Version: 1.0 References: <20220704112526.2492342-1-chenhuacai@loongson.cn> <20220704112526.2492342-5-chenhuacai@loongson.cn> In-Reply-To: <20220704112526.2492342-5-chenhuacai@loongson.cn> From: Arnd Bergmann Date: Mon, 4 Jul 2022 14:18:15 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V4 4/4] LoongArch: Enable ARCH_WANT_HUGETLB_PAGE_OPTIMIZE_VMEMMAP To: Huacai Chen Cc: Arnd Bergmann , Huacai Chen , Thomas Bogendoerfer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Catalin Marinas , Will Deacon , loongarch@lists.linux.dev, linux-arch , Xuefeng Li , Guo Ren , Xuerui Wang , Jiaxun Yang , Andrew Morton , Linux-MM , "open list:BROADCOM NVRAM DRIVER" , Linux Kernel Mailing List , Linux ARM , Feiyang Chen , Muchun Song Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:Jpickmfkn674RyneaNDJT3AqmMwc+hBjUQvdGGM3mjWcXAthFaN zTDrA00K0g9RWnA+rEZNi/YWNkAfqDrnazNX2Ni5jnKMyXVXyhE2ZUDjAdHzv9GWh/hdBjo OXdHz4KcVPv4AtJfcPofeMPUusb2HRpAFDT6NGl8SdKu9oSFpNss3KunHlAkuaNWqa+oCfQ xdlkuzTeOJn2qFiSiPC+g== X-UI-Out-Filterresults: notjunk:1;V03:K0:DlaOjl6RHqk=:/xTkqrSirCo7VFNdq+4W6B gWDpGndiTth87GK+lA/vYgvCMw3bdg9Hzy0IJiUZ1Y+BAjQ6ZNIpyzPfdV2w1wgqjU7mC6yDS z2llv4tpUGFfJCVJcjsgvWwdyA+h4ARL616pxkHd50CFQ0Lxpk9jn9/5e5VaNcK9CJmLL9LKF C3RkDblvlCaPjHKrZs5T1bhMUe+spLdilMea1mTkiD564jXDbCf25EqwPh9F2u8zgfLAlWzEA Ce31VphwJb56S4fxnslq1m99pGyAfQUFiN2HlJZ1Hdv71RfYiufajBuj4ZS4SCtEqwSKVXBrF vuigMCetg4PgfyxOky/PcvB9sKDEQiehwmck4CgF3DLjp6Gphd3FwgUjV3YIuD2wovso0c40C /pfo0k1bNeFDzxz2A0o/kihZB1mD2d5lEXXBh0+zHczK/z2KKDk5gPYcsDggcJxHt2Z/E7VEX +7jCgPzmWPoFZLafl4uWcUc/rTjWicBFQBHXqF9AGo5Ktb8O5FITGh+qLlkEEOHffPTNOMqRJ 8H6IVo4O5DTHfCSV4bwfYxVuRuYTmlIyq4CmDEPLyoMIZHCVmoYrFdRz12pj0h/+wz3S09aIw yaSbQSTuVQScyIbZk2yf034byvuvhJiI5BW3JS5c68fjGNNCFI0mkRZub9SJ16VcXYSA3dZ1j 7OZlzE6bVuZ6lAs7KNn3G1xqKuc9qJ1wn8WRNL3i0l5tr7MyzOFUst6X/5x4LtK7Cyeft71+C +Dk57l0hV3rKGurpgMSKbnRMcMG7ZHo6M2Hx+3dQeugZKkNwNvLqP/VkUopgA6+i8VFiUP1Q7 XtcwTsu9EP2w9ilA6/FnM7MlL3Yahj8mY7uNft9P1uHCEzK9GerwPhgXQvgfgw3I1ItquUkbJ RTfJUu+BmvXSI85FplwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656937115; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3P6YqGpvkHxZnEenbKoTrGJlzS/P5WZ5TNErM5fMHk8=; b=rFlHjtO/fXAgAuUtcUBhlPnzlPUx0vOp5itoeSqerBytEzCBqX5XEZE4RfOuOAI4Z8tgyA Jk5w6vSaboVv9AhLP1eAMWJC2wE/SQjewDI7y1PUnfNzAvz9eYe6trB4V6OHXlglxZL4mz u0ykonTSB+USlMo+3fw/C3tz90IKFIc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.17.10) smtp.mailfrom=arnd@arndb.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656937115; a=rsa-sha256; cv=none; b=NjRu4NEOffxclW5gqXw7Ule/vNKHYoVr6Uzeh2iuX4x2R7LU/IMVEQMqwBuerPEDdyeeLk I4h3E68qpb68ugeGIFxoXZyfSXMPq7d6bHME+e733WmFO9H9VeNgxCKmTSds7mUwivtKSC rPoL0KqeVcNqx9p9O5KahjwhryfT/G4= X-Stat-Signature: 8d67tiw17dwf4tn9m9ayb7wj7ndprqd3 X-Rspamd-Queue-Id: 1033540049 Authentication-Results: imf17.hostedemail.com; dkim=none; spf=none (imf17.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.17.10) smtp.mailfrom=arnd@arndb.de; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1656937114-330952 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 4, 2022 at 1:25 PM Huacai Chen wrote: > To avoid the following build error on LoongArch we should include linux/ > static_key.h in page-flags.h. > > In file included from ./include/linux/mmzone.h:22, > from ./include/linux/gfp.h:6, > from ./include/linux/mm.h:7, > from arch/loongarch/kernel/asm-offsets.c:9: > ./include/linux/page-flags.h:208:1: warning: data definition has no > type or storage class > 208 | DECLARE_STATIC_KEY_MAYBE(CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP_DEFAULT_ON, > | ^~~~~~~~~~~~~~~~~~~~~~~~ > ./include/linux/page-flags.h:208:1: error: type defaults to 'int' in > declaration of 'DECLARE_STATIC_KEY_MAYBE' [-Werror=implicit-int] > ./include/linux/page-flags.h:209:26: warning: parameter names (without > types) in function declaration I wonder if page_fixed_fake_head() should be moved out of line to avoid this, it's already nontrivial here, and that would avoid the static key in a central header. Arnd