From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09AE8C43460 for ; Thu, 8 Apr 2021 13:19:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A1FE76113C for ; Thu, 8 Apr 2021 13:19:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1FE76113C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 246EF6B0072; Thu, 8 Apr 2021 09:19:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21E506B0078; Thu, 8 Apr 2021 09:19:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C06B6B0080; Thu, 8 Apr 2021 09:19:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id E5D5E6B0072 for ; Thu, 8 Apr 2021 09:19:40 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A17371828DEBA for ; Thu, 8 Apr 2021 13:19:40 +0000 (UTC) X-FDA: 78009256920.20.A738FA8 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75]) by imf27.hostedemail.com (Postfix) with ESMTP id D094880192E8 for ; Thu, 8 Apr 2021 13:19:32 +0000 (UTC) Received: from mail-oi1-f172.google.com ([209.85.167.172]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1Mwfj2-1lnyCJ2g9K-00y8NO for ; Thu, 08 Apr 2021 15:19:37 +0200 Received: by mail-oi1-f172.google.com with SMTP id i81so2115712oif.6 for ; Thu, 08 Apr 2021 06:19:36 -0700 (PDT) X-Gm-Message-State: AOAM531ilm0pIzCj54VCt2l7pjqbRTa3QfvE/+e4RPVNPNMov2xW+PTC rvpxsA19FrjdzP24jFOXYF1M9pFqmJYAu6EN/gE= X-Google-Smtp-Source: ABdhPJzHb7t36K8Eh3/YW98i9jFFwt105TSLCljFkAhUwPloRFuMsDPsNoXrOsOYqi1vkp97GaHnIbSFi7HvVPlRimE= X-Received: by 2002:a05:6808:313:: with SMTP id i19mr5867255oie.67.1617887975911; Thu, 08 Apr 2021 06:19:35 -0700 (PDT) MIME-Version: 1.0 References: <20210408092011.52763-1-david@redhat.com> <20210408092011.52763-3-david@redhat.com> <7496ac87-9676-1b4e-3444-c2a662ec376b@redhat.com> <3a2d64a7-8425-8daf-17ee-95b9f0c635f9@redhat.com> In-Reply-To: From: Arnd Bergmann Date: Thu, 8 Apr 2021 15:19:19 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv To: Linus Walleij Cc: David Hildenbrand , Linux Kernel Mailing List , Linux-MM , Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Mike Rapoport , Bartlomiej Zolnierkiewicz , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed , dri-devel , Linux ARM , The etnaviv authors , Linux Fbdev development list Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:MDt1EARskhnPcVpKDBv5BPjBBIEj5Fm26Tgd0wYGwv1XPv0YSTG W1Pj+ni8DbS7xl188D5Ht4aWLrP6fXpYTtwWUqFcPzg4S9dH7rLObfzyBbohWMuBUEBDXwK yiq7R9X/caLaUKy0As0Z5q5NtffOCg1oA9CqdAaxX5sqL9zrkaaKXTWOgS2AVKfB+cTRs69 nKHqfZbBJdm7TLEOgfipg== X-UI-Out-Filterresults: notjunk:1;V03:K0:LrWKrOK0Vq4=:NiPBDnKrfB6gJ80E8NA0s3 qz1ekisn1pai4oaQ3Pn9PXh+DHLZAGATNOs+/FSW6ricjjX3ZQmQ7K9jrMCOKD+epRGmZtFno oUCa8r6+uXO/rk7GDEcMznrX3gfqDwg87zGwj2LEfK/ELnbH1r5YUPAMroEzb0vEMbhhEiUWE FtuzyUWKq2HzzuypVQrZZDCjd63U5evaOG1vDCaBOIIqmHQ3HAZ+qm2KH1xoj/MzmQyB87mjs Yp14WoBdJULDHytvyWqoAvnpBw+81lf88ppR+pEnQ+GNdZVl+FhA+xEpvVSC/s0QZiHjZw5sn W0uJqAMC+NoZhNxm8XqlKzDVTd+kxMzXNTxEDr03FO8sqUkaVdm3yvESpAw04T3u0Z5Vg+JN8 nZH4uyMuLbhKk02IDcZa5RKprwWHPxAUa6K0/zjZ2vCV9ox+TNMKT0+ZJSrr8RQyUJ4htFRv6 p0KpWVeRN4hM0vAVBO5PaV1mJnn6SCU= X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D094880192E8 X-Stat-Signature: u9jfiojfruyt3hmyww9pxn3w5c6wiq8w Received-SPF: none (arndb.de>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=mout.kundenserver.de; client-ip=217.72.192.75 X-HE-DKIM-Result: none/none X-HE-Tag: 1617887972-558642 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 8, 2021 at 2:50 PM Linus Walleij wrote: > > On Thu, Apr 8, 2021 at 2:01 PM David Hildenbrand wrote: > > > > This is something you could do using a hidden helper symbol like > > > > > > config DRMA_ASPEED_GFX > > > bool "Aspeed display driver" > > > select DRM_WANT_CMA > > > > > > config DRM_WANT_CMA > > > bool > > > help > > > Select this from any driver that benefits from CMA being enabled > > > > > > config DMA_CMA > > > bool "Use CMA helpers for DRM" > > > default DRM_WANT_CMA > > > > > > Arnd > > > > > > > That's precisely what I had first, with an additional "WANT_CMA" -- but > > looking at the number of such existing options (I was able to spot 1 !) > > If you do this it probably makes sense to fix a few other drivers > Kconfig in the process. It's not just a problem with your driver. > "my" drivers: > > drivers/gpu/drm/mcde/Kconfig > drivers/gpu/drm/pl111/Kconfig > drivers/gpu/drm/tve200/Kconfig > > certainly needs this as well, and pretty much anything that is > selecting DRM_KMS_CMA_HELPER or > DRM_GEM_CMA_HELPER "wants" DMA_CMA. Are there any that don't select either of the helpers and still want CMA? If not, it would be easy to just add default DRM_KMS_CMA_HELPER || DRM_GEM_CMA_HELPER and skipt the extra symbol. Arnd