From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC1CBC433EF for ; Tue, 3 May 2022 08:22:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 086996B0071; Tue, 3 May 2022 04:22:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 036486B0073; Tue, 3 May 2022 04:22:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E19C76B0074; Tue, 3 May 2022 04:22:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id CEF4E6B0071 for ; Tue, 3 May 2022 04:22:43 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 9607861FD2 for ; Tue, 3 May 2022 08:22:43 +0000 (UTC) X-FDA: 79423740606.17.3B66044 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.187]) by imf27.hostedemail.com (Postfix) with ESMTP id 19FE940072 for ; Tue, 3 May 2022 08:22:40 +0000 (UTC) Received: from mail-yb1-f181.google.com ([209.85.219.181]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MmlGg-1oDfmR0X8o-00jtrQ for ; Tue, 03 May 2022 10:22:41 +0200 Received: by mail-yb1-f181.google.com with SMTP id g28so29867922ybj.10 for ; Tue, 03 May 2022 01:22:40 -0700 (PDT) X-Gm-Message-State: AOAM530GOK5mxFn8G6HcvlbiVUDoewLzz0iDROUTiIOTvVgOBhR4zWfM T1mOtp5OGxjb60CjwE8cFE2LFd/5Z5258fYkl6U= X-Google-Smtp-Source: ABdhPJwrDtRFKbzWyx5Thvx9iv9ah7eyFBtB8lxLn/zZfAdnxobNy3HzZif7KpemB7VbxNVkIL6z9jSMtRXvIKtqCl4= X-Received: by 2002:a81:9213:0:b0:2f6:eaae:d22f with SMTP id j19-20020a819213000000b002f6eaaed22fmr14611680ywg.249.1651564406792; Tue, 03 May 2022 00:53:26 -0700 (PDT) MIME-Version: 1.0 References: <202205031017.4TwMan3l-lkp@intel.com> In-Reply-To: From: Arnd Bergmann Date: Tue, 3 May 2022 09:53:10 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings To: Tony Lindgren Cc: Arnd Bergmann , kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:DlZ3MQWcfDvHi8AdIk3/DJ2AJJ9V6mxa1tgWFhZQDos3vOcZqy6 o7OKy97DhUMaROpwuuiIgDstgFDU2K2pmIS6AjnGzE277NNwsH4aFxf+mXatk+19Lgi9hX/ P4zVATdQgVWTu2Sjv06bRQwZvKvQIZenUQvwO6trL5tt4r4eZWP+Qs0LiVwlwAVjJC1/l4m x70Wa1wV4cDO4Y73rU3tg== X-UI-Out-Filterresults: notjunk:1;V03:K0:Ab9binh1mWw=:UIhS5HMx9JPYHdxIFxwiIE /bBs4wqsb7XXmkyzM+UQGGX7gkNifk6YwBJ4XrvoXKZqZqGDH/Yyey2vw4aIQeqXova07z4ys kTdepfnO+ds+mIa0YUCg0g/OnP6qKGHRVHWBiDrcy0Fx2vrUP97XhH+rcNJ5FmkhCXd3sCBB1 ruhFEvJBDzGnnodnQ3imLLhqFiUSQZTNYhpyf7Ypkfn7bfBdVRJ6n3ejLSfv+mFgqJ0PE3u84 HzXGo2ZYUqlQZrGPiy6A57BPdYu6v6cyF11lpX/+rhr2FPJzXizQgWnKwp1VnO1GCUYaEuyN/ AN5/zxSnA1pJCGMuJxqcU2Ag4WRDty1PSCmPBvXqLOo76c3CeKRMDkPTd/YD6V0jj4REk9JHT uJdVhFl1Y1yuWqe2k7hPDe7SSTnuZNHLVuHCnsjx6jIA8+ohoDynLVc6U+ONRjBlUgKAk5vJ2 fFZn4vC1VFhgbBQvxP/s0rH6P6CTBU3iQRRoWrIheXAFu9SNswe/x0ZxREDWz6GPazXIeBwGr 2vXfxQ9+QtE57FvSpRjzeMCoALkCS26LWa/4LJ1eQobvJQkzaQV7GHMUorwgdQFpcTfrYZtNb 9mUUU/Pznfm8F49eTliY/sFIrFMbzvX8XgwgOYRlbVo2pUD8EmGfPIfAtHjGRPp1NC4xw7YF/ abSIoopi9f3tvdnc7BgScKZnggq0uFpBuSoqdH8yW8w6VxPT4wz1A+jkBabgQGprJYeHg99pt KEHy7F72qzgsQOjjn+V749UA9+TQp+PNb2wHLWJhMpWDQOcK3vjOW52NzdMs1zWpqurkEfWam iHLKAsudhjqDcfe5ymq/UHULpoX6vi0ZheI/+2O2jE4kRvoIGw= X-Rspamd-Queue-Id: 19FE940072 X-Stat-Signature: zgpfe4589oj65o7zsrqotdmhjchms3sa Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.126.187) smtp.mailfrom=arnd@arndb.de X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1651566160-576715 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 3, 2022 at 9:30 AM Tony Lindgren wrote: > * Arnd Bergmann [220503 07:18]: > > On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: > > > > > > From: kernel test robot > > > > > > arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 > > > > > > > > > Remove unneeded variable used to store return value. > > > > > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > > > > > Reported-by: kernel test robot > > > Signed-off-by: kernel test robot > > > > I checked the patch, and unfortunately it is wrong, the current code > > needs to stay. > > The problem is the SET_DMA_ERRATA() macro that accesses the > > local 'errata' variable. > > Yeah this one keeps popping up. Maybe we can make SET_DMA_ERRATA > into a function or have it at least change it to set the errata > value. I would just remove the macro and open-code the assignment, which I think makes it more readable to both people and tools. Arnd