From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE352C43461 for ; Thu, 8 Apr 2021 11:44:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6C95D6112F for ; Thu, 8 Apr 2021 11:44:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C95D6112F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F0E506B0082; Thu, 8 Apr 2021 07:44:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EBD306B0083; Thu, 8 Apr 2021 07:44:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D37526B0085; Thu, 8 Apr 2021 07:44:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id B00F76B0082 for ; Thu, 8 Apr 2021 07:44:42 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6D7448789 for ; Thu, 8 Apr 2021 11:44:42 +0000 (UTC) X-FDA: 78009017604.37.B0C30D8 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by imf29.hostedemail.com (Postfix) with ESMTP id 18182DE for ; Thu, 8 Apr 2021 11:44:39 +0000 (UTC) Received: from mail-ot1-f51.google.com ([209.85.210.51]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1M6UVr-1lWx8I3y13-006tgb for ; Thu, 08 Apr 2021 13:44:40 +0200 Received: by mail-ot1-f51.google.com with SMTP id l12-20020a9d6a8c0000b0290238e0f9f0d8so1942951otq.8 for ; Thu, 08 Apr 2021 04:44:39 -0700 (PDT) X-Gm-Message-State: AOAM5324nhXbjHf3usCssEBqSlFrt9Ua57bU01ZpkuaOqoVPm3xa6HNB iKo4DnC1L88J5N1/4xbVhFfmPw3tufsw6FMJw44= X-Google-Smtp-Source: ABdhPJw/Kt6oueYEiXqyZYSL7pDJ4LuFJYHMs1Y8FL1ZmuGq8xfxN7KNWR6IE58DyzqBWI3T+US+8jsx0JeptqGIBk4= X-Received: by 2002:a9d:316:: with SMTP id 22mr7135730otv.210.1617882278035; Thu, 08 Apr 2021 04:44:38 -0700 (PDT) MIME-Version: 1.0 References: <20210408092011.52763-1-david@redhat.com> <20210408092011.52763-3-david@redhat.com> <7496ac87-9676-1b4e-3444-c2a662ec376b@redhat.com> In-Reply-To: <7496ac87-9676-1b4e-3444-c2a662ec376b@redhat.com> From: Arnd Bergmann Date: Thu, 8 Apr 2021 13:44:22 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 2/2] drivers/gpu/drm: don't select DMA_CMA or CMA from aspeed or etnaviv To: David Hildenbrand Cc: Linux Kernel Mailing List , Linux-MM , Joel Stanley , David Airlie , Daniel Vetter , Andrew Jeffery , Lucas Stach , Russell King , Christian Gmeiner , Mike Rapoport , Bartlomiej Zolnierkiewicz , Linus Walleij , Michal Simek , Masahiro Yamada , Randy Dunlap , Peter Collingbourne , linux-aspeed , dri-devel , Linux ARM , The etnaviv authors , Linux Fbdev development list Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:G3rA47llOMqTFnyQLPcquIyt8M3W/+E8RCGZ4hkazTA7i5sDQVg eDvc6wUjbq+Puq5avtWi0q0U1+zmZBw+PUO190bHLN9Zg9fs2oa3rYYThCjiZdRbwnJe0ny nKF2kPQ6acyekKqOXaZAMSYbCQqKrZiHNkVc5RMhw31H3i2mgyRalfsrzmCorLODizSXw2Y NnavedTlRJiCSJ5/WnNdA== X-UI-Out-Filterresults: notjunk:1;V03:K0:a70Z2evSHBE=:LMcljLbhBGIvDgzu1mWgbi mE5xrG/uIjIwxJNdE+W9qZxoaz74kHM+7IQlbgAo8rAPyR2h5AK3N3cn+NyCrRkuXT3U1aygt OGdWhvVvVzSU+asgoHRl9VbhIeg+FZGduHayq/gq2FKCMN1BEppaCjDzKY5rPt5iKmfqFQRuY gDkLm4EWSqsLF8h9A5NLxnXpC1MjTjaXa+aIbOvNqgdjaRi5lz03KwSeCiQF2+iPENoKvYaR2 t+x+rzQ0IHRmqRmGHatWV7TYdjGDXz8eI0kQ2wG47VK6fQ9oRSpt4kMFYv7tL6rU3Nrb067Um u+P3gWxHMY8005oc0ePLq09n9iz7xQA8a1yg2E6p+s1XxHzLgbCL5aMVdz2+0wSWvvUBDn1kG Zgb+QYNtspRfMdzLz992H8bjCCC8omIcHIvw9cWmzglcCjO68Hk+FSmj7rQJoQGtMv/oJFP98 EJe+y5vINTbvW4FdFXpTISLbFJbNIk3TKL2iJ7Vvzvb1fsvQvMTQM379BIoME4wtpo2jVCxlZ BpNc/BThGXqoAMW99qKnUTyzZhQj4KhkXLNXHiADjKr+RuGfjnrLwJ7WSYiQsyhW3XwuTVxdA 81LCmZOQhKSXU+veauqm6y9WQmP3pXM6AA X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 18182DE X-Stat-Signature: gsqs7ffxhbz6b8twyhhbjj6twmmf83jb Received-SPF: none (arndb.de>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=mout.kundenserver.de; client-ip=217.72.192.74 X-HE-DKIM-Result: none/none X-HE-Tag: 1617882279-606783 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 8, 2021 at 1:00 PM David Hildenbrand wrote: > > > > It is a somewhat awkward way to say "prevent this symbol from > > being =y if the dependency is =m". > > What would be the right thing to do in the case here then to achieve the > "if DRMA_ASPEED_GFX is enabled, also enable DMA_CMA id possible"? > > One approach could be to have for DMA_CMA > > default y if DRMA_ASPEED_GFX > > but it feels like the wrong way to tackle this. I'm still not sure what you are trying to achieve. Is the idea only to provide a useful default for DMA_CMA depending on which drivers are enabled? This is something you could do using a hidden helper symbol like config DRMA_ASPEED_GFX bool "Aspeed display driver" select DRM_WANT_CMA config DRM_WANT_CMA bool help Select this from any driver that benefits from CMA being enabled config DMA_CMA bool "Use CMA helpers for DRM" default DRM_WANT_CMA Arnd