From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E735BC433EF for ; Tue, 24 May 2022 12:35:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6168F8D0003; Tue, 24 May 2022 08:35:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C60B8D0002; Tue, 24 May 2022 08:35:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DDE58D0003; Tue, 24 May 2022 08:35:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3F45D8D0002 for ; Tue, 24 May 2022 08:35:47 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 17D776140F for ; Tue, 24 May 2022 12:35:47 +0000 (UTC) X-FDA: 79500583134.26.5C83CF4 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by imf14.hostedemail.com (Postfix) with ESMTP id 698C8100029 for ; Tue, 24 May 2022 12:35:43 +0000 (UTC) Received: from mail-yb1-f174.google.com ([209.85.219.174]) by mrelayeu.kundenserver.de (mreue109 [213.165.67.113]) with ESMTPSA (Nemesis) id 1N9dkB-1no4MH3ZhN-015XgV for ; Tue, 24 May 2022 14:35:45 +0200 Received: by mail-yb1-f174.google.com with SMTP id g72so2564120ybf.0 for ; Tue, 24 May 2022 05:35:44 -0700 (PDT) X-Gm-Message-State: AOAM532l/9f6ogJYEtFj+6ldnPTdtr2HPcDZShu77Ex9wOz35LYCFs7s +F9rrQzz5I/l5NEznEhuKVAiLVbaxEx8IWjl6ZY= X-Google-Smtp-Source: ABdhPJz9m9ORZ9D9BvYMed+3CBOfj9iqcDQAfnck/FOZ2NFPYY/aPURrCNWdk7JUo0ug0DMQDbzsidcl1E/w96/ZJ20= X-Received: by 2002:a25:5e09:0:b0:64d:8543:627d with SMTP id s9-20020a255e09000000b0064d8543627dmr26382655ybb.394.1653395743407; Tue, 24 May 2022 05:35:43 -0700 (PDT) MIME-Version: 1.0 References: <20220519082552.117736-5-wangkefeng.wang@huawei.com> <202205240657.BXxrhbgp-lkp@intel.com> In-Reply-To: From: Arnd Bergmann Date: Tue, 24 May 2022 14:35:27 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 4/6] mm: ioremap: Add arch_ioremap/iounmap() To: Kefeng Wang Cc: kernel test robot , Catalin Marinas , Will Deacon , Andrew Morton , Linux ARM , Linux Kernel Mailing List , kbuild-all@lists.01.org, Linux-MM , Christoph Hellwig , Arnd Bergmann , Anshuman Khandual Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:hMcGOyZyr6D68CfIcS4yh0DjJ+8jOLEMUaULSJjcB81gE3oeHCc 0LvBMMRUK1sQxNcGARcVB0cbebQz2f1l+K0U08fvQ+aAQBNgiSrOhxgv43DGn9TZaV587E2 0MB4gfG0s3OWuN4RLgJefBKyX81Up1iCU1wIa+VjDnyMsijHqYEK+J4z7on/PgAh3f8FKDi NwcbvNNpLdbcOjFg3FMaQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:AWXzo+EIcFY=:MMdkVz89VYdY91qkRM0PBm goMdoFy4PgHPHkGAYczxfvZFH+rSxXb46A9+pIK6uwvxNMSmc+WLDPiHbo0zTZVHLdo0h107a kIXL6WNl7Kg4xGhGG/SvjOtzCrfTk7dLynAel3D3PtPEodRpmlAsgFpZUOvlwWV4hmza4b7/c AWPOtIOxCEvTY3VJoBZUnrWmsbGipsRHCtkhhvliO7kgW9SXPcHcDSG3IzHAgIUJ0OiaeNQ09 IozxgKrSBdp838hH2jPUUQK45TpBTO4jEWJUnbQ0XUFCpczk4SIWAtG1M/AVvXTkBCn/NyAs+ mZB09zVUAJkK+4VoNn7j7S+i7RTve9UuJEqLhGkKdlOrYySJJQisziirKblHY6m/aozDUfeoy FyjUWzd5RV9ny21fe5F+SlVt6G9UjkAb+qH5S9Y5bwQ6kBaXq3+kecocscMUFFdkX2xrMtX2T yXysd+AsgAdpQyqC7OvGGu49jHJ3UGGUr1yL2q4FbVNAki4+qI/UyLhsmRj96a76g2qNvB8u8 EXNvi88ejZV0ltLrDpy8vdAc8oMY25z0kG9+c/n8J1uwp2CYCPW/27W+pcz6bAmx6IIf6JqhD p/G3LSBswAstjvAVssdrPXa28K5Uy9Pu7moDoE0o4eoB9+LEM052YaWMilE4XawwtEs6qCx8j N1gW1UGnQMMK5PXpYSszaYGV+JAiwI/G97ZqNXtq220KigvKN9/68bksVRp6VoV4csnUpAJov e4HKDpzfhKuhrnRsKZwrbzaJRxBvof+fyDl/HOKssHZFOxs+ZVe0fW5PSB1TSTixx0cgwEvZy P9uHboRPs10VBAyAn4MFixfS1m7RWmMTYxNrT+Cpa1s9UYS+jWFiNdLKGBGj3qfbXfUBfkyGn 5p1VsgzSINubzGID6vyg== X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 698C8100029 X-Stat-Signature: 8ch9jdoz7wpiz6az1d31b87x7mwc85t4 Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=none (imf14.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.17.24) smtp.mailfrom=arnd@arndb.de X-Rspam-User: X-HE-Tag: 1653395743-823275 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 24, 2022 at 11:48 AM Kefeng Wang wrote: > >>> mm/ioremap.c:59:16: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const *addr @@ got void [noderef] __iomem *vaddr @@ > > mm/ioremap.c:59:16: sparse: expected void const *addr > > mm/ioremap.c:59:16: sparse: got void [noderef] __iomem *vaddr > > > > vim +59 mm/ioremap.c > > > > 51 > > 52 void iounmap(volatile void __iomem *addr) > > 53 { > > 54 void __iomem *vaddr = (void __iomem *)((unsigned long)addr & PAGE_MASK); > > 55 > > 56 if (arch_iounmap(vaddr)) > > 57 return; > > 58 > > > 59 vunmap(vaddr); > > 1) Will add generic "arch_ioremap/arch_iounmap define" > > 2) and change this to vunmap((void *)vaddr); I think this need an extra __force to actually suppress the sparse warning, as in vunmap((void __force *)vaddr); Using __force is usually wrong, this is one of the exceptions, so maybe add a comment as well. Arnd