From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E68FBC433F5 for ; Fri, 6 May 2022 07:18:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 443F56B0071; Fri, 6 May 2022 03:18:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F37D6B0073; Fri, 6 May 2022 03:18:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E22D6B0074; Fri, 6 May 2022 03:18:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1E55A6B0071 for ; Fri, 6 May 2022 03:18:04 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DD3CB2E113 for ; Fri, 6 May 2022 07:18:03 +0000 (UTC) X-FDA: 79434464046.02.61A88AD Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by imf29.hostedemail.com (Postfix) with ESMTP id 869FC120026 for ; Fri, 6 May 2022 07:17:57 +0000 (UTC) Received: from mail-wr1-f47.google.com ([209.85.221.47]) by mrelayeu.kundenserver.de (mreue106 [213.165.67.113]) with ESMTPSA (Nemesis) id 1N5n81-1nu8CQ1cl9-017IAh for ; Fri, 06 May 2022 09:18:01 +0200 Received: by mail-wr1-f47.google.com with SMTP id w4so8781484wrg.12 for ; Fri, 06 May 2022 00:18:01 -0700 (PDT) X-Gm-Message-State: AOAM530iVuss8f5CjeYXqyhfONapQsQdN8ixWwSjMkjpHZE0LzfV+61v pUcpBOxDT4yPEO3J19lLv3cPB1glboATlHsGTfI= X-Google-Smtp-Source: ABdhPJxk5kmKl/NuJo2Kw6gbDMmUHBC9PzM37HJ0IpduByOSpYwlVh3nYidBN6G2ViFW9sJzR1YaV0REdELOtYll4hY= X-Received: by 2002:a5d:5986:0:b0:20c:5844:820d with SMTP id n6-20020a5d5986000000b0020c5844820dmr1472517wri.192.1651821480693; Fri, 06 May 2022 00:18:00 -0700 (PDT) MIME-Version: 1.0 References: <202205031017.4TwMan3l-lkp@intel.com> <8704209d-d487-a297-b05a-5db99f5f808c@intel.com> In-Reply-To: From: Arnd Bergmann Date: Fri, 6 May 2022 09:17:44 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: dove: fix returnvar.cocci warnings To: Philip Li Cc: Dave Hansen , Arnd Bergmann , kernel test robot , kbuild-all@lists.01.org, Linux Memory Management List , Tony Lindgren , Russell King , linux-omap , Linux ARM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:1Df5NCPFLWdhoybRj+qfdSECinSfHLRvqRvwj45r5YI2eSq9Fve cxjsj0c4ajuCpONb5fNhHzpB5/Z7y/XDw6IT/bQ4KXzq1BkvBbewH0Nx0HcsIhDL3CLcpzV mpu+SesXScGXWtyY4e5tbhodqx+uCEdE2sJqk+Hk/UQSUS/Iaddtg3RymgkZigwvsqCKEAY 4e/s1C2KpAnb4ee3pt8aw== X-UI-Out-Filterresults: notjunk:1;V03:K0:uvTC0d5EnJY=:+Bg45UxAkzbXr1vhtNmG4o CeuNRBNd6NxCxwflaFCAdX9PPXRPXxc2EzctCQJQzkwZM22aDCoefz/2iPuN/cqR1ma+L7Bax TkAtAog2uMytbvXe6WDr3PP8HBtMAgjUxbYm+F4irvF94cz4Q2G/7WAEH/aG8x02/+kgzN//K TCbrpwhH1tyRwX+SlfSzC3ZZMvQBRNzLT7odwu96fUHjTqS90tG0agV/28OtdhsoHN9RqCHQx xQNI2uEqbnhVSyfXEcnia+RfAeHD8nSgJBKkfO4OsI7nHtuYNkcVwkcgzChZxabwIF4rEdrc8 OrtRIFasdQcqjxohuTnd1N5lTU2pUUvei4MFhSi1VL2LGrD+RF4KCODvjc9XnpY0VjFfjlqcN rzEFCJcE7a2L10ZUieSrmKBHg1VyLLLhzjCWUPv6PDxrat8p5v4NwzeOMJ+foTtx7KtzRc4Bw lQjBDb4edvtiWSPx5MRwPAtoo+HKOAoQ/ZF+P7S8HSnojxJcdhtrdinWcQDJ9EdtlhxWbb4I9 VrD2FOCAk8PAFTaaQNIrdJWy7/c0zRqTuWEknF9/emWkFmNYeQKh3Sqjnvw2yCwUGeUzPANon /G/ZEfu0tVJMuvknWl9hxDfzn3cZ5seh8Cys5YZ6se77m4pmXpDFZvXvCjrwaLC8knxoc9Sf5 Y0sgrTPPvp0/r/L7m8Ge6e7xaNYcDjm6skHGotURYOs3+ATRbYLq0XB/2Z7MoeNAj0DmproNt 0I4uB8gg1Z2dHiNvTTndKbS4FY/4+/p/rhY6/XAo8qh4LNmqjfEqF6DL2J6tAA6x/vUODS+7J 0A1a/bX0BMmSPzcxAKgw+k3aMsyHEikdTvr/Fuyh2Tkc4mnqps= X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 869FC120026 X-Stat-Signature: wibjopxb4prr54atwk39qsk83p5pz7kb Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=none; spf=none (imf29.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.17.24) smtp.mailfrom=arnd@arndb.de X-Rspam-User: X-HE-Tag: 1651821477-162016 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 6, 2022 at 3:09 AM Philip Li wrote: > On Thu, May 05, 2022 at 09:31:37AM -0700, Dave Hansen wrote: > > On 5/3/22 00:21, Arnd Bergmann wrote: > > > On Tue, May 3, 2022 at 4:45 AM kernel test robot wrote: > > >> From: kernel test robot > > >> > > >> arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 > > >> > > >> Remove unneeded variable used to store return value. > > >> > > >> Generated by: scripts/coccinelle/misc/returnvar.cocci > > >> > > >> Reported-by: kernel test robot > > >> Signed-off-by: kernel test robot > > > I checked the patch, and unfortunately it is wrong, the current code > > > needs to stay. > > > The problem is the SET_DMA_ERRATA() macro that accesses the > > > local 'errata' variable. > > > > 0day folks, do we have humans looking over these before they're going > > out to the list? If not, can we add some? If so, can the humans get a > > little more discerning? ;) > > Sorry all for the bad patch. So far, we pick up several cocci warnings that > we have confidence based on early result analysis and feedback, for these > warnings, 0day sends out patch automatically. > > Thanks for the suggestion Dave, We will change current process to be more > conservative and to avoid false patch by adding human analysis. For the returnvar.cocci false-positives, I wonder if it's possible to find them using another coccinelle helper that detects badly formed macros which access variables out of scope. I can't think of how this would be expressed, but maybe someone has an idea. Something else went wrong in this particular patch, and I can't explain how this happened: the subject line contains the name of the wrong platform, "dove" rather than "omap2". My guess is that this was human error copying the subject line from another patch, but if this came from a script, you may want to check how this gets generated. Arnd