From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A46A5C43334 for ; Thu, 30 Jun 2022 06:05:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE43E6B0072; Thu, 30 Jun 2022 02:05:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E6CB78E0002; Thu, 30 Jun 2022 02:05:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0D5B8E0001; Thu, 30 Jun 2022 02:05:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BE7396B0072 for ; Thu, 30 Jun 2022 02:05:25 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8321860663 for ; Thu, 30 Jun 2022 06:05:25 +0000 (UTC) X-FDA: 79633865010.10.22172C2 Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.133]) by imf28.hostedemail.com (Postfix) with ESMTP id F4037C003B for ; Thu, 30 Jun 2022 06:05:24 +0000 (UTC) Received: from mail-yb1-f173.google.com ([209.85.219.173]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1Ma1wa-1oA6hb1SfU-00Vx5B for ; Thu, 30 Jun 2022 08:05:23 +0200 Received: by mail-yb1-f173.google.com with SMTP id g4so20398944ybg.9 for ; Wed, 29 Jun 2022 23:05:22 -0700 (PDT) X-Gm-Message-State: AJIora+4OvZCiSLmwicSJZaXBuZE7DnAHViBn/uCpeSJX0Sw6Y31ZMSd pXxs1YSgtXIdWSsrYBEbIv9/2/8WvTQAgzds8ZY= X-Google-Smtp-Source: AGRyM1vtT3pzk3IDIUdnI7V5TjBcb4k7QQp50McXs21ca3emcSDlR6eKLW5igXc4ObexSkfmEIzbtJFUPtpYReNpT5o= X-Received: by 2002:a05:6902:120f:b0:668:2228:9627 with SMTP id s15-20020a056902120f00b0066822289627mr7959756ybu.134.1656569121704; Wed, 29 Jun 2022 23:05:21 -0700 (PDT) MIME-Version: 1.0 References: <20220630043237.2059576-1-chenhuacai@loongson.cn> <20220630043237.2059576-4-chenhuacai@loongson.cn> In-Reply-To: <20220630043237.2059576-4-chenhuacai@loongson.cn> From: Arnd Bergmann Date: Thu, 30 Jun 2022 08:05:04 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 3/4] mm/sparse-vmemmap: Generalise vmemmap_populate_hugepages() To: Huacai Chen Cc: Arnd Bergmann , Huacai Chen , Thomas Bogendoerfer , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Catalin Marinas , Will Deacon , loongarch@lists.linux.dev, linux-arch , Xuefeng Li , Guo Ren , Xuerui Wang , Jiaxun Yang , Andrew Morton , Linux-MM , "open list:BROADCOM NVRAM DRIVER" , Linux Kernel Mailing List , Linux ARM , Feiyang Chen Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:7Nyq0weKJxS3+wxtYxlT0ZENw8y6gMRJy7EpjohPpVxBMn8Ao/L AxCjjYtpEyJCXYv5uabNuDZXD8qarjO52HmIm0rtUevbsXPNbBcoN4JmKs+iucN0SlqApiW EVE7QGSN6ZwU8PQfQCONGaPZSIhZSpChE5TnDZooghA0cFQDJYTL8BCnYMj6/kQSG3FVXlt 3Mw3NicQ9kW1ZzCuaK4zw== X-UI-Out-Filterresults: notjunk:1;V03:K0:oaR1VAtV9h4=:MHqtZciMHKMi4+wzx2qJ5+ /RlpMiga89URLKkHE0OyscvS/Mv6hCr36t3koJGbdjttjZHsKSYeYMfV4fWCDL9p8+xw/spl3 TOC1WkMFIkQM3f87w0dAQt0ix0yyLhikBd3eOV1HsYyJ1X/Qj9OeLeo3oOj2saDfeelfzJ6IV YFS9nJAaMQY69mOa3zBUEOL0yFFY7SBSKVWUBQe+n4E4TskmGXbNdYMpQlKUEUN4kLbxEPqCd YUbMs7dvPAjWBZ8jBIQ8ZoX2L7yv1k4LlAi6zHvdzya074c/xIX9YM+MED8tFnfgGpPqbdzCF nQpY0pQGZEzrWb76wu9678ZGBVG2VbZgQgBHmiLbtNhalCuBqYXOGDRgiEdYJyC3IYS6gdj9M 2ydTwaxevcOBkFWklbxs6BMD5vtzOTiOcbgOkwyGGbdUdJRYTHFfegHFjDM0PX3vBmga8ntO+ PUxVIfHXuP2zF7qsiQnvCMg0UEog5jBcs/DsUrNtL5tMgS3xtvX+EGZmQ0FIe8K60IRmhWTuC STg+fEz9AC6DLpOaZd/xSouWOTCP1qoavkGu1qQp842gkzFzzVJXcYZobkOquLQv5KvdAe77N OgXxVBLr/RoDVjWqZU8z3qDHX1qAt4x0/jWFMbtf7afrsNgM4PhrL1xGR0HUg5ZQWC8Uoh3mk suP6u/kTsutalkFekLEitg9uvk8jEmIbuH/Pn92DIVX7spGC+BXVBORg4RcXES1zqdJn1Ka8v HIVb5j8FUpH3MKMCe23Rxqq7vWeKzJoJJxi8mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656569125; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y07IJIY2PVG2W+KVUqwOvQgsNreP5AqI6a/EQhTQOkg=; b=TD1nu01kbXNMzb6EkfabdlSElw3dK8iBlUykaZxeMh41VdSrw/pfM67K2gZj5n5RQ6hZF4 ab/TE/ISSoOyOyyVDfGTeAMhMwEe94CksbOOSE7PLwu9SQ4nxRNOkGDAqXm4NRiUyKY7NQ bun1H0tlmZKn2Pj6IP8FyyRIDkQzr28= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656569125; a=rsa-sha256; cv=none; b=RL48DIyI4glN6K2vErebZXuRlDWZBnXFENRSBJlJOOU7B6W4Y2pWGoQiws98Ad1i5QqOOF PlBQijDwVTQqM34qdkO1isZuUpaJpEtCD2vnj99+xl3zSxkcWxTQWCth10vNL/piMSB7xI Vnp0lzRDNfuB4d3XrP54/460qlr2N0E= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=none (imf28.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.126.133) smtp.mailfrom=arnd@arndb.de; dmarc=none X-Stat-Signature: yzuh5t3wcs1xun1f4xhwcdfwr1dcifc8 X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=none; spf=none (imf28.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.126.133) smtp.mailfrom=arnd@arndb.de; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F4037C003B X-HE-Tag: 1656569124-700704 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 30, 2022 at 6:32 AM Huacai Chen wrote: > > From: Feiyang Chen > > Generalise vmemmap_populate_hugepages() so ARM64 & X86 & LoongArch can > share its implementation. Sharing this function is good, thanks for consolidating this > Signed-off-by: Huacai Chen > Signed-off-by: Feiyang Chen The Signed-off-by lines are in the wrong order, it should start with the author and end with the final submitter. > index 33e2a1ceee72..6f2e40bb695d 100644 > --- a/mm/sparse-vmemmap.c > +++ b/mm/sparse-vmemmap.c > @@ -686,6 +686,60 @@ int __meminit vmemmap_populate_basepages(unsigned long start, unsigned long end, > return vmemmap_populate_range(start, end, node, altmap, NULL); > } > > +void __weak __meminit vmemmap_set_pmd(pmd_t *pmd, void *p, int node, > + unsigned long addr, unsigned long next) > +{ > +} > + > +int __weak __meminit vmemmap_check_pmd(pmd_t *pmd, int node, unsigned long addr, > + unsigned long next) > +{ > + return 0; > +} > + I think inline functions would be better here, both for compiler optimization and to make it easier to track the code flow. The normal way we do these in architecture specific headers is to override the functions by defining a macro of the same name. Arnd