From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BEBAC432BE for ; Thu, 5 Aug 2021 06:46:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 899ED60EC0 for ; Thu, 5 Aug 2021 06:46:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 899ED60EC0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 163876B006C; Thu, 5 Aug 2021 02:46:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ED8B6B0071; Thu, 5 Aug 2021 02:46:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED0498D0001; Thu, 5 Aug 2021 02:46:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id CFC746B006C for ; Thu, 5 Aug 2021 02:46:13 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 72362AC0C for ; Thu, 5 Aug 2021 06:46:13 +0000 (UTC) X-FDA: 78440092626.27.67695A3 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) by imf25.hostedemail.com (Postfix) with ESMTP id 750B8B0001AF for ; Thu, 5 Aug 2021 06:46:12 +0000 (UTC) Received: from mail-wr1-f50.google.com ([209.85.221.50]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1M1YpJ-1m8V8i0MRf-0032j1 for ; Thu, 05 Aug 2021 08:46:11 +0200 Received: by mail-wr1-f50.google.com with SMTP id c9so5030123wri.8 for ; Wed, 04 Aug 2021 23:46:10 -0700 (PDT) X-Gm-Message-State: AOAM532ZgY0+U9KDNLyWuS9vmAO5SfCKpcZphlFKbOnATPdN+cJ1rzhE xOBBaKYRRrDnBH177vPdtmrzVbog7Cey2ogVtu0= X-Google-Smtp-Source: ABdhPJyxgj8VIAwqZDTBChx9JSU3D2TgK9tXtdv41Bto0HO/Dh2DmlkqO4kPCcds3kEGPU1qkuE5cs68sRfYrNll2bs= X-Received: by 2002:a5d:44c7:: with SMTP id z7mr3409608wrr.286.1628145970199; Wed, 04 Aug 2021 23:46:10 -0700 (PDT) MIME-Version: 1.0 References: <202108050531.p7zYKip9-lkp@intel.com> In-Reply-To: <202108050531.p7zYKip9-lkp@intel.com> From: Arnd Bergmann Date: Thu, 5 Aug 2021 08:45:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-next:master 4771/5318] drivers/net/ethernet/cirrus/cs89x0.c:914:3: error: implicit declaration of function 'disable_dma'; did you mean 'disable_irq'? To: kernel test robot Cc: Arnd Bergmann , kbuild-all@lists.01.org, Linux Memory Management List , "Linux/m68k" , Geert Uytterhoeven , Greg Ungerer Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:WWEy6XLf5+HSQhTdO5dKupvtFrwlqY/CJgCG5wNCJNJndnLZ8L6 sVFzwf4/9Mdp0jA5zvY47jOYwbCBwsP+gc/zIR6CoSyO2VCnrrn4YAaZuIV1+khLW2oujub pKQYUrPt6NL1MDx/BVLuwJE1esr/E7JACXFudGU16FSKVYrlcWKigTnIx1b/cczzUzYNbNq hfHtTFW2PBI7JbSMkQnvA== X-UI-Out-Filterresults: notjunk:1;V03:K0:RFlfg+9rRf4=:Bapoum1xQzBLkb0guC3YH1 nIkqcng5UYPKxWzrOjVIjUfs2h8Dk25TIfX0qa0dj+rfPKK/J4IH+ktN9Dbvpo6oI/1g0xR1Y 1b1tC+xLIx21zzQ6tkZU4oYU4AOyCuSEZrrl1/zEzO2x/1Zlrf26ThhYlVBiJfqeuiynPwFbJ 3qcZSP+9MLeENEEtXcnxJPk8An/ASuFlhVt1XXDxxflq13UFpnxdmPnCsOrfQOnu3PLGvgKJv N6Np2dQHacDg0pBpDL+S0Xp/XJUzslCoSsO6sQciDkKaUZGHJXx8cERcGlIeIhl5/2f/4YEPa BkgOdep1wypcF3ZFXZ6GSMEupXK701n+19XtRhYnAGRLO3BLvKsKl16bQY6ZnJBCtv2OTAM5H oR0+3LLcaEnC8pmbGvCuGjRKbYGkBoxaGMTXSAOMKp4ENVb7Y0LUhyeUTkzOfiFewVpfjJFDn 1lo7OomWxe+9oo/YA/ryxchpeZ1ukC6knVqE4SCoHNlTGSucSLVc0p33AlXu6C/v9wKFP1ONj bUR8MBgAGbPhqfXaFjTuzMg1ASej8FCiPPLM8wmnHY1VRSluMoLZiUNxwljkAgE0+vmd5QROP ZTmQz0sUN6Y1yM3Ulertfc28z8wxkGU65N4mH3tWGOoJsxl6vhjzMMObURJSWEAa4hsyP8VWX WrWplmm0fkgA5n7r23xXfh16CfV3UvE+kz0sDt5NQzFc9/0Rytb3Apty4yiUeBWYlLEH7Z5UB 72ROVqYRz1a7BioC68Yv900j/YRxOu7cpLd7JIJcD+IQRLhPOMWWXWu5A462YimlCtTfUAaZq HdUsSjtYQ1JQqolywNAPfESSok6qrSA87NhrEodLmZQ2ZUH7nwVtcPRftkpFhEE8q9nLlD1AS 6dj3lEOKjJqi1iK+Kg6yntM2HGrPyQey/jzz68fUeZbHgEeRDXoQjR7uhBn0PzV608cixY1Cs ZmtBaygn6I1GTNhyv39X92Ws2NyZz1h94usZDUk2P0Qp3sjChhjSz X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 750B8B0001AF Authentication-Results: imf25.hostedemail.com; dkim=none; spf=none (imf25.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 217.72.192.73) smtp.mailfrom=arnd@arndb.de; dmarc=none X-Stat-Signature: 9di3ty1hk91whjwzmirarahaft5ikzfi X-HE-Tag: 1628145972-595487 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 4, 2021 at 11:15 PM kernel test robot wrote: > > Hi Arnd, > > First bad commit (maybe != root cause): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 2f73937c9aa561e2082839bc1a8efaac75d6e244 > commit: 47fd22f2b84765a2f7e3f150282497b902624547 [4771/5318] cs89x0: rework driver configuration > config: m68k-randconfig-c003-20210804 (attached as .config) > compiler: m68k-linux-gcc (GCC) 10.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=47fd22f2b84765a2f7e3f150282497b902624547 > git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git > git fetch --no-tags linux-next master > git checkout 47fd22f2b84765a2f7e3f150282497b902624547 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=m68k > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones prefixed by >>): > > In file included from include/linux/kernel.h:19, > from include/linux/list.h:9, > from include/linux/module.h:12, > from drivers/net/ethernet/cirrus/cs89x0.c:51: > drivers/net/ethernet/cirrus/cs89x0.c: In function 'net_open': > drivers/net/ethernet/cirrus/cs89x0.c:897:20: error: implicit declaration of function 'isa_virt_to_bus'; did you mean 'virt_to_bus'? [-Werror=implicit-function-declaration] > 897 | (unsigned long)isa_virt_to_bus(lp->dma_buff)); > | ^~~~~~~~~~~~~~~ > include/linux/printk.h:141:17: note: in definition of macro 'no_printk' > 141 | printk(fmt, ##__VA_ARGS__); \ > | ^~~~~~~~~~~ > drivers/net/ethernet/cirrus/cs89x0.c:86:3: note: in expansion of macro 'pr_debug' > 86 | pr_##level(fmt, ##__VA_ARGS__); \ > | ^~~ > drivers/net/ethernet/cirrus/cs89x0.c:894:3: note: in expansion of macro 'cs89_dbg' > 894 | cs89_dbg(1, debug, "%s: dma %lx %lx\n", > | ^~~~~~~~ > >> drivers/net/ethernet/cirrus/cs89x0.c:914:3: error: implicit declaration of function 'disable_dma'; did you mean 'disable_irq'? [-Werror=implicit-function-declaration] As far as I can tell, this is a bug with the m68kmmu architecture, not with my driver: The CONFIG_ISA_DMA_API option is provided for coldfire, which implements it, but dragonball also sets the option as a side-effect, without actually implementing the interfaces. The patch below should fix it. Signed-off-by: Arnd Bergmann diff --git a/arch/m68k/Kconfig.bus b/arch/m68k/Kconfig.bus index f1be832e2b74..d1e93a39cd3b 100644 --- a/arch/m68k/Kconfig.bus +++ b/arch/m68k/Kconfig.bus @@ -63,7 +63,7 @@ source "drivers/zorro/Kconfig" endif -if !MMU +if COLDFIRE config ISA_DMA_API def_bool !M5272