From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F9D0C433DB for ; Tue, 16 Mar 2021 16:34:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A593A6510A for ; Tue, 16 Mar 2021 16:34:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A593A6510A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 225656B006E; Tue, 16 Mar 2021 12:34:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FB9B6B0070; Tue, 16 Mar 2021 12:34:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C3FD6B0071; Tue, 16 Mar 2021 12:34:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id E0C5A6B006E for ; Tue, 16 Mar 2021 12:34:45 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A95858146 for ; Tue, 16 Mar 2021 16:34:45 +0000 (UTC) X-FDA: 77926286130.23.BA03FDE Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.74]) by imf04.hostedemail.com (Postfix) with ESMTP id 5D81C3DB for ; Tue, 16 Mar 2021 16:34:34 +0000 (UTC) Received: from mail-wr1-f47.google.com ([209.85.221.47]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.113]) with ESMTPSA (Nemesis) id 1MI5cP-1lSXVv3phP-00FD9D for ; Tue, 16 Mar 2021 17:34:32 +0100 Received: by mail-wr1-f47.google.com with SMTP id v4so7770604wrp.13 for ; Tue, 16 Mar 2021 09:34:32 -0700 (PDT) X-Gm-Message-State: AOAM533UWrUF4CZHIjdlwQxFHDhN6+txJGmFB9ul29Mm14z0q4tJO3Z2 GhUH/90C+Q8NMS23IGlTMLCT8iR1ngqF5kkRBX8= X-Google-Smtp-Source: ABdhPJzb9iprP4M8tU0/IT6/VJb45ZSaimIVd+80NDg8EBrdJQjoVOPX+YrkaQIT2NZuyIHCdxe+q5zWdKli+rvEJMs= X-Received: by 2002:adf:ed87:: with SMTP id c7mr5923866wro.9.1615912472247; Tue, 16 Mar 2021 09:34:32 -0700 (PDT) MIME-Version: 1.0 References: <202103160133.UzhgY0wt-lkp@intel.com> In-Reply-To: From: Arnd Bergmann Date: Tue, 16 Mar 2021 17:34:16 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: WARNING: modpost: vmlinux.o(.text+0x74fea4): Section mismatch in reference from the function memblock_find_in_range_node() to the function .init.text:memblock_bottom_up() To: Nick Desaulniers Cc: Mike Rapoport , kernel test robot , kbuild-all@lists.01.org, clang-built-linux , LKML , David Hildenbrand , Andrew Morton , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:rrUPx0co4NXV3HHTr3ZMQQMvllELW6aU8femdSkHNTBa/o8/a66 pOfKuEIepc6GZr0L1VNFCEQj8r4Y3eCCcFwSJM2HXTxjYFXchVUMVwyUUgr0kLiicln0dYf O6S4HA+MqYMpfJPVvVwiiXJiREpljPuRVm0O5Lolv7/Qhx2d2uApgWaqKcc8tt50iYnFDFv bsPS9Vf+PCUZXgx9hNvQw== X-UI-Out-Filterresults: notjunk:1;V03:K0:pD1Gk9NPH3M=:423BN574rhoHj+gHbe5qO+ +6FwJLByxn6+2ZHmSi5FoBlsLkvLRqXOXLg8ppH76+fJDIH+BIlDt+k6B5/jjMPKBBxhN00iQ w4lkMD16rULaM/cxUouR+tgqHbk+PZMS5FpjHeNw4JIFdGwajGP7uzrRAiAJcexld069YcCbd HrtUukh8IvBSsbbN4MNth4omi7epPF3So5I8wP14jamXiakcQg6BR5i9j/d/jIHuxy7X0hyMX oyDfckq+eZNVruxqLtiTzuSdKyrrK60fd3aQxC8rWCzXyvkB8pW/+QLofXi/oPMy2R3My47hT Weoz6p9Efig+8OI05tM27wjtS62PaakqZTfKoHLn3TmOxzYzyS6eQcUkyDmcPQ753Hkdkxo+Z sc8wyjwDSFYSpj0IioW5NnVuP0IusIp0wFS7bCZ4/KAsE398p3UsxW9/wbL4ruCo8rLE0YfWM ie6P5xKZ43U+ZBA7k2tyu8maek7t8IKLyejiTx7Ms9gsgiPdVoYaHqKOHbXwS069/OJO1Tcyb Zu6h5AQaSzdY90GRTH5Hqs7CkHZXWaX8DhoC+71kWmiZL2rfWOZwFS/e1A2XXy6kw== X-Stat-Signature: dty8padczjwqft4p8zo9xq4qmj91e5mq X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5D81C3DB Received-SPF: none (arndb.de>: No applicable sender policy available) receiver=imf04; identity=mailfrom; envelope-from=""; helo=mout.kundenserver.de; client-ip=217.72.192.74 X-HE-DKIM-Result: none/none X-HE-Tag: 1615912474-586074 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 16, 2021 at 5:23 PM 'Nick Desaulniers' via Clang Built Linux wrote: > On Tue, Mar 16, 2021 at 12:04 AM Mike Rapoport wrote: > > > > I don't have clang-13 setup handy so I could not check, but I think this > > should be the fix: > > Thanks for taking another look: > https://lore.kernel.org/lkml/20210225205908.GM1447004@kernel.org/ > Do we want to switch the above to the below? The patch above is now in mainline and caused the reported problem. > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > > index d13e3cd938b4..5984fff3f175 100644 > > --- a/include/linux/memblock.h > > +++ b/include/linux/memblock.h > > @@ -460,7 +460,7 @@ static inline void memblock_free_late(phys_addr_t base, phys_addr_t size) > > /* > > * Set the allocation direction to bottom-up or top-down. > > */ > > -static inline __init void memblock_set_bottom_up(bool enable) > > +static inline __init_memblock void memblock_set_bottom_up(bool enable) > > { > > memblock.bottom_up = enable; > > } > > @@ -470,7 +470,7 @@ static inline __init void memblock_set_bottom_up(bool enable) > > * if this is true, that said, memblock will allocate memory > > * in bottom-up direction. > > */ > > -static inline __init bool memblock_bottom_up(void) > > +static inline __init_memblock bool memblock_bottom_up(void) > > { > > return memblock.bottom_up; > > } I don't see the warning on my machine for some reason, but the patch does seem correct. Reviewed-by: Arnd Bergmann Arnd