From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA732C433EF for ; Sun, 14 Nov 2021 22:05:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38CAB60C40 for ; Sun, 14 Nov 2021 22:05:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 38CAB60C40 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 617876B0078; Sun, 14 Nov 2021 17:05:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C7686B007D; Sun, 14 Nov 2021 17:05:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B65D6B007E; Sun, 14 Nov 2021 17:05:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3B0F16B0078 for ; Sun, 14 Nov 2021 17:05:13 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id EB608184C0533 for ; Sun, 14 Nov 2021 22:05:12 +0000 (UTC) X-FDA: 78808917264.20.6DBABBC Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.17.24]) by imf01.hostedemail.com (Postfix) with ESMTP id 5F7BC5092116 for ; Sun, 14 Nov 2021 22:04:56 +0000 (UTC) Received: from mail-wr1-f46.google.com ([209.85.221.46]) by mrelayeu.kundenserver.de (mreue107 [213.165.67.113]) with ESMTPSA (Nemesis) id 1N9M5y-1maGiw2vwK-015FhO for ; Sun, 14 Nov 2021 23:05:10 +0100 Received: by mail-wr1-f46.google.com with SMTP id d24so26821685wra.0 for ; Sun, 14 Nov 2021 14:05:10 -0800 (PST) X-Gm-Message-State: AOAM531vLvOfVjZ3GK3+vNZusSVrNODkxyJzIWOA/JoFqLlaR2S0Iint 80aWgVuA1HDAMC0lDkYeQUqyk3Sg+bUPKFb3Mhg= X-Google-Smtp-Source: ABdhPJz1k2PRyR2pmvTjcTBsWWHAw9pSmKIoUtwnmVc2tgXGFCqkuFE2UPryKhUJ7sGy+V5SWxaA2kz6rpPPfoPdBao= X-Received: by 2002:adf:d1c2:: with SMTP id b2mr41326612wrd.369.1636927510071; Sun, 14 Nov 2021 14:05:10 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Sun, 14 Nov 2021 23:04:53 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: SH: error: implicit declaration of function 'init_cache_node_node' To: Randy Dunlap Cc: LKML , Linux-MM , Dave Hansen , Andrew Morton , Arnd Bergmann , Rich Felker , Yoshinori Sato Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:iH/+6NXLEylKm8bu+X1V8eo3W6akVTRCEup0Uphq34SiHjFzBal PdAruWvo3DJnAWaTrqkwaFyrKIblxHH7VR2e3eA3u3xGuIGMAOmcSlY+tw23OujFAh0HM5U 5Zj/3CgTpfDxHWKLcdTtXLa3OvNRLjF+ehF326GF6RhQbUWfp1GLV8548dJSoo7d/+nOd1I mLRXEXr1ssCbqXUGXrCNA== X-UI-Out-Filterresults: notjunk:1;V03:K0:oKSVzsluuVA=:SIKOJtWJWcbbjx13JU+nwP YjxXH5DCg/NsHvaRA9fdaFFxjTA86VyE1dgnziruVvLCEVuKSvATXF/reH0rYM9rn2Pd6h6R+ ctUt3SpEGE4NAlOK2brrckOKErwkdPbRxesyYpNz57C7M9EGSar6jAnqmeZkjftETZovAigpN AcAxxUa0yPp8UWKaXYcvxo5ZjQbmtielEodlFXgoydlzNXiI97IKGmcREYLNUbia0QHg0B35G /1g+PETiDNloloFmCFsgy0V9n/sOk//D7bhVN6mxTIvxvGaLdJeH82hRvsAQucE76rigLHfyD bCzMTC88lz2H8thdFq/fJ/933BV0YkvTkTlvIdedxXUoW1GNi0cfv2oWpTFBdhlEz1RPbN4J+ kZvIgjc256EMrZ3026EDDCeOcFqCbPlZq3I4jyyw+R7m4yASEX1BBoVzouZBnaUwTIoT3FcXL UKf0afw4jGk2ZuBlrbkX+/3MrTKn2fRRlXmRROyWiC8rZv8qz1ZI2zYB4Bt6wOcC2jwluCGMQ XUhAPA5eoQF8cR8QYXFmVLqVj68qgwJbjF0vewYOjVRDXrfcNQyY7bNisEpun8j6EbWWZoguP p7REYbHIZ4x2neFCIhX2aosFwOQUo14lBhz3VnKlQcYZfEjzNuFWIfUF4xVT7kKfbMV8gTKYC ik2JJjTthBppalaZeSFZUKEVD4lvGl53t+9qJtfPpYtrLGC8P43s6FBu91ACdnoNlm2KT60ux o4MxyWsUyNZ5wWfAwNp0mN2wDIZtiONKow/+v5Avkp0SM2f+Ljl02pEHIOs6sYhA7ilKLkp8/ 6tbQm1jAeb5NLkuDGdwCjIMOAIzzuAyvyPn736msriYry01fH8= X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 5F7BC5092116 X-Stat-Signature: 4ajnhpuhoya5czkwjpxw6cxkb9tr7hd8 Authentication-Results: imf01.hostedemail.com; dkim=none; spf=none (imf01.hostedemail.com: domain of arnd@arndb.de has no SPF policy when checking 212.227.17.24) smtp.mailfrom=arnd@arndb.de; dmarc=none X-HE-Tag: 1636927496-750492 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Nov 14, 2021 at 2:17 AM Randy Dunlap wrote: > > on arch/sh/, > CONFIG_SMP is not defined, > CONFIG_NUMA=y, > CONFIG_MEMORY_HOTPLUG is not defined: > > ../mm/slab.c: In function 'slab_memory_callback': > ../mm/slab.c:1143:23: error: implicit declaration of function 'init_cache_node_node'; did you mean 'drain_cache_node_node'? [-Werror=implicit-function-declaration] > 1143 | ret = init_cache_node_node(nid); > > > commit 76af6a054da4 > Author: Dave Hansen > Date: Mon Oct 18 15:15:32 2021 -0700 > > mm/migrate: add CPU hotplug to demotion #ifdef > > > How should we handle this config? I think we can safely assume that NUMA without SMP is not a useful configuration on SH and add a dependency in Kconfig for it. I assume this came from some randconfig build rather than a config that someone was intentionally using? My guess would be that testing sh randconfig kernels is not overly productive as you likely need countless patches before there is a chance of it working most of the time. I haven't tried this myself, but I spend a lot of time fixing randconfig failures on arm and x86, and I whenever I try any other architecture, there is simply too much work needed upfront. Arnd